From nobody Wed Apr 19 20:26:07 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q1skS2Kdtz46QHH; Wed, 19 Apr 2023 20:26:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q1skS1bbDz4F29; Wed, 19 Apr 2023 20:26:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681935968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D04SrCaW7YhcL3VHOvQGXjAxTtQwrAvuxzcAlS4cS/M=; b=KkKtv/b1Vzv7J8yYGa/4jhEGzIdWQf+kQsfsilcLkG/V3w/GzM/AOsFCVaikkXIzEGtUwG 4ulQQ38QDFTl83RCcAML8kW+y1gTvUUCQlDcdoC0mQfKbrtwZ8HxypsR/Xhn/j9cArKAW4 I6NCl7uVNgBIH8Jy0yJwfyyTLMj8y4U0m03vdt6RWTiRoJdZSK7/57IDf4VgkE/qL0RSdF oO4u57VfyWxK1YdXY031+KAmD88LbVQCceHZT3rOhfY+npK3WcVKE68MJaRA0SiMJ/2T4G vVfvhDThOYgXfcgmCcDDLhu7z9UIk17GBiI3DcA1fYiHWW38Iz+aO2+oA99sKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681935968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D04SrCaW7YhcL3VHOvQGXjAxTtQwrAvuxzcAlS4cS/M=; b=Ez/ZuMpdcG6TrCTTZd9dj2tR/o32I3KqipmKRGF3VtG6ZUuXowd0vRL0UASZsirLjpNkkm PGy+L7f7IOrJkzysWlRw45GXHkE/9ro4HIWl7pY4urQi1TsHP0nyH3kR52R4Ecj8IqBahH w65ls/PMKp7iJgi0l3gzxWNyQE21jTGN+/ZDSXInFO/VuIzA+W1TdUrjNodyelerraBqy+ jUI3G5m2Av+pcpPDhgoYBguEh8bTg9keWX8bg/dCeeHVIMhz8TXD8siWBUTVordeG2LtGF SA/T8FhujKScriqjpxK1Yn71H3JCEa5kZWQ6FMlubqiJMQgpy6IihGnTg5QBlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681935968; a=rsa-sha256; cv=none; b=Kzi/fQlhpsFd91dhPtZesju+8vayKKYU1BNnKcutgyAUQr8NmF0F5Y4PuujMHFZ9pBztho hXBpFhNmBFQM25y/VPBpyr05QeUjvFxXWCEjbAUvPgNsIS1P+S+juh+l9rV4kEkhdfPamZ dvl27X4FrgqrjK5ejAIUQmx2/o8x3ZxhBykjLjQnBa9k1aGcRhv4N6QT1jGxIn+YBjGa3/ 6wCTkOcq/AUfRLlsDggRWXDdtR3E+lLgAQ59SnhOHZJZfs4wUtLvE5rInNiIJD+HlWhQM5 kHF7CPWSgj/8djG/XfcLCAGdPQi5f7KAutDgDfxgduJoZ5ApUmH1d3rFqH+UKw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q1skS0ZSgz17jj; Wed, 19 Apr 2023 20:26:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33JKQ7uI087346; Wed, 19 Apr 2023 20:26:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33JKQ7mU087345; Wed, 19 Apr 2023 20:26:07 GMT (envelope-from git) Date: Wed, 19 Apr 2023 20:26:07 GMT Message-Id: <202304192026.33JKQ7mU087345@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: 87f55ab0b46a - main - ichiic: use bool for one-bit wide bit-fields List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 87f55ab0b46ad72efee11d1b64ec8f839bb013da Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=87f55ab0b46ad72efee11d1b64ec8f839bb013da commit 87f55ab0b46ad72efee11d1b64ec8f839bb013da Author: Dimitry Andric AuthorDate: 2023-04-18 18:08:28 +0000 Commit: Dimitry Andric CommitDate: 2023-04-19 20:25:50 +0000 ichiic: use bool for one-bit wide bit-fields A one-bit wide bit-field can take only the values 0 and -1. Clang 16 introduced a warning that "implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1". Fix by using c99 bool. Reported by: Clang Reviewed by: emaste, wulf MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D39665 --- sys/dev/ichiic/ig4_acpi.c | 4 ++-- sys/dev/ichiic/ig4_iic.c | 8 ++++---- sys/dev/ichiic/ig4_pci.c | 4 ++-- sys/dev/ichiic/ig4_var.h | 8 ++++---- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/sys/dev/ichiic/ig4_acpi.c b/sys/dev/ichiic/ig4_acpi.c index 8f349b36f9dc..550763f90b0e 100644 --- a/sys/dev/ichiic/ig4_acpi.c +++ b/sys/dev/ichiic/ig4_acpi.c @@ -108,7 +108,7 @@ ig4iic_acpi_attach(device_t dev) ig4iic_acpi_detach(dev); return (ENXIO); } - sc->platform_attached = 1; + sc->platform_attached = true; error = ig4iic_attach(sc); if (error) @@ -127,7 +127,7 @@ ig4iic_acpi_detach(device_t dev) error = ig4iic_detach(sc); if (error) return (error); - sc->platform_attached = 0; + sc->platform_attached = false; } if (sc->intr_res) { diff --git a/sys/dev/ichiic/ig4_iic.c b/sys/dev/ichiic/ig4_iic.c index 7353a6fae844..b557df26e9d9 100644 --- a/sys/dev/ichiic/ig4_iic.c +++ b/sys/dev/ichiic/ig4_iic.c @@ -337,9 +337,9 @@ set_slave_addr(ig4iic_softc_t *sc, uint8_t slave) { uint32_t tar; uint32_t ctl; - int use_10bit; + bool use_10bit; - use_10bit = 0; + use_10bit = false; if (sc->slave_valid && sc->last_slave == slave && sc->use_10bit == use_10bit) { return; @@ -364,7 +364,7 @@ set_slave_addr(ig4iic_softc_t *sc, uint8_t slave) reg_write(sc, IG4_REG_CTL, ctl); reg_write(sc, IG4_REG_TAR_ADD, tar); set_controller(sc, IG4_I2C_ENABLE); - sc->slave_valid = 1; + sc->slave_valid = true; sc->last_slave = slave; } @@ -1009,7 +1009,7 @@ ig4iic_set_config(ig4iic_softc_t *sc, bool reset) (sc->cfg.bus_speed & IG4_CTL_SPEED_MASK)); /* Force setting of the target address on the next transfer */ - sc->slave_valid = 0; + sc->slave_valid = false; return (0); } diff --git a/sys/dev/ichiic/ig4_pci.c b/sys/dev/ichiic/ig4_pci.c index 2316e0cac1d0..242cf7e6ecec 100644 --- a/sys/dev/ichiic/ig4_pci.c +++ b/sys/dev/ichiic/ig4_pci.c @@ -316,7 +316,7 @@ ig4iic_pci_attach(device_t dev) ig4iic_pci_detach(dev); return (ENXIO); } - sc->platform_attached = 1; + sc->platform_attached = true; error = ig4iic_attach(sc); if (error) @@ -335,7 +335,7 @@ ig4iic_pci_detach(device_t dev) error = ig4iic_detach(sc); if (error) return (error); - sc->platform_attached = 0; + sc->platform_attached = false; } if (sc->intr_res) { diff --git a/sys/dev/ichiic/ig4_var.h b/sys/dev/ichiic/ig4_var.h index 608c925df38e..99c1b854514b 100644 --- a/sys/dev/ichiic/ig4_var.h +++ b/sys/dev/ichiic/ig4_var.h @@ -91,10 +91,10 @@ struct ig4iic_softc { struct ig4_cfg cfg; uint32_t intr_mask; uint8_t last_slave; - int platform_attached : 1; - int use_10bit : 1; - int slave_valid : 1; - int poll: 1; + bool platform_attached : 1; + bool use_10bit : 1; + bool slave_valid : 1; + bool poll: 1; /* * Locking semantics: