From nobody Mon Apr 17 06:30:21 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q0HH514Zwz45R5m for ; Mon, 17 Apr 2023 06:30:25 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q0HH46RqMz3sMj for ; Mon, 17 Apr 2023 06:30:24 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-3f167d0c91bso12690035e9.2 for ; Sun, 16 Apr 2023 23:30:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681713022; x=1684305022; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GpIjOYiQzE4p4FflA/ogL1vLMvWmX7sajFph8kCDuQ8=; b=gYqvSbYojgJoL9dYUN3Rbcys5StDq/vOMy9CWeSNILZ6WxphmwI7pCxlaXZvMGNYzl SLyII1XOcGjKwUG5kBKGJyeMo+9JWb0GXnpQAsVYSq1DHtjMrS5kA7/TggfJQ3kCiUjq X+c6EKI66cuJygV0HX29YkG384FsE5RJTMRBc7Nf/yJ1srpdLVwDU9sCJRC6OYczwNQQ fK2BGMnJUBRKkBs7F1VrXG1klkhprZEtZoCX+oVLzvFENgF67ZA5ztS5UAGHyEEe7Js3 fkdVl+gXni1trzZX7m44L5EU6NDa7WDRUTbQS392VdP9Zwnv+8iW9+QF2Hw/weC+sA7N /L0A== X-Gm-Message-State: AAQBX9d8PQYARjI0zuijxt1eNxQZelwsHzKA4QVBcsrLh5W8wVlq5ImZ ggpCXD1sxAjwyuDFr9O86dLvrQ== X-Google-Smtp-Source: AKy350bCJB8XZOC/XAduEyRQmPjHMO0eNgVqzJNnoFskxzX+XcLfjkFaVU0/lVIkgYGryabeylHauA== X-Received: by 2002:a5d:658a:0:b0:2f0:bab2:dc3c with SMTP id q10-20020a5d658a000000b002f0bab2dc3cmr4556449wru.27.1681713022732; Sun, 16 Apr 2023 23:30:22 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id p14-20020a05600c468e00b003f16ed11cf5sm5187701wmo.37.2023.04.16.23.30.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Apr 2023 23:30:22 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 6ae8d57652fa - main - mac_veriexec: add mac_priv_grant check for NODEV From: Jessica Clarke In-Reply-To: Date: Mon, 17 Apr 2023 07:30:21 +0100 Cc: "Stephen J. Kiernan" , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <8180B6AE-D70B-443D-80BA-1667E4642854@freebsd.org> References: <202304162314.33GNEwXd039914@gitrepo.freebsd.org> To: Alexey Dokuchaev X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Rspamd-Queue-Id: 4Q0HH46RqMz3sMj X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 17 Apr 2023, at 06:47, Alexey Dokuchaev wrote: >=20 > Jessica, >=20 > Please don't overquote: you complain about commit log, but included = the > commit diff in you reply. Why? This is quote annoying on slow = networks > and could cost people some cash on metered connection. Seriously? I=E2=80=99m hardly the only one to do that sometimes, and = there=E2=80=99s no rule that I know of against it. I only trim when things get unwieldy, but I=E2=80=99m not going to trim for a +45/-2 diff. My whole email was = 7 KiB *including* headers, with the commit diff being about half that, and it=E2=80=99s 2023. This is quite an outrageous complaint to make in my = opinion and I question why you=E2=80=99re going after me rather than anyone = else, especially when it=E2=80=99s about 3-4 KiB. Your complaint is already = about 5% of that, and this response is about 15%, so between them that=E2=80=99s = 20% of the complained-about amount exchanged again. That=E2=80=99s how tiny the = amount of data you=E2=80=99re complaining about is. > On Mon, Apr 17, 2023 at 12:40:07AM +0100, Jessica Clarke wrote: >> ... >> Hi Steve, >> I see you've made a bunch of commits over the past few days that = suffer >> from not following the proper commit message formatting outlined in = the >> Committer's Guide >=20 > What's exactly wrong with them? They appear more elaborate and = detailed > than usual, I like this. * The trailers shouldn=E2=80=99t have blank lines between them * It=E2=80=99s Reviewed by, not Reviewers * Subscribers isn=E2=80=99t a thing * Some had Summary: as the first line of the body These are all just a case of taking Phabricator=E2=80=99s auto-generated = commit message and pushing that without taking the time to turn it into a message appropriate for FreeBSD. Jess