From nobody Fri Apr 14 14:28:42 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pyf2P472yz45LsM for ; Fri, 14 Apr 2023 14:28:45 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pyf2P2CPxz4MV5 for ; Fri, 14 Apr 2023 14:28:45 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-qt1-x82d.google.com with SMTP id m21so8214127qtg.0 for ; Fri, 14 Apr 2023 07:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1681482524; x=1684074524; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XkyIxHetDhhiwCQGwKFA7ybmK+IKvlrPEvTT3V81Nc0=; b=R4peEwTNrbd8WWA54RNjQzjMSSzwTuB1DyUQd1+X7DPqxK/GMM097u8XIIl6yDQJez QpR19YTjOWZJZbWP5Mf0qPNIAM/OuDtuM9Zkms1SnWp24NZsD+bMs/ZmA1uNRRenG7jA PRE7hfIHU9cqwXjiGL710FjBKod1amIgW8IB8daMqSJpa0wp/yV5MDdpqWXaKhAEZDMu Mm/vG1bu9+uRQlTypiY5MVzwSGW7yE4Hv+SFrdanwIyyex8aHKJws2Zv2FPC2vDJ8iW/ hSkBTTqc9OZpRf1nQMvhFHQm5OnXroIXyQXgvSMbMSzvaDmMT6g4YXoVA8MlWN/tr1zV 86yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681482524; x=1684074524; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XkyIxHetDhhiwCQGwKFA7ybmK+IKvlrPEvTT3V81Nc0=; b=ScmjPFKj8oQ28PdUYNUFIcYyZeZwSNhMIojkA9mtSvzg2OWUi3PgwsZmO1MD0MHEYJ 8L0fxMI96/9GTBGf2FKnm3HaF69IW3LHohxV1rZJkXFK40iNg8JIxpHR7aMfNY5vYa1W PHucMHmy3EJUCyatmrnAWOwIxFDpZRYd7uQt3m5whg9GeV214oX2RgrDG+4kRvXTTjKs MN2yEbaXs5xwTNU82N1QvFy6CqwlCkctQnOSLuAUrD8ea2SjMPB7d2NaNAhzNjzgeeka 83aP/gWBspNUJePcu1hMOcoVvH9BBe8cXzla0t11LX6Len2Uqzlwvao6zM8Y6wSm30vi eAPQ== X-Gm-Message-State: AAQBX9fx4RtBeaygkwnCtGrBuapb7hnatBhykwjHf2RiqosBUZF/pwqO PCCxVj8L5gq9Q2hEhjWbAGkEJw== X-Google-Smtp-Source: AKy350akg3c07tz5BVyDAYiXXu9wiQsao9p9I7LIsWEKx3nwTDW2IvhVVH6kn4Hpa3I0rfxNVzf+BQ== X-Received: by 2002:a05:622a:1811:b0:3d0:7bdf:42c4 with SMTP id t17-20020a05622a181100b003d07bdf42c4mr8922345qtc.59.1681482524343; Fri, 14 Apr 2023 07:28:44 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-219-215.bltmmd.fios.verizon.net. [100.16.219.215]) by smtp.gmail.com with ESMTPSA id a24-20020ac84358000000b003e64303bd2dsm1246579qtn.63.2023.04.14.07.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 07:28:43 -0700 (PDT) Date: Fri, 14 Apr 2023 10:28:42 -0400 From: Shawn Webb To: Charlie Li Cc: Cy Schubert , Mateusz Guzik , Pawe? Jakub Dawidek , Mark Millard , dev-commits-src-main@freebsd.org, Current FreeBSD , pjd@freebsd.org Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 Message-ID: <20230414142842.sgeikpg4r5xunqye@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <20230413071032.18BFF31F@slippy.cwsent.com> <20230413063321.60344b1f@cschubert.com> <20230413135635.6B62F354@slippy.cwsent.com> <20230413140504.nnm23cjjv65mwzjr@mutt-hbsd> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rmiz7lrozzjjacb7" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4Pyf2P2CPxz4MV5 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --rmiz7lrozzjjacb7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 13, 2023 at 06:48:14PM -0400, Charlie Li wrote: > Shawn Webb wrote: > > Does the ZFS project have some sort of automated testing to catch > > data-gobbling, pool killing bugs? It seems like this would have been > > caught with some CI/CD stress testing automation scripts. > >=20 > I can't speak about how the OpenZFS project does things, but this particu= lar > corruption does not have any deterministic characteristics both pre- and > post-condition, so would be hard to automate testing. My approach would be to have a policy by which any new feature scheduled to land in the main branch must also not show any regressions when running `poudriere bulk -ac`. Such a policy could be enforced via server-side git commit hook. One problem, though, is that implementing that policy isn't just a matter of code, but also infrastructure, so there's a tangible monetary cost. I should mention that I appreciate the selfless hard work of those involved in the FreeBSD and OpenZFS projects. I hope for continued incremental improvements. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --rmiz7lrozzjjacb7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmQ5YxMACgkQ/y5nonf4 4fqB3Q//bNZCvDRWBsHONFrv+YamUmRi09dIEtZX9Cx+OprGvN+S4Rbq2lDhrpyW Wg5BWdj4mvJKEHU5RNjjWfJqWRulBwE0RDSPTo8ub2w3kr0+hKPF1lzZ7AC29uPU K0WYCz1p8mfwu+LhfgCEMOJsCErWeCRUejQijVLScGbkxnKufHu18Ske4KgJBgOd iab3gMZ+gE9jX4XMB623QaZkmmDnsBvaCCAmchx4vX7xVU8mNRvYfARTCQUx/pvS 2wFm67bDS+JULf7kfLwnv01DCJqNgdB3j4fSUSib0thYoJHSNC4Q91dl+dQSNsv8 c0aetNqGkeDGiRjRuSLige/tSGx+HRVA8womssUVBduLGIF8dMKqjQIrNXRmhnBH DcldNuHBVfzq9GWlfjZcBLRzWxXVqDxllvNIUznF2K9DmNLBKn0LB/mN1jD9TIcp R4GG6g6zbV7Uv/alb9+KOZwYOL7ZLYMfHcxI0SKfzQ+HWTfIdqCsVaydkR2NAdPs hxQkQjMup6t1xU8Q1sfmNujnXvy1QpaadVJYP27r7r5umJ1Szyjai3VeI6AD4l/G uZ/k3MOdSnzQFygWe1UVjzBEMTXxBZoUYbsHS8sQhUCJhEhubBh1c18USEgmKeVV MI4RdOkMmebhiN/uPQOW0fHSKq0M2p/WalTSFDZDxL+D/L3mDMk= =MCrJ -----END PGP SIGNATURE----- --rmiz7lrozzjjacb7--