From nobody Fri Apr 14 04:39:29 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PyNyq16sDz45N4Z for ; Fri, 14 Apr 2023 04:39:47 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic303-23.consmr.mail.gq1.yahoo.com (sonic303-23.consmr.mail.gq1.yahoo.com [98.137.64.204]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PyNyp2JR7z3Kfy for ; Fri, 14 Apr 2023 04:39:46 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681447184; bh=qLb6C5wf1sfaU+vK5XRO0Wkqy7nDPZ8gJDhNpgp0XXQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=cD1vl7Q61XBxhDb/uJbe/pKYuy3wuzw5Bt5T3G8FjNpt4qGL6X1SE6zM0rmDgb2JBg9Typ7/sjFh7djtD2UBe7VufoMzhoLtWf3ATtw1Zl3y0Ua8f3qRoW7A17dikedLUqP5Eswnk5wPW/1p4uint+PQM+gGt0jHyK8OIf6H3YuBY6oNkU+kKOFoms0bc7eIj5T0ofoU1waLyw7+jP7fnm/UME6IBo3yReswsGnPSDGppKsnJH4Ext9laPvNE8CwpTZS738gDz6VxfuaaqthduT5I9wUC+Juh4y4XdG4jwlZLRzTInxdJHciJyTjFP4FAr5F2Cj7xIGFj1bqMjxmxg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681447184; bh=CGM3pJy48LezBw+Z6gAze3pZQfOq/xXkA1s02GA3oNz=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=KvGWN2zoTvtjsIGrkSCckOoDAUQYf7Ud7fFoDEEt/q0rA3VKaiM55gS7W/W+ugF2A64U4mww9Wo9kgOUe5SMBxR1EctUfx4A6Gmp1l9P3euP+LXcwrf0pyaCpn6dO89JObUAH8EKkUAeoiyUWn5G3Ncpjrh5jUxBcb2rtRVYFrLKaomQtOImuUtrUORJzUUEboo0mdsVJ6Z1xITckX5xua6cTzgQtHBOMpbgQyO3nIDlhH2ruCihwYOQrpTER1c8q2eGX3tqdgn/lxPv6i71YpnrbTCz2UMkov+PZ1zuitTWMsGmfIZOK1I7xzlgzt+EYsEbqSA4a9zutY0xhgD2jQ== X-YMail-OSG: jzZh44cVM1lgr.ym2YExJc6STphNciotXXGnNPxVXu1o0U_MjjX0IwRDA841j21 GWYR1LhpxXGSP2Na.OCXuOaKbOf49tUlj1MNtZ_Od9ZFOZ.i1hVXjdHK4aFT7PlvLIYvyWlkD37_ _btIoiZY3Kv.SduRW5MWXW9dhhgBroSk4XjtJ32vMWK49m62XLa94mL8BkAU64o_VMsw7_fD45Ju Rs9dVs.KAFzzKusa9YqyFv9EGRd34cH2iCZRflpCICbc7.aeDsIKoJzhnwaRbAN.KCD4cKIBOwkv 5HgVeUnx86Ogm07GIVj9VMa8LhcRCfRvKBE_WdUny.d_v90Cd.IshHUXUd6KGsrxiSjl76BxpXU. Cg0Dd_fjOqZUu1OTWZ89rjw1pWdbsaVRnGxrMNbE4K4KGs1__nVnR5UdcE0cWCkBW3NsEz5pDRBs mfhFcakw17hELJB0kg9aBC83p1I87jDq2NWsG.DW2LC5N0ddOH6VZOs2AsFuYgyzI4e7h0169B4U xRvHCAksdNtG3IRNbsSmQNoofZP16sBJq1FOdv9AsRYCZ5sGEtdUnbysub4enQruOoc3q4VK6WHp 24nmofYE3B_pT4hPgnxEIYYHjB27y.4tLftaU3XbYnL3AyukNQkQ_mMgM2U1uRzAiuG6GqPYZTSK 0QCLzoc06gnd18Idi9UjEyIibNpXgNcGnqltEGCu.1WSUhBnF.JPVq4.Gp.apcvjRRm_xJgVKmZb 5yF6MvPGnrjBwlBYZfUJCAJIrVzHqyz0ZNkqyNQ.L0UO2ry6YcRhQqzT6uYY5r3mWbuSdjS_jMF. CeBzcNpO4gAL07ejuLtBEASy1T4gFbl9AsQJL4dYV0MJn57g8q6LsZvQ2fyBkNp7mKeItsjoDKqD .QdmVQlb1qN7e9rxuH.utgdpkk.vTcq6cqHKZL3haWKl61H5BTE9IJyZfFU488LNVQaVLJQ1PHrD fneyolFcmhWe.JmcMLJ.OFlYpTt_cFmJgsqA54dhIAycHN3pBwEC7s_4JuxFJoVf_1YTZOzJiBF8 U_SyN7bRyU8YwZWzH_H9XUTwHXm6jlbXwCXLeK4KiiV9SFmMh4qPYLBDlsLt2Mas7FiWRxcYxkGj hGyjlpOc4ahnjgZjcpTD4l6oBVIRSbfCxjVcAUZhm06D_aSKKDRrcrLVOZkT_Y6XTcx20Prc61j4 al5pKIVoBWw.UIQ1XFCkP2WOzjWNmAbipNNGrb5cxu9M6_R0qKFIIEaaKckKnl8nOwZpoF9qPB3N 86p7d2j6aqB_HRJnkJcysKIGukkqsy5i0qF0lEM_st4_qfGA3IsY0ikTfnSpTYgDMJqr5NulVL0_ z9yTN_A00FY2ExI6K0Y_MVDRgZ54Rd7A5cAxEV3jXl4gozDQBjGHBeTYLxmV3yRy4WTynT1Va6_3 WxdAlD553vAa5i6RRdr_BVztoheVIjGgHhEgB2ACqwd1K4gHo71H.HCkTTgnngCOpNeCO_kKEHis bLghdvf9wg9G1oGUe_KB72CZDuRcHVKo6pB0cRrDikbvRHFP8jWLagRoBvLNMdk6Ad_QxME3c6dv XqtOwDXW1YBgj8IbZUYFJa0DmDTa2rxLvdth1uq0NMKnVOMKljj7lwqH8bE9uGPuro5qGjN5jbv7 11kFD82f.GroMdrEadlJF51xQC_Mo9wNWnD4ihcOp3cvap47Cc2W0_caKY.OUSmuRNVPjEPeCgc8 92AKWSE3lS_ybbkwk85ktPzHf7CMo0FLZ2bv4EVrG7QYJTpiPAh2nB47jaIud8zm1nH3JMhvP2.b MJi.RU5oPM52_.0tltIq9KCHESUEh8Yqw29ldKoInLMMdhnpm00anlMfXOKsUR5u0RE6R1PSnITQ 7ES.TIhWpu2RDMh1bjB_cgNQQtOKELSlYmjlopS_aRt23bLQ297.n5WyFoEdyrje16cOup5Tbtiw w2xnycDsTosJtlaS1gX0ZNSPxPIPglhXABdjnk6pBR0Q8wxrjVGDv8sYII2polAlsgq5oDHNmTq0 aosnpYxtXMBtxeMdhtRW4r0KNRKUNJLIb7.CmtxyIe.HX9s3Zti9zTh00vkFsHeI5d0UsWVwiglP k9Hlz9ZgkJmG7ANFgkLH6G6K7SKMy8YOFnQ4WUMrlq2fUiNIVxzulOr1Oi0PZjZKVBJDgTcCQ6gQ gXu.D00poGzVj63LclCQ9.hvxGOHAnyf8gKBK5ho87pkfMXK55XlTfVZIZ_kVxjcgjHJhcTXLh_O MpnUDTH3JGshFz9oXrrGUfLmxZCGszvE0JPasQMnpd.keyLulbKqxSa_LQfqC0QGySu0wQDzhXvi Q X-Sonic-MF: X-Sonic-ID: 893398a3-e78f-45ca-9925-7e16de6c4638 Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.gq1.yahoo.com with HTTP; Fri, 14 Apr 2023 04:39:44 +0000 Received: by hermes--production-ne1-7dbd98dd99-zgnmj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a8740944bb247395853dd8ed0631549c; Fri, 14 Apr 2023 04:39:40 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 From: Mark Millard In-Reply-To: <5ce72375-90db-6d30-9f3b-a741c320b1bf@freebsd.org> Date: Thu, 13 Apr 2023 21:39:29 -0700 Cc: Pawel Jakub Dawidek , Cy Schubert , Mateusz Guzik , dev-commits-src-main@freebsd.org, Current FreeBSD Content-Transfer-Encoding: quoted-printable Message-Id: <99382FF7-765C-455F-A082-C47DB4D5E2C1@yahoo.com> References: <20230413071032.18BFF31F@slippy.cwsent.com> <20230413063321.60344b1f@cschubert.com> <20230413135635.6B62F354@slippy.cwsent.com> <319a267e-3f76-3647-954a-02178c260cea@dawidek.net> <441db213-2abb-b37e-e5b3-481ed3e00f96@dawidek.net> <5ce72375-90db-6d30-9f3b-a741c320b1bf@freebsd.org> To: Charlie Li X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Rspamd-Queue-Id: 4PyNyp2JR7z3Kfy X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Apr 13, 2023, at 21:27, Charlie Li wrote: >=20 > Pawel Jakub Dawidek wrote: >> On 4/14/23 09:23, Charlie Li wrote: >>> Pawel Jakub Dawidek wrote: >>>> Here is the change that reverts most of the modifications and = disables cloning new blocks. It does retain ability to free existing = cloned blocks and keeps block_cloning feature around, so upgraded pools = can be imported and existing cloned blocks freed. >>>>=20 >>>> It does not handle replaying ZIL with block-cloning logs, so make = sure you import pools that were cleanly exported. >>>>=20 >>>> I'd appreciate if someone who can reproduce those corruptions could = try it. >>>>=20 >>>> = https://github.com/pjd/openzfs/commit/f2cfbcf76a733c44e25cba8c649162ef6804= 7103 >>>>=20 >>> Does not apply to sys/contrib/openzfs tip, conflicts in = module/os/freebsd/zfs/zfs_vnops_os.c and module/zfs/dmu.c. >> This should work: >> https://people.freebsd.org/~pjd/patches/brt_revert.patch > This results in missing files rather than corruption. FYI: in my original report for a context that has never had block_cloning enabled, I reported BOTH missing files and file content corruption in the poudriere-devel bulk build testing. This predates: https://people.freebsd.org/~pjd/patches/brt_revert.patch but had the changes from: https://github.com/openzfs/zfs/pull/14739/files The files were missing from packages installed to be used during a port's build. No other types of examples of missing files happened. (But only 11 ports failed.) =3D=3D=3D Mark Millard marklmi at yahoo.com