Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75

On 4/14/23 07:36, Pawel Jakub Dawidek wrote:
> On 4/13/23 23:05, Shawn Webb wrote:
>> I've learned over the years downstream that it's not really my place
>> to tell upstream what to do or how to do it. However, I think given
>> the seriousness of this, upstream might do well to revert the commit
>> until a solid fix is in place. Upstream might want to consider the
>> impacts this is having not just with downstream projects, but also
>> regular users.
>>
>> Really bad timing to have a lot of new tax documentation that I really
>> don't want to lose. I'd really like to have an up-to-date, security
>> patched OS, but I guess I'll stay behind so that I don't risk losing
>> critical financial documentation.
> 
> Shawn,
> 
> I'm working on a patch to safely revert this that would also work for 
> people who already upgraded their pools.
> 
> I'm sorry for this mess.
> 

Here is the change that reverts most of the modifications and disables 
cloning new blocks. It does retain ability to free existing cloned 
blocks and keeps block_cloning feature around, so upgraded pools can be 
imported and existing cloned blocks freed.

It does not handle replaying ZIL with block-cloning logs, so make sure 
you import pools that were cleanly exported.

I'd appreciate if someone who can reproduce those corruptions could try it.

https://github.com/pjd/openzfs/commit/f2cfbcf76a733c44e25cba8c649162ef68047103

Thank you guys for your help!

-- 
Pawel Jakub Dawidek