From nobody Wed Apr 12 18:28:09 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PxWRf5mXBz44V6Y; Wed, 12 Apr 2023 18:28:14 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PxWRf3dvpz41Fr; Wed, 12 Apr 2023 18:28:14 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id mX64p7g51jvm1mfCXp89lX; Wed, 12 Apr 2023 18:28:13 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id mfCVpSVBV3fOSmfCWpclJQ; Wed, 12 Apr 2023 18:28:13 +0000 X-Authority-Analysis: v=2.4 cv=J8G5USrS c=1 sm=1 tr=0 ts=6436f83d a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=IkcTkHD0fZMA:10 a=dKHAf1wccvYA:10 a=pGLkceISAAAA:8 a=NEAV23lmAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=fWrN1aOx0V_uFX-ik18A:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from [127.0.0.1] (unknown [24.244.23.74]) by spqr.komquats.com (Postfix) with ESMTPSA id 6FE944A0; Wed, 12 Apr 2023 11:28:11 -0700 (PDT) Date: Wed, 12 Apr 2023 11:28:09 -0700 From: Cy Schubert To: Mateusz Guzik , Charlie Li CC: Rick Macklem , Martin Matuska , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 In-Reply-To: References: <202304031513.333FD6qw014903@gitrepo.freebsd.org> <20230403235851.84C0467@slippy.cwsent.com> <20230404052811.DA2172C1@slippy.cwsent.com> <7c75b934-cb0a-b32e-bc19-b1e15e8cf3aa@freebsd.org> <20230409154042.0685a273@cschubert.com> <707e4671-d746-aa23-e340-6eb8f50f78c6@freebsd.org> <20230409205826.7802259d@cschubert.com> <4e85eb84-f0cc-2f8c-d3d9-1e016ede042a@freebsd.org> <20230410165406.51bcd958@cschubert.com> <70739834-4eea-db30-63be-556bcfd881a1@freebsd.org> <464cc8cd-2bf6-b7e5-3823-89227d842458@freebsd.org> <64e4af2a-5273-6219-c146-f867160f09ac@freebsd.org> Message-ID: List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CMAE-Envelope: MS4xfKxliIYCUSnWpKg0ljHuwee4+Kk/M+HXhhJAtgbPkz0IRisxW1CTtMIuFRPaVi8xTzkVidJkjVgksP/c8NZ/FjFTOj4RIygPPkHwxkTRnbn5htZpVju1 9ZrAVwy+6v3v1Z8Mtto+1OxSdX1yhO0x0rpHMcie5GwoqMsKGion6Xb2elICLxSE83IhGSKgaOUe1BEr8oyBCPqBE0DHKfB0CD5hQZczSCTZoRGVlqf42sLw JszW1HAKvdhnpElzD1QLD+ovpz6J/WxrCs6MQuRo8Sw67jA8gNBZ2LncJ6NWVSwekjMb5eATlL13jDwvJ8gDgZoK0cotiLYa6udABjh2NvFu8bKGS7x/a1V/ uJoxg5kk7lkBe9K8f8kqoC0H/4QP74X7BDT/bzgYSax+FCIbsxU+zfYQvnX5/cpZ19K0o9g+ X-Rspamd-Queue-Id: 4PxWRf3dvpz41Fr X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On April 12, 2023 10:28:26 AM PDT, Mateusz Guzik wrot= e: >can you please test poudriere with >https://github=2Ecom/openzfs/zfs/pull/14739/files > >On 4/12/23, Charlie Li wrote: >> Charlie Li wrote: >>> Cy Schubert wrote: >>>> On April 12, 2023 8:51:09 AM PDT, Charlie Li >>>> wrote: >>>>> Cy Schubert wrote: >>>>>> I have a "sandhbox" pool, called t, used for /usr/obj and ports >>>>>> wrkdirs, and other writes I can easily recreate on my laptop=2E Her= e >>>>>> are the results of my tests=2E >>>>>> >>>>>> Method: >>>>>> >>>>>> Initially I copied my /usr/obj from my two build machines (one >>>>>> amd64=2Eamd64 and an i386=2Ei386) to my "sandbox" zpool=2E >>>>>> >>>>>> Next, with block_cloning disabled I did cp -R of the /usr/obj test >>>>>> files=2E Then a diff -qr=2E They source and target directories were= the >>>>>> same=2E >>>>>> >>>>>> Next, I cleaned up (rm -rf) the target directory to prepare for the >>>>>> block_clone enabled test=2E >>>>>> >>>>>> Next, I did zpool checkpoint t=2E After this, zpool upgrade t=2E Po= ol t >>>>>> now has block_cloning enabled=2E >>>>>> >>>>>> I repeated the cp -R test from above followed by a diff -qr=2E Almo= st >>>>>> every file was different=2E The pool was corrupted=2E >>>>>> >>>>>> I restored the pool by the following removing the corruption: >>>>>> >>>>>> >>>>>> slippy# zpool export t >>>>>> slippy# zpool import --rewind-to-checkpoint t >>>>>> slippy# >>>>>> >>>>>> It is recommended that people avoid upgrading their zpools until th= e >>>>>> problem is fixed=2E >>>>>> >>>>> As of af7624ed3145, I just did this with an md(4)-backed test pool, >>>>> though with the second `cp -R` landing in a separate dataset, create= d >>>>> and destroyed for each test=2E No corruption either way=2E However, = my >>>>> poudriere builds still output/package corrupted files (particularly >>>>> those with null characters), probably after install(1) invocations >>>>> (not cp(1))=2E >>>>> >>>> >>>> You need to copy from/to the same dataset to reproduce the problem=2E >>>> Copying from a source dataset to a different dataset will avoid >>>> block_cloning=2E >>>> >>> Got the corruption now=2E >>> >> Clarify: no corruption without block_cloning, corruption with=2E >> >> What is still a mystery to me is how corruption happens even without >> block_cloning in the poudriere scenario=2E cp(1)/install(1) always happ= en >> within the same dataset, as this test=2E >> >> -- >> Charlie Li >> =E2=80=A6nope, still don't have an exit line=2E >> >> > > I'll test this on my scratch pool later today or tomorrow as I'm afk atm= =2E (Bottom posted because the app is configured so=2E) --=20 Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD=2Eorg NTP: Web: https://nwtime=2Eorg e^(i*pi)+1=3D0 Pardon the typos=2E Small keyboard in use=2E