From nobody Tue Apr 04 02:21:39 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PrBNH37Mpz43hn3; Tue, 4 Apr 2023 02:21:51 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PrBNH2hs0z417v; Tue, 4 Apr 2023 02:21:51 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pl1-x631.google.com with SMTP id le6so29920356plb.12; Mon, 03 Apr 2023 19:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680574910; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=D75xyb8c+bm9pMezZezJn/0tF4hvI35+bzNUkwPtvgA=; b=TVB72xKl66WmsnE8seqakg3ER2iJJTY+Vw7Im5mpXTRbTdSiZYV7G/NsvhitnPTsQC KR6ExwMXxJwB/Q1N37tyAZo6fx+4I5uoD9UzgMscjzKysKv1p9sPUXbnjQr06YkcUw05 Mh4VYra+M8zFsdjEEEs3jpN+f5DoA+XPKj6QUxVpuk93Anm4bpP+JtOzdjESVkOTa691 1oxiG7OU7AIIwhj1FknH9TCU2ifL0mZxgd+u2L1tNP0jaJreDCwvP+/vJJTtUkGAfpIC qgE4apEl1hb0hx9kT201Isry7Z0PBQG9DMHOMbUE0pyOEpSmFj+0Q1QyoJeOdIEg9s9k REPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680574910; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D75xyb8c+bm9pMezZezJn/0tF4hvI35+bzNUkwPtvgA=; b=mB/yv7qKIwv18Oq+VKmhdYrjrlDP7Csyj0xpdjiL0eHTSD5I8LIm1S/JBdI3dF4hif G0flBTR6Eb4EgVEWGseeE/Aq3Gt3Tj01aatK34LzATfSV5N7EIcRBZeYziCBspDfH+iU vrokPoC9VLN4ecHtPLWvXum/qtLpyRuq1nA43HB+H1OVvUQ8Xd53Ip7ZJY/oxAKUFmTu 6J7c77GMWf5H+h315Jgevn9kXkJrprVsqbs9IekpSpVxnQXum/yQMh2vQTEBYnyiTJci lzhh17TLMjClswmCEOXu5tDsAeTha8owHwpDUPHcaXrbteEOqzuvOCfrT4uGPd9mW7R2 /t3A== X-Gm-Message-State: AAQBX9cZY2s7kfh9Y7mqOEMop2rJx1bB2dwFw4VuMYZBCdyYB8Uq+Spx smFh+mFYux02TuwMlLy/M8vqEZQjkEd6qqRm3uHJfhUYrA== X-Google-Smtp-Source: AKy350YjEELPMxmeGZDqOgZj9kSVtmcfkySf3rZTg9UcNONxoB4BbzGKcRkdCYxwl5EnWC492HXt2e/B5af7yCmgCvs= X-Received: by 2002:a17:902:b48d:b0:19f:1ee9:a1b with SMTP id y13-20020a170902b48d00b0019f1ee90a1bmr408439plr.4.1680574909918; Mon, 03 Apr 2023 19:21:49 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202304031513.333FD6qw014903@gitrepo.freebsd.org> <20230403231444.CF48911F@slippy.cwsent.com> <20230403232549.73E331A2@slippy.cwsent.com> <20230403235851.84C0467@slippy.cwsent.com> <20230404002208.4CB2CD5@slippy.cwsent.com> In-Reply-To: <20230404002208.4CB2CD5@slippy.cwsent.com> From: Rick Macklem Date: Mon, 3 Apr 2023 19:21:39 -0700 Message-ID: Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 To: Cy Schubert Cc: Martin Matuska , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4PrBNH2hs0z417v X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Mon, Apr 3, 2023 at 5:22=E2=80=AFPM Cy Schubert wrote: > > In message <20230403235851.84C0467@slippy.cwsent.com>, Cy Schubert writes= : > > In message > om> > > , Rick Macklem writes: > > > On Mon, Apr 3, 2023 at 4:38=3DE2=3D80=3DAFPM Cy Schubert > =3D > > > om> wrote: > > > > > > > > In message <20230403231444.CF48911F@slippy.cwsent.com>, Cy Schubert= write > > =3D > > > s: > > > > > In message <202304031513.333FD6qw014903@gitrepo.freebsd.org>, Mar= tin > > > > > Matuska wr > > > > > ites: > > > > > > The branch main has been updated by mm: > > > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D3D2a58b312b62f90= 8ec92311 > > =3D > > > d1bd8536 > > > > > db > > > > > > aeb8e55b > > > > > > > > > > > > commit 2a58b312b62f908ec92311d1bd8536dbaeb8e55b > > > > > > Merge: b98fbf3781df 431083f75bdd > > > > > > Author: Martin Matuska > > > > > > AuthorDate: 2023-04-03 14:49:30 +0000 > > > > > > Commit: Martin Matuska > > > > > > CommitDate: 2023-04-03 14:49:30 +0000 > > > > > > > > > > > > zfs: merge openzfs/zfs@431083f75 > > > > > > > > > > > > Notable upstream pull request merges: > > > > > > #12194 Fix short-lived txg caused by autotrim > > > > > > #13368 ZFS_IOC_COUNT_FILLED does unnecessary txg_wait_syn= ced() > > > > > > #13392 Implementation of block cloning for ZFS > > > > > > #13741 SHA2 reworking and API for iterating over multiple= imple > > =3D > > > mentat > > > > > io > > > > > > ns > > > > > > #14282 Sync thread should avoid holding the spa config wr= ite lo > > =3D > > > ck > > > > > > when possible > > > > > > #14283 txg_sync should handle write errors in ZIL > > > > > > #14359 More adaptive ARC eviction > > > > > > #14469 Fix NULL pointer dereference in zio_ready() > > > > > > #14479 zfs redact fails when dnodesize=3D3Dauto > > > > > > #14496 improve error message of zfs redact > > > > > > #14500 Skip memory allocation when compressing holes > > > > > > #14501 FreeBSD: don't verify recycled vnode for zfs contr= ol dir > > =3D > > > ectory > > > > > > #14502 partially revert PR 14304 (eee9362a7) > > > > > > #14509 Fix per-jail zfs.mount_snapshot setting > > > > > > #14514 Fix data race between zil_commit() and zil_suspend= () > > > > > > #14516 System-wide speculative prefetch limit > > > > > > #14517 Use rw_tryupgrade() in dmu_bonus_hold_by_dnode() > > > > > > #14519 Do not hold spa_config in ZIL while blocked on IO > > > > > > #14523 Move dmu_buf_rele() after dsl_dataset_sync_done() > > > > > > #14524 Ignore too large stack in case of dsl_deadlist_mer= ge > > > > > > #14526 Use .section .rodata instead of .rodata on FreeBSD > > > > > > #14528 ICP: AES-GCM: Refactor gcm_clear_ctx() > > > > > > #14529 ICP: AES-GCM: Unify gcm_init_ctx() and gmac_init_c= tx() > > > > > > #14532 Handle unexpected errors in zil_lwb_commit() witho= ut ASS > > =3D > > > ERT() > > > > > > #14544 icp: Prevent compilers from optimizing away memset= () > > > > > > in gcm_clear_ctx() > > > > > > #14546 Revert zfeature_active() to static > > > > > > #14556 Remove bad kmem_free() oversight from previous zfs= dev_st > > =3D > > > ate_li > > > > > st > > > > > > patch > > > > > > #14563 Optimize the is_l2cacheable functions > > > > > > #14565 FreeBSD: zfs_znode_alloc: lock the vnode earlier > > > > > > #14566 FreeBSD: fix false assert in cache_vop_rmdir when = replay > > =3D > > > ing ZI > > > > > L > > > > > > #14567 spl: Add cmn_err_once() to log a message only on t= he fir > > =3D > > > st cal > > > > > l > > > > > > #14568 Fix incremental receive silently failing for recur= sive s > > =3D > > > ends > > > > > > #14569 Restore ASMABI and other Unify work > > > > > > #14576 Fix detection of IBM Power8 machines (ISA 2.07) > > > > > > #14577 Better handling for future crypto parameters > > > > > > #14600 zcommon: Refactor FPU state handling in fletcher4 > > > > > > #14603 Fix prefetching of indirect blocks while destroyin= g > > > > > > #14633 Fixes in persistent error log > > > > > > #14639 FreeBSD: Remove extra arc_reduce_target_size() cal= l > > > > > > #14641 Additional limits on hole reporting > > > > > > #14649 Drop lying to the compiler in the fletcher4 code > > > > > > #14652 panic loop when removing slog device > > > > > > #14653 Update vdev state for spare vdev > > > > > > #14655 Fix cloning into already dirty dbufs > > > > > > #14678 Revert "Do not hold spa_config in ZIL while blocke= d on I > > =3D > > > O" > > > > > > > > > > > > Obtained from: OpenZFS > > > > > > OpenZFS commit: 431083f75bdd3efaee992bdd672625ec7240d252 > > > > > > > > > > Just a heads up, I'm encountering the following error with an NFS= share > > =3D > > > of > > > > > a ZFS dataset. > > > > > > > > > > Fatal trap 12: page fault while in kernel mode > > > > > cpuid =3D3D 1; apic id =3D3D 01 > > > > > fault virtual address =3D3D 0x178 > > > > > fault code =3D3D supervisor read data, page not presen= t > > > > > instruction pointer =3D3D 0x20:0xffffffff814eebcd > > > > > stack pointer =3D3D 0x28:0xfffffe00ec6c7cd0 > > > > > frame pointer =3D3D 0x28:0xfffffe00ec6c7d50 > > > > > code segment =3D3D base 0x0, limit 0xfffff, type 0x1b > > > > > =3D3D DPL 0, pres 1, long 1, def32 0, gran = 1 > > > > > processor eflags =3D3D interrupt enabled, resume, IOPL =3D3D= 0 > > > > > current process =3D3D 3735 (nfsd: master) > > > > > rdi: fffff8020a6f8570 rsi: fffffe00ec6c80d8 rdx: fffff8020f56f3a0 > > > > > rcx: fffffe00ec6c80e0 r8: 0 r9: 1000000 > > > > > rax: 0 rbx: fffff80210123540 rbp: fffffe00ec6c7d50 > > > > > r10: 1876 r11: ffffffff81714596 r12: fffffe00ec6c7d20 > > > > > r13: 0 r14: fffff8020b2f3e00 r15: fffffe00ec6c7d68 > > > > > trap number =3D3D 12 > > > > > panic: page fault > > > > > cpuid =3D3D 1 > > > > > time =3D3D 1680563351 > > > > > KDB: stack backtrace: > > > > > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > > > > > 0xfffffe00ec6c7a90 > > > > > vpanic() at vpanic+0x152/frame 0xfffffe00ec6c7ae0 > > > > > panic() at panic+0x43/frame 0xfffffe00ec6c7b40 > > > > > trap_fatal() at trap_fatal+0x409/frame 0xfffffe00ec6c7ba0 > > > > > trap_pfault() at trap_pfault+0x4f/frame 0xfffffe00ec6c7c00 > > > > > calltrap() at calltrap+0x8/frame 0xfffffe00ec6c7c00 > > > > > --- trap 0xc, rip =3D3D 0xffffffff814eebcd, rsp =3D3D 0xfffffe00e= c6c7cd0, r > > =3D > > > bp =3D3D > > > > > 0xfffffe00ec6c7d50 --- > > > > > zfs_freebsd_copy_file_range() at zfs_freebsd_copy_file_range+0x1b= d/fram > > =3D > > > e > > > > > 0xfffffe00ec6c7d50 > > > Can you find out the line# for the above? > > > (I'll admit I don't know how to do that for loadable modules.) > > > > > > I know nothing about ZFS, but I might be able to spot why the > > > VOP_COPY_FILE_RANGE() might be crashing. > > > Looks like a NULL pointer reference to a fairly large structure. > > > (I don't think a zfs_copy_file_range() exists in older ZFS versions?) > > > > I don't think it does so it calls vn_generic_copy_file_range() instead. > > > > A workaround at vfs_vnops.c:3077 should fix it but I'm not sure if this= is > > the correct fix. > > Testing for NULL fsize_td at line 3077 of vfs_vnops.c avoids the panic. > Becau =E7=9B=8EQL se vn_generic_copy_file_range() can handle a NULL fsi= ze_td. > Yes, but it would be nice to use the ZFS specific copy_file_range() if poss= ible. (I don't know how ZFS uses the cred argument to zfs_clone_range(), so I cannot be 100% sure if using the NFS server's a_incred is sufficient.) Btw, related to the TO DO comment above zfs_copy_file_range()... If code were added at the beginning of the function to call vn_generic_copy_file_range() for the case(s) it cannot handle, then nfs_copy_file_range() could do the same for "not same mount" and then the "if same mount call VOP_COPY_FILE_RANGE()" could become unconditional and the "else vn_generic_copy_file_range()" coul= d be thrown away. I'll commit the nfs_copy_file_range() change, since it is trivial and harml= ess. rick > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > e^(i*pi)+1=3D0 > >