Re: git: 6bddde307e21 - main - Bump __FreeBSD_version for pmap_unmap*() and kmem_*() API changes.

From: John Baldwin <jhb_at_FreeBSD.org>
Date: Mon, 26 Sep 2022 21:20:53 UTC
On 9/26/22 6:54 AM, Renato Botelho wrote:
> On 22/09/22 19:10, John Baldwin wrote:
>> The branch main has been updated by jhb:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=6bddde307e21eba297ac3f3e534b4cf3be81dfe2
>>
>> commit 6bddde307e21eba297ac3f3e534b4cf3be81dfe2
>> Author:     John Baldwin <jhb@FreeBSD.org>
>> AuthorDate: 2022-09-22 22:10:03 +0000
>> Commit:     John Baldwin <jhb@FreeBSD.org>
>> CommitDate: 2022-09-22 22:10:03 +0000
>>
>>       Bump __FreeBSD_version for pmap_unmap*() and kmem_*() API changes.
> 
> Hello John,
> 
> emulators/open-vm-tools is broken after these changes:
> 
> --- vmmemctl ---
> os.c:445:14: error: incompatible integer to pointer conversion passing
> 'vm_offset_t' (aka 'unsigned int') to parameter of type 'void *'
> [-Werror,-Wint-conversion]
>      KMEM_FREE((vm_offset_t)p->bitmap, p->size);
>                ^~~~~~~~~~~~~~~~~~~~~~
> os.c:143:46: note: expanded from macro 'KMEM_FREE'
>      #define KMEM_FREE(offset, size) kmem_free(offset, size)
>                                                ^~~~~~
> /usr/src/sys/vm/vm_extern.h:73:22: note: passing argument to parameter
> 'addr' here
> void kmem_free(void *addr, vm_size_t size);
>                        ^
> 1 error generated.
> 
> I can take a look at it during the week, any advice is appreciated.

Hmm, ok.  I had built all the kmod ports with this change locally before
merging it and that one had built ok. :(  I'll look at it this week.

Oh, I just didn't create a commit for my changes to that port.  I'll
upload a review shortly.  https://reviews.freebsd.org/D36734

-- 
John Baldwin