From nobody Sat Sep 24 01:05:51 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MZ9nR1Rrvz4dNhY for ; Sat, 24 Sep 2022 01:06:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MZ9nR0zQyz3yyj for ; Sat, 24 Sep 2022 01:06:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vs1-xe34.google.com with SMTP id 129so1521958vsi.10 for ; Fri, 23 Sep 2022 18:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=rcgfBEp3SyiD3f1ihkoL1rRP+z6aIueL/8vnrqj6OnU=; b=WcLiIEVLuEdMLeJ1zmXoIHVeo6iuMgQwprVz0LR8/GJFceIM05bOoASX2uNRywbwUE OahnxSYbag4oGOq5H9N1qzrvGa5U6i1Xlg6NCK/iiX8YC4cnuZmHyMohJWnIbhsw0O0k WeE5XGc/aC2qV/mHSLGt6IuGPwt81Yt25DtlAEOkwejO5GMB2zyWJTTy/MaLDrWecsRN YoSgMzEPXSnuulWuvIT2YUFGQ3vMyAsNlX6p6aIb9XcSXao94C2eZ8PFQRC83g17RVqD yJXqX3woABnz2Kgrx65FXqJXoW2dO3ih+mLIeFCpu+vadtbRmoTlathrKIsFP88zgxMs ZXSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=rcgfBEp3SyiD3f1ihkoL1rRP+z6aIueL/8vnrqj6OnU=; b=IiZX0OQhi9yk4YIiyR19cQ0sqhIKxQV+vfGMg3NfNqKmBFB9Jgp9DQwek8KpvcACkN oS/a7tixWqrTWCypmfvI8qu8nqoIu8ilITkAcX09KgZWWyxnkRN91wSMWW/djvqHxwZ1 ld8e5D38ixXtWgx/M5GXEoDk6MhGZLu7geLxM9jInQmbwUPt0Fy2VABNZF/65pz7Hnqe F2obmFwsdffRReT19on4Px+aDRPDXaLWXc0fg03QsCz2NEqFi+L/Ct3JNGmWN4A3oFaJ kNoPG8rPBVET2JOA9qMoA9RF4uEntV3Z1sg05DB1o7DrJ42+GUdkROQiLfflnhxO2uZy Ihcw== X-Gm-Message-State: ACrzQf03Ag8h4gUy1OaA7hDnOEKK+3iWMhd/3iHo7hbSQRk6z3YCtZKI I1A410c2Nxje940u5FsRAVWDbZn83RtQcIxN+LTgRw== X-Google-Smtp-Source: AMsMyM5p739+YrtH0u6Luc9rv1OQWTsyX8cWnFIFYxZtJZ7XRRhiybl7RzHyc4c77hKn9jfo2DQ3HfQi0DfhNjfeJds= X-Received: by 2002:a67:d28e:0:b0:398:2d88:65ef with SMTP id z14-20020a67d28e000000b003982d8865efmr4201359vsi.11.1663981562371; Fri, 23 Sep 2022 18:06:02 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202208270418.27R4IkeL078154@gitrepo.freebsd.org> <0fccddc3-126d-f7b6-3b69-5fc1cbdb2775@FreeBSD.org> <7e773164-4317-ba17-1f26-1f382cf46fb3@FreeBSD.org> <20220924004655.42D9418E@slippy.cwsent.com> In-Reply-To: <20220924004655.42D9418E@slippy.cwsent.com> From: Warner Losh Date: Fri, 23 Sep 2022 19:05:51 -0600 Message-ID: Subject: Re: git: df065f699f1f - main - stand: More sensible defaults when ConOut is missing To: Cy Schubert Cc: John Baldwin , Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000f036fc05e961e571" X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4MZ9nR0zQyz3yyj X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --000000000000f036fc05e961e571 Content-Type: text/plain; charset="UTF-8" On Fri, Sep 23, 2022 at 6:47 PM Cy Schubert wrote: > In message <7e773164-4317-ba17-1f26-1f382cf46fb3@FreeBSD.org>, John > Baldwin > wri > tes: > > On 9/23/22 2:29 PM, John Baldwin wrote: > > > On 8/26/22 9:18 PM, Warner Losh wrote: > > >> The branch main has been updated by imp: > > >> > > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=df065f699f1ff819bb9607c44a675 > > 4275ab335ed > > >> > > >> commit df065f699f1ff819bb9607c44a6754275ab335ed > > >> Author: Warner Losh > > >> AuthorDate: 2022-08-26 21:46:33 +0000 > > >> Commit: Warner Losh > > >> CommitDate: 2022-08-27 04:17:56 +0000 > > >> > > >> stand: More sensible defaults when ConOut is missing > > >> > > >> When ConOut is missing, we used to default to serial. Except we > did > > it > > >> in the worst way possible by just setting the howto bits and not > > >> updating the console setting, which lead to weird behavior > where we' > > d > > >> get some things on the video port, others on serial. > > >> > > >> Instead, set console to "efi,comconsole" for this case. Also set > > >> RB_MULTIPLE always (so we get dual consoles from the kernel) > and or > > in > > >> RB_SERIAL when we can't find GOPs that suggest the precense of > a vid > > eo > > >> console. This will put output in the most places and have a > sensible > > >> default for 'primary' console. > > >> > > >> Sponsored by: Netflix > > >> Reviewed by: emaste, manu > > >> Differential Revision: https://reviews.freebsd.org/D36299 > > > > > > One possibly surprising result of this is that I did not get dual > console > > > output on my rpi after this. (Curiously this only affected my arm64 > image > > > but not my armv7 image.) Loader output goes to both, but kernel > output is > > > only on the video console (which I don't normally use for my pi). > (Also, > > > none of the ANSI escape sequences used by the loader work on the pi's > video > > > console, so once the menu starts it just looks like raw ANSI code > garbage > > > until the kernel starts booting.) > > > > > > Not sure if this warrants UPDATING as the effect is that the serial > console > > > seems to stop working? The lack of working dual console output is > perhaps > > > the only real bug. Not sure what is up there. > > > > FWIW, using 'console="comconsole,efi"' did not work as a workaround. > Same > > results (used the video console only for the kernel). Had to use > > 'console="comconsole"' in /boot/loader.conf. > > On one of my two machines with console="comconsole,vidconsole" failed to > get past loading the kernel. Booting a rescue USB disk and replacing > console with "comconsole" only resolved the hang. > > I'm not sure why it affected one and not the other as both are identical > hardware. > This is indeed weird. Both EFI or BIOS boot? Warner --000000000000f036fc05e961e571 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Sep 23, 2022 at 6:47 PM Cy Sc= hubert <Cy.Schubert@cschube= rt.com> wrote:
In message <7e773164-4317-ba17-1f26-1f382cf46fb3@FreeBSD.org>, = John Baldwin
wri
tes:
> On 9/23/22 2:29 PM, John Baldwin wrote:
> > On 8/26/22 9:18 PM, Warner Losh wrote:
> >> The branch main has been updated by imp:
> >>
> >> URL: https://cg= it.FreeBSD.org/src/commit/?id=3Ddf065f699f1ff819bb9607c44a675
> 4275ab335ed
> >>
> >> commit df065f699f1ff819bb9607c44a6754275ab335ed
> >> Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>= ;
> >> AuthorDate: 2022-08-26 21:46:33 +0000
> >> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>= ;
> >> CommitDate: 2022-08-27 04:17:56 +0000
> >>
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0stand: More sensible defaults when = ConOut is missing
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0When ConOut is missing, we used to = default to serial. Except we did
> it
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0in the worst way possible by just s= etting the howto bits and not
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0updating the console setting, which= lead to weird behavior where we'
> d
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0get some things on the video port, = others on serial.
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0Instead, set console to "efi,c= omconsole" for this case. Also set
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0RB_MULTIPLE always (so we get dual = consoles from the kernel) and or
> in
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0RB_SERIAL when we can't find GO= Ps that suggest the precense of a vid
> eo
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0console. This will put output in th= e most places and have a sensible
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0default for 'primary' conso= le.
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0Netflix
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0Reviewed by:=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 emaste, manu
> >>=C2=A0 =C2=A0 =C2=A0 =C2=A0Differential Revision:=C2=A0 https://reviews.freebsd.org/D36299
> >
> > One possibly surprising result of this is that I did not get dual= console
> > output on my rpi after this.=C2=A0 (Curiously this only affected = my arm64 image
> > but not my armv7 image.)=C2=A0 Loader output goes to both, but ke= rnel output is
> > only on the video console (which I don't normally use for my = pi).=C2=A0 (Also,
> > none of the ANSI escape sequences used by the loader work on the = pi's video
> > console, so once the menu starts it just looks like raw ANSI code= garbage
> > until the kernel starts booting.)
> >
> > Not sure if this warrants UPDATING as the effect is that the seri= al console
> > seems to stop working?=C2=A0 The lack of working dual console out= put is perhaps
> > the only real bug.=C2=A0 Not sure what is up there.
>
> FWIW, using 'console=3D"comconsole,efi"' did not wor= k as a workaround.=C2=A0 Same
> results (used the video console only for the kernel).=C2=A0 Had to use=
> 'console=3D"comconsole"' in /boot/loader.conf.

On one of my two machines with console=3D"comconsole,vidconsole" = failed to
get past loading the kernel. Booting a rescue USB disk and replacing
console with "comconsole" only resolved the hang.

I'm not sure why it affected one and not the other as both are identica= l
hardware.

This is indeed weird. Both EF= I or BIOS boot?

Warner
--000000000000f036fc05e961e571--