From nobody Tue Sep 13 14:32:50 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MRmCc0hpxz4cWBj; Tue, 13 Sep 2022 14:33:00 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MRmCZ1c3Kz3ygC; Tue, 13 Sep 2022 14:32:57 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1663079574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ah4zD2ZO8lNuwHpBrSPzPAo86P6w5N55PKY9fqCRegI=; b=J5xPCHltelgWHv376BuuCoGeil3F9+npLGphcq2lcN+Sc/16ubjTPXaG1w8SETHs4hKvG8 znm2wOLGuyNu6e+3zrUgMNAyEq5u9d3oQaNIOmXjQFjk/msNCojhZ3IDOLcLGXpNrKwVHv MrPD0gabPeQqDIXUMVk1dvRAV1BmYYI= Received: from skull.home.blih.net ( [94.238.214.231]) by mx.blih.net (OpenSMTPD) with ESMTPSA id f20b5472 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 13 Sep 2022 14:32:54 +0000 (UTC) Date: Tue, 13 Sep 2022 16:32:50 +0200 From: Emmanuel Vadot To: Mitchell Horne Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org, John Baldwin Subject: Re: git: 10c6af344108 - main - bhyve: Fix build when BHYVE_SNAPSHOT is set Message-Id: <20220913163250.199f7ae9cf021249846a9133@bidouilliste.com> In-Reply-To: <9903ef54-80a9-67e6-f9ab-1371c42916ff@freebsd.org> References: <202209130632.28D6WdW9021176@gitrepo.freebsd.org> <9903ef54-80a9-67e6-f9ab-1371c42916ff@freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4MRmCZ1c3Kz3ygC X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=J5xPCHlt; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[manu]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[bidouilliste.com:+]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, 13 Sep 2022 10:49:46 -0300 Mitchell Horne wrote: > > > On 9/13/22 03:32, Emmanuel Vadot wrote: > > The branch main has been updated by manu: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=10c6af344108a8cfdc431b5b304de9c0fddcec47 > > > > commit 10c6af344108a8cfdc431b5b304de9c0fddcec47 > > Author: Filipe da Silva Santos > > AuthorDate: 2022-09-13 06:30:41 +0000 > > Commit: Emmanuel Vadot > > CommitDate: 2022-09-13 06:32:09 +0000 > > > > bhyve: Fix build when BHYVE_SNAPSHOT is set > > > > Can this option be added to LINT? > > Mitchell Probably should as it would have prevent this, but I'm not sure of why this is an option currently, John ? > > > Fixes: 9cc9abf409cc ("bhyve: create all vcpus on startup") > > Sponsored by: Beckhoff Automation GmbH & Co. KG > > X-MFC-With: 9cc9abf409cc > > --- > > usr.sbin/bhyve/bhyverun.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/usr.sbin/bhyve/bhyverun.c b/usr.sbin/bhyve/bhyverun.c > > index 550cc9d15477..27f1d8ea8892 100644 > > --- a/usr.sbin/bhyve/bhyverun.c > > +++ b/usr.sbin/bhyve/bhyverun.c > > @@ -1244,7 +1244,6 @@ main(int argc, char *argv[]) > > #ifdef BHYVE_SNAPSHOT > > char *restore_file; > > struct restore_state rstate; > > - int vcpu; > > > > restore_file = NULL; > > #endif -- Emmanuel Vadot