From nobody Sat Sep 10 09:34:38 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MPnkl1plLz4bZds; Sat, 10 Sep 2022 09:34:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MPnkl1Lcsz3TMt; Sat, 10 Sep 2022 09:34:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662802479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m7scn8eIaGH8IKe+rceV553prJnl0Vvlvm24UP/gzPw=; b=LYLecP5IeKcODzfYE6VCFTGUnNpiwY3GjbG/9tRkEwTaw3oJNWAI9oU9KYh2oaL0u5+bSE bZ7/z5dHTpdXLsH3uZI4MZYh5aVJNCBYNidVcGMRnUsgvz9h3zV6ur1BygA4jnfveykPfK lwg8+omucRttExoaYahXPdMO7SKiQuTkw7SfB0X5+JfA+ytavSQYk33UNcaf9XYxX0lWpc Z9TfZjO9Lxp7EEnAW8PW5O8Hkr3/GeRZz1rJaG4v+uc58iSfIeKqLaaqz1gY2TxIsg4jQi A18oOS7OZb3vC/pAqadmliJgXkjNqmrrbdrTDoa4ImNbewWa41Uco34svuxJow== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MPnkl08b4zGYK; Sat, 10 Sep 2022 09:34:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28A9Yc3g064056; Sat, 10 Sep 2022 09:34:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28A9YcEX064055; Sat, 10 Sep 2022 09:34:38 GMT (envelope-from git) Date: Sat, 10 Sep 2022 09:34:38 GMT Message-Id: <202209100934.28A9YcEX064055@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 13018bfae80f - main - ip_reass: make stray callout assertion more verbose List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 13018bfae80f10bfcd6aad1fbe3e3feb24ffe353 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662802479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m7scn8eIaGH8IKe+rceV553prJnl0Vvlvm24UP/gzPw=; b=cph3osd8rAOSy1qRN4GlO+/snvZJIFXfcnp4Bj9kvBM04zR2GBrjpOUw1AlqJBn9vkt6cZ 4VewIzqCoeiFHvDMgIm+ojj2pon2zEPDYkxG8/3YC1MpgxJZYAiG51l22GEzXtDwYZJl10 cvHn5soIR62wqXXxZzJn8l/M8+49DAX0tINd3cjYudVXYObZV54MnJOxg84B5y3RE8wlOu YYI75WiCQ79BY9bLUoLwnh7/p1KtEk8DO3piMNbNCgkV5M/mxKsvTFFDEFflY20BLnWb9y 8T0lB2BIANcRZqfgh9QThnvMYUFnj9+a8UFNO6I8CFBxoOleOitQGvDPm0Nz6w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662802479; a=rsa-sha256; cv=none; b=uSOfMlKhcxusUCmSkdzSCFl2pjoa6TIiOEXxJGAFCwLY2lngloQNBrjzNbAvBaB9NVFUID WWMalVaioos3QxNVCbBmTZfqvsz79xTIyUXnyWBeWmd66Vn9BNDB7TfxNuxZhSsNEn64/+ EGqqBcLeuCd4dHoPIPT/9ZfUu0jmrfD7SyvkTDOxwEFpupHp3Z8bJ2huvdBlt2tlldSleH MtZ4L4f+KJebke7vUw1IXvWrgK1ouwuS7uUaDFaIX/Hlde8nzdQxl9YGYM0AIMHMK8wtCI zbEfAe+hdnEkHHZD9YYo7v2oZiGOqyo3ra5Fwf/545jgsYbbXARB6xLtTLLlUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=13018bfae80f10bfcd6aad1fbe3e3feb24ffe353 commit 13018bfae80f10bfcd6aad1fbe3e3feb24ffe353 Author: Gleb Smirnoff AuthorDate: 2022-09-10 09:11:39 +0000 Commit: Gleb Smirnoff CommitDate: 2022-09-10 09:11:39 +0000 ip_reass: make stray callout assertion more verbose Syzcaller hits this assertion, but can't find reproducer. I also never seen it hit in my testing. Try to get more information via syzcaller. --- sys/netinet/ip_reass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netinet/ip_reass.c b/sys/netinet/ip_reass.c index 5227b1387c69..aa5c99a3624c 100644 --- a/sys/netinet/ip_reass.c +++ b/sys/netinet/ip_reass.c @@ -600,7 +600,8 @@ ipreass_callout(void *arg) CURVNET_SET(bucket->vnet); fp = TAILQ_LAST(&bucket->head, ipqhead); KASSERT(fp != NULL && fp->ipq_expire >= time_uptime, - ("%s: stray callout on bucket %p", __func__, bucket)); + ("%s: stray callout on bucket %p, %ju < %ju", __func__, bucket, + fp ? (uintmax_t)fp->ipq_expire : 0, (uintmax_t)time_uptime)); while (fp != NULL && fp->ipq_expire >= time_uptime) { ipq_timeout(bucket, fp);