Re: git: f0d4c2afd65f - main - pmc(3): Correct some typos in event descriptions

From: Gordon Bergling <gbe_at_freebsd.org>
Date: Fri, 09 Sep 2022 07:03:06 UTC
On Thu, Sep 08, 2022 at 09:32:32AM -0400, Ed Maste wrote:
> On Wed, 7 Sept 2022 at 13:41, John Baldwin <jhb@freebsd.org> wrote:
> > > ---
> > >   lib/libpmc/pmu-events/arch/x86/broadwell/pipeline.json        | 4 ++--
> > >   lib/libpmc/pmu-events/arch/x86/broadwellde/pipeline.json      | 4 ++--
> > >   lib/libpmc/pmu-events/arch/x86/broadwellx/pipeline.json       | 4 ++--
> > >   lib/libpmc/pmu-events/arch/x86/cascadelakex/uncore-other.json | 2 +-
> > >   lib/libpmc/pmu-events/arch/x86/silvermont/pipeline.json       | 4 ++--
> > >   lib/libpmc/pmu-events/arch/x86/skylakex/uncore-other.json     | 2 +-
> >
> > I think these files are actually 3rd party (and should really be under
> > contrib/ in that case?) so probably shouldn't be changed.  Maybe you can
> > send the changes upstream to Linux instead?
> 
> Yes, these come from Linux and the fixes should be sent there. The
> process is a bit cumbersome but at least well documented; I've done it
> for a couple of pmu-events files before, e.g.
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=28396b7df09b9565f404591c9945eac43526cb3f
> 
> The process is documented in the Linux source tree at
> Documentation/process/submitting-patches.rst

I wasn't aware that those event files come from Linux. I will submit the fixes upstream.
If I remember correctly I have done some more spelling fixes, so I diff the
whole directory against recent Linux sources.

About the move to contrib, I could do that, but before I invest work in that
direction, a decision should be made before that.

--Gordon