From nobody Thu Sep 08 13:32:32 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MNg6S3BGWz4c7GS; Thu, 8 Sep 2022 13:32:48 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MNg6R2HLvz3Gx5; Thu, 8 Sep 2022 13:32:47 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-pg1-f170.google.com with SMTP id v4so16735326pgi.10; Thu, 08 Sep 2022 06:32:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=S9Fww25WJlWjPcDpTQMOwk1U8NC1VJDYZAfjX/j8/Uk=; b=0LNcnzv03ypFZ4ab1lTwE0eieGSbKx5wat2LJDNC0iHYjewHhE+YTxM+7jDLrT3rMr h7+PrLskjbWYsZIbkLEoVcS3e8NUptrWsE8+zDM9JerTCb3GTjfgYswXPIMlM84DOl06 w5UskjwCqK+XF3FgfzRxtC4Nu+LUoW9C0G1Mjzs8l7x22lhVv58FR1IKHmgMRvWF+pLR 1ZtV8hBSxgut6nLTclSix5a4jz6rAnPQW0g7qjzYlv1bXB4bdhDAwAQlFEsiDFRgPSPW f8ZsyXtDo1dSEgbO8zHoAiHfjlw8RwqG6wWChSVOGqgZ+Zqob731k2LH0atZx5Wci5YQ JzPQ== X-Gm-Message-State: ACgBeo1w29Zr9kAGSGfmEPvAsge8EivL+jBb0ie1pX+wBnUsidqHQj4K ENCi9Lo1+XEougohPDwE0/SIgdMC0IPEQ4fkLXQvAak4JZc= X-Google-Smtp-Source: AA6agR5DWp0EAgQQj7w6sIJDwtNHIjjY6nNtDtr+ZfSGB3R1BOIkNLA6cj7vSpQFHxn0977oBunWuC0c66AIUGOgcqc= X-Received: by 2002:aa7:8896:0:b0:53e:bc78:4f61 with SMTP id z22-20020aa78896000000b0053ebc784f61mr4834195pfe.19.1662643963805; Thu, 08 Sep 2022 06:32:43 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202209041052.284Aqvu2007702@gitrepo.freebsd.org> <05b97d9c-ff1d-0da2-ee22-0c054e853a77@FreeBSD.org> In-Reply-To: <05b97d9c-ff1d-0da2-ee22-0c054e853a77@FreeBSD.org> From: Ed Maste Date: Thu, 8 Sep 2022 09:32:32 -0400 Message-ID: Subject: Re: git: f0d4c2afd65f - main - pmc(3): Correct some typos in event descriptions To: John Baldwin Cc: Gordon Bergling , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4MNg6R2HLvz3Gx5 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-3.05 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.95)[-0.948]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; RWL_MAILSPIKE_GOOD(-0.10)[209.85.215.170:from]; RCVD_IN_DNSWL_NONE(0.00)[209.85.215.170:from]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; ARC_NA(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; DMARC_NA(0.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[carpeddiem]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On Wed, 7 Sept 2022 at 13:41, John Baldwin wrote: > > --- > > lib/libpmc/pmu-events/arch/x86/broadwell/pipeline.json | 4 ++-- > > lib/libpmc/pmu-events/arch/x86/broadwellde/pipeline.json | 4 ++-- > > lib/libpmc/pmu-events/arch/x86/broadwellx/pipeline.json | 4 ++-- > > lib/libpmc/pmu-events/arch/x86/cascadelakex/uncore-other.json | 2 +- > > lib/libpmc/pmu-events/arch/x86/silvermont/pipeline.json | 4 ++-- > > lib/libpmc/pmu-events/arch/x86/skylakex/uncore-other.json | 2 +- > > I think these files are actually 3rd party (and should really be under > contrib/ in that case?) so probably shouldn't be changed. Maybe you can > send the changes upstream to Linux instead? Yes, these come from Linux and the fixes should be sent there. The process is a bit cumbersome but at least well documented; I've done it for a couple of pmu-events files before, e.g. https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=28396b7df09b9565f404591c9945eac43526cb3f The process is documented in the Linux source tree at Documentation/process/submitting-patches.rst