From nobody Wed Sep 07 19:09:46 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MNBdp28zkz4bv1G; Wed, 7 Sep 2022 19:09:50 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MNBdn1hwQz3H2s; Wed, 7 Sep 2022 19:09:49 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 287J9kJ4010060 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 7 Sep 2022 12:09:47 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 287J9kBO010059; Wed, 7 Sep 2022 12:09:46 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Wed, 7 Sep 2022 12:09:46 -0700 From: Gleb Smirnoff To: "Bjoern A. Zeeb" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e72c522858cb - main - divert(4): make it compilable and working without INET Message-ID: References: <202208302249.27UMnSwI022109@gitrepo.freebsd.org> <6q6n8553-2143-n24p-4816-406549997s@mnoonqbm.arg> <15on1poo-pnpq-3pos-qs7s-673pp1q0s83@serrofq.bet> <6r5o5nqn-9srp-79qr-n33-q4992936q51q@serrofq.bet> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4MNBdn1hwQz3H2s X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=softfail (mx1.freebsd.org: 162.251.186.162 is neither permitted nor denied by domain of glebius@freebsd.org) smtp.mailfrom=glebius@freebsd.org X-Spamd-Result: default: False [-3.10 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]; ARC_NA(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; DMARC_NA(0.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[glebius]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; HAS_XAW(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, Sep 07, 2022 at 06:16:07PM +0000, Bjoern A. Zeeb wrote: B> > B> > On Sun, Sep 04, 2022 at 06:39:53AM +0000, Bjoern A. Zeeb wrote: B> > B> > B> > B> > Author: Gleb Smirnoff B> > B> > B> > B> > AuthorDate: 2022-08-30 22:09:21 +0000 B> > B> > B> > B> > Commit: Gleb Smirnoff B> > B> > B> > B> > CommitDate: 2022-08-30 22:09:21 +0000 B> > B> > B> > B> > B> > B> > B> > B> > divert(4): make it compilable and working without INET B> > B> > B> > B> > B> > B> > B> > B> > Differential revision: https://reviews.freebsd.org/D36383 B> > B> > B> > B> B> > B> > B> > B> Well, almost at least.... B> > B> > B> > B> > B> > B> > I wonder why LINT-NOINET builds without this?? B> > B> > B> B> > B> > B> I wondered the same last night.. I would be good to find out? B> > B> > B> > B> > Ok, I think that assumption that sysctl parts of divert require B> > B> > INET were just wrong, that's why LINT-NOINET builds. B> > B> B> > B> Not entirely. It's because sys/netinet/in_proto.c uncodonitionally B> > B> currently provides _net_inet for the sysctl. B> > B> The reason for that is that a lot of AF independent sysctls were initially B> > B> put under inet but are equally used for inet6 or neither in the network stack. B> > B> B> > B> You will need at least #if defined(INET6) || defined(INET) around the sysctls B> > B> in divert.c then. B> > B> B> > B> A LINT-NOIP kernel will complain about the missing symbol if we keep compiling B> > B> divert without INET or INET6 in the kernel: B> > B> > My goal was not to make divert(4) supported on NOIP kernel. The goal was to make B> > it supported on NOINET, an IPv6 only kernel. I don't see any value for divert(4) B> > on a kernel without either stack. B> B> then we should stop compiling it in that case. Do we compile it for NOIP? -- Gleb Smirnoff