From nobody Mon Sep 05 15:57:07 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MLtSM2DZcz1HF0s; Mon, 5 Sep 2022 15:57:07 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MLtSM1hmpz428L; Mon, 5 Sep 2022 15:57:07 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662393427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZWNgboFEfg8Jq9T+erDkZktAc8EUv57e9ObW7Hknhrw=; b=c3doS2AWE0Di00Ctk9vSsJ+or93IUnrJbGP22JWDm2nrDd8Rt5VoJRC8EY8MJZAqINLzD1 SANOWpvOwgc3HCCTD6QU2fNP17CO9/lDERwv2k0E503ZH5LkOPgKtc6rwTL0d5LsCOQjK8 NsmqqnLJLzcTUpbyOKsj+QYAz84cqztQaGT4MvPUwpg8n21tAkadqBJ7V/6WF4crWg4tXJ UAgR96nV+tsowIGDcnDzAVLThYKxo4onbTmxUoGupJdLfRdLABt8M+9c6O6L4JJL/tJ4Gt 4IWSd8cUXIwb/5v09k0tQnJa38hbQkNxp7bAHAS09nfI3HV8Irs24muJPURwvA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 210654352; Mon, 5 Sep 2022 15:57:07 +0000 (UTC) Date: Mon, 5 Sep 2022 15:57:07 +0000 From: Alexey Dokuchaev To: Gordon Bergling Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 94466c432ed6 - main - Revert "usb: Remove a double words in a source code comments" Message-ID: References: <202209051346.285Dk4BC013542@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202209051346.285Dk4BC013542@gitrepo.freebsd.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662393427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZWNgboFEfg8Jq9T+erDkZktAc8EUv57e9ObW7Hknhrw=; b=noiDZB1X2iWi8xHMHIB+Hk+mU6EolOor/b8w6g9IxoORb3FqfVlMz/7iqzuEDvuXCLIB26 ycM3uTKuLCq1+B5qDjbriLZkWD9n1f2JNoG2/ODfhOsc5jm5HCDWsLbot13yxRQoFO2RlZ xbFFXfFQU9rzllzU50oSs/ZBkSo5a7t9ocmQh+9z8bHNxcQQSk3bjp4AYb4Vz78yHHMNAo eaE8vJf+DkO+IBA/EwVaLT0ndmqGLqRyKcY6CQIlE87u0ja38nHhIh74HMEENWbh79LDMV kSyNwAR/KeoKts/5gbUX+tC3hCSBxHJm208TnsMxtrhWDMZsb3BcRQKuCi/p6A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662393427; a=rsa-sha256; cv=none; b=VEsoRyk5BsNy2hfqmhjQ/OcJcaScon4BhdjyTSbbo7F4UA0goAjnecXuRMj+Gkpw0MmFHO NEVK0DP6jLSmEbJJmc8mVSWnkWhnp1xqYJk6RSdW3ms6tjDKM5Fqn3yij7UaTwpl8mSbKs i9BgoA+/cPIDGF/hps4BwwdlJ8a/iaSr6P9TPQL6jZ/ONz3k2qyDQIsGmuYXQ9cEyJQVGx hlWfKlhkqUMdyh9iHa6MyxGlHI6AIw2IEg2GequaPeCsceYiOu0eublHnUw1Cg290Mcrkd rTAWpYsPxZVKOFhd8OsQcEJEaFKjxCjd3uR6X6fcXXgN3pMuar2eNzXAKXPgKA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Mon, Sep 05, 2022 at 01:46:04PM +0000, Gordon Bergling wrote: > commit 94466c432ed611a49cacae7ff99b224b37c906bb > > Revert "usb: Remove a double words in a source code comments" > > This reverts commit 8ca67bf1273a5168f8a3787183159c477632e582. > > The original comment was correct; changing it loses a key part. > > Reported by: jrtc27 jrtc27@ had pointed out two places, but you've reverted all three. > - * different from the muge_init() function in that one is designed to > + * different from the muge_init() function in that that one is designed to Admittedly, I'd rather see the whole comment rephrased: these double thats make it hard to read and just begging for someone, perhaps even you, "fix" it again in the future. :) > - * We assume that the alignment at this point of > + * We assume that that the alignment at this point of This one had not been complained about, I think. ./danfe