From nobody Mon Sep 05 13:44:01 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MLqVr2CPDz4cRT2; Mon, 5 Sep 2022 13:44:04 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MLqVr1gBRz3lRB; Mon, 5 Sep 2022 13:44:04 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662385444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3ZgUxp3zV2m6Rrt6G/mUVFi+D0LI5dI5msn35/JcMOM=; b=XDiNbugT5Oa8DcLL+xVSf0bftWtK8WdI5EFf2NZ0GoCv4pAwrU7VLAVmU1vSan52EOm5wJ hx45f/yip5LJEgEHGfGQf/Q649imdUmcs9gYUj4NOtql8KekfO4QMWQsDCawNexhYf8Y8S UjYjf+c2CGMuNHm6j7sgJ8nqfEpJA8+Rfmcj6yhdoHMf97nQlAGHduJFFEljATVjHOmHvP 5WkVGe0/o4ILF857kWPQw1ujhtzVcl0gHhDuFyR+5lTIScGpCNd122Tzxi5/NcptIrxRqy 8SSAxowuqr7rLAwZnuCF2xvEuhUgCXXji4BuvjOkOi0Ozatfgq1362jxqTBgRw== Received: from localhost (p5b29d0b7.dip0.t-ipconnect.de [91.41.208.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MLqVq43glztlr; Mon, 5 Sep 2022 13:44:03 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Mon, 5 Sep 2022 15:44:01 +0200 From: Gordon Bergling To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 7d91d6b83e74 - main - stand: Grammar fix for a source code comment Message-ID: References: <202209041526.284FQxxW046404@gitrepo.freebsd.org> <49C52799-1277-499A-AD14-B4B3C1427097@freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <49C52799-1277-499A-AD14-B4B3C1427097@freebsd.org> X-Url: X-Operating-System: FreeBSD 13.1-STABLE amd64 X-Host-Uptime: 3:42PM up 6 days, 2:06, 2 users, load averages: 0.18, 0.18, 0.14 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662385444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3ZgUxp3zV2m6Rrt6G/mUVFi+D0LI5dI5msn35/JcMOM=; b=iJgFBD7l1Fs99ZzNIPusU2pz5rwBEJRgcU3twZzwIHVQ+LyR2cWYRUgrmvlDHZ8ZYVwoW5 odmaRAOkxClUCWS2jCIAgTEnSLd2kY5y9SnRJeyRPaAL5OyJ4upGANq3G9yXswkAhFgBY8 ZTrZ/0ElL1EB81OHMCtvzkfwfILhhqAX18CwHW1j7ZK2uDuqH57gR8Nj9+PdVz9gNZ1zf3 zQ1/zioSD65xS5qJ0zvPptJB1YhNQR7adCtXIzcL6U1dNs5SCYIAl6GzRl+2qHibWajU9l m3Kui7UNZG64QHZPUETSvm3+K/7HHaGTBPbIG3s5PW+QBi+g7Z4j5d6N5JA6oA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662385444; a=rsa-sha256; cv=none; b=uYiNNg8FMWhjBrxINlEnxBAycxn5a1frh90fGRWDyaQEpiWGajmB9MhbcOaey2ypA0g4K8 gNfauy3uOyQwlXjWeRn8FAMOF3ccQlidH4GgWYMlksRqyXjV4ezqeY1CcjRiQEpE7xNT93 sIug95uI+D5CaOAYtH23CVmByzAEsernRQTQw8vlDoQLPi3t8dHO7MqRq82CzcJEPNsvTH 0ZeEuwQBvEvaRlbd5MVFA8pgswZfdqnPryZMnEmfk0ig/p7UwVRoYqberVaFwUHvaAmkep o6a09AqL9F5OrAvKve68b1wBJTBbHHjxVEYgnQ3CzV5gfEMPV81VF52ED4oZkg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Sun, Sep 04, 2022 at 10:38:16PM +0100, Jessica Clarke wrote: > On 4 Sept 2022, at 16:26, Gordon Bergling wrote: > > > > The branch main has been updated by gbe (doc committer): > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=7d91d6b83e74edf278dde375e6049aca833cbebd > > > > commit 7d91d6b83e74edf278dde375e6049aca833cbebd > > Author: Gordon Bergling > > AuthorDate: 2022-09-04 15:26:48 +0000 > > Commit: Gordon Bergling > > CommitDate: 2022-09-04 15:26:48 +0000 > > > > stand: Grammar fix for a source code comment > > > > - s/that that/that this/ > > > > MFC after: 3 days > > --- > > stand/ficl/ficl.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/stand/ficl/ficl.h b/stand/ficl/ficl.h > > index 97cf00b0dff3..45403824ad8f 100644 > > --- a/stand/ficl/ficl.h > > +++ b/stand/ficl/ficl.h > > @@ -149,7 +149,7 @@ > > ** inner loop. I'll look at it for ficl 3.0 > > ** - Make the main hash table a bigger prime (HASHSIZE) > > ** - FORGET about twiddling the hash function - my experience is > > -** that that is a waste of time. > > +** that this is a waste of time. > > I wouldn’t say either one is incorrect; if anything I’d say the > existing comment is more natural (and likely what I would say). > > Jess Thanks for the feedback, reverted in 3c6db09bf45fd48e5e3c207f138ae1914dbeed0c. --Gordon