Re: git: e72c522858cb - main - divert(4): make it compilable and working without INET

On Sat, 3 Sep 2022, Gleb Smirnoff wrote:

> On Sat, Sep 03, 2022 at 10:44:26PM +0000, Bjoern A. Zeeb wrote:
> B> On Tue, 30 Aug 2022, Gleb Smirnoff wrote:
> B>
> B> > The branch main has been updated by glebius:
> B> >
> B> > URL: https://cgit.FreeBSD.org/src/commit/?id=e72c522858cb3fe179b8ec5700cdbf46c45e917e
> B> >
> B> > commit e72c522858cb3fe179b8ec5700cdbf46c45e917e
> B> > Author:     Gleb Smirnoff <glebius@FreeBSD.org>
> B> > AuthorDate: 2022-08-30 22:09:21 +0000
> B> > Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
> B> > CommitDate: 2022-08-30 22:09:21 +0000
> B> >
> B> >    divert(4): make it compilable and working without INET
> B> >
> B> >    Differential revision:  https://reviews.freebsd.org/D36383
> B>
> B> Well, almost at least....
>
> I wonder why LINT-NOINET builds without this??

I wondered the same last night.. I would be good to find out?


> B> - sysctls require INET
>
> The sysctls, I believe, need to be moved out of the inet namespace.
>
> B> - ip_divert_ptr still requires INET or INET6 (raw_ip.c)
>
> This dependency is fine as it is. Packet filters also require either. Also,
> I don't expect that through my lifetime we would ever need a kernel with
> network stack features, but without both INET and INET6.

There are people who build kernels w/o networking (hence LINT-NOIP)
which is what found this one.


> B> - one of the SCTP blocks has a early-ended #ifdef INET which can just be
> B>    fixed easily compared to the two above.
>
> Thanks!
>
> I'll post a review soon.

Cool.  Thank you!

Blessed Sunday.
/bz

-- 
Bjoern A. Zeeb                                                     r15:7