From nobody Fri Oct 28 20:23:48 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MzYsf4zrBz4h1Gn; Fri, 28 Oct 2022 20:23:50 +0000 (UTC) (envelope-from mhorne@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MzYsf4TZ6z4Msl; Fri, 28 Oct 2022 20:23:50 +0000 (UTC) (envelope-from mhorne@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666988630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=78i1CCC2jK/jvYNeUy3wYj/Ix+/w+iUCwrJp+eW4BiM=; b=NzI3RIb9zTLcZWWQcz0OguTjNVcfV1xjTF5YPfOTo7YuS1imA4xXx4ImaLuUvzKWuP6w4b Yz8NpqXd2KAx1YJpfmvz/4ac4I3Bne1gcz2qgabLIHgsEbNtrDglnhX3Vbm61XpJ970q6R gfYs+JpX34iWHBb05Zk1NNZWHo6aDR5ckaxNxvGhD+yH18As44QRZxS3D120dMRq/wr5Xd UP0DO7QkHovvtBOA8nmV7Lt6N7L7Ysy0qlcOH55uUPgyohYHdtXvDn8Z6qKWa77B8rrp/+ 7JRjtpC0AtmsqCM596+SshdCW+fKPsQTGdrmwhrwL8/h0iZuRF+Aiz0BMgrGaQ== Received: from [192.168.1.151] (host-173-212-76-127.public.eastlink.ca [173.212.76.127]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mhorne) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MzYsf0zPSz1LSc; Fri, 28 Oct 2022 20:23:50 +0000 (UTC) (envelope-from mhorne@freebsd.org) Message-ID: Date: Fri, 28 Oct 2022 17:23:48 -0300 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: git: 701ab6dba4a2 - main - Stop building FDT-only modules in an ACPI only kernel Content-Language: en-CA To: John Baldwin , Andrew Turner , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202210271759.29RHxoXe019330@gitrepo.freebsd.org> From: Mitchell Horne In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666988630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=78i1CCC2jK/jvYNeUy3wYj/Ix+/w+iUCwrJp+eW4BiM=; b=NurCLHEtzB+u3gaLIwSDKLUd/fblDTpKu9ZJ5sqS8bgdO+UjE9ZhbU92G8lDaaVugiV8L0 yVJSgshKj0DE25rR1ZPD4pawUgMJ8TnKpIIthxb22ggMerDzj4cj2H/7nxeIV87R8zeRl6 57AR2E7d4OKiBaRJW9weaXypPr+uKyGbDTLxxZl3r68smI2Ktsug+NGNDuoa1cvKe/Oh+v KcCrFeX2KHtVrf3nMUt0rEXGNue++s1kXNakvHDz18YeazvdB5vpvVJaCN9/2BC3U98Ceh c8uO1cyfNMbhzt58gxnZ6fJUi/yD+Yf0/uFAwXTNr2JjO7G8rR1+MZuZ/4Sh9Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1666988630; a=rsa-sha256; cv=none; b=Zlrl6BG4+LtaxSg5diKna24ERiiap+fqrlT2OAQSBWIeAd6UitSaj011fGcM0b8YtUp5VU Ncrwwu4qKG8EUEKNijPuuvYuq291rbgtn2FNjBEQ6nnxRIBHRJoe534kaTwAHjGV/s7L0u WgrZUY9b1Yu1Nr84v8B9WnKdwmn4dEXbTmWJcCEbMiGf3qO66KJifl0zBpoi64+kEklCo1 OwXFPO+nyV6dh3peifHh6iPuMn88VukPA2JFLx7k1/YbWnb/qWQszcqOdbO39H1SIl0VM5 SQTxYIX563dPP1C2Z27FvW1ToG0wep76jg6oU6kwGEeNnHUdUhSLUmP3chh9yA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 10/28/22 12:59, John Baldwin wrote: > On 10/27/22 10:59 AM, Andrew Turner wrote: >> The branch main has been updated by andrew: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=701ab6dba4a2232751cd91f79bfc1d8e96bf5316 >> >> commit 701ab6dba4a2232751cd91f79bfc1d8e96bf5316 >> Author:     Andrew Turner >> AuthorDate: 2022-10-27 17:01:44 +0000 >> Commit:     Andrew Turner >> CommitDate: 2022-10-27 17:59:33 +0000 >> >>      Stop building FDT-only modules in an ACPI only kernel >>      When building a kernel without FDT these modules don't build. As >> they >>      depend on FDT and don't work with ACPI disable them. >>      Reviewed by:    imp, kevans >>      Sponsored by:   The FreeBSD Foundation >>      Differential Revision: https://reviews.freebsd.org/D37178 > > Hmm, the OPT_FDT handling seems a bit atypical.  Other optional > components are > tested for by ${KERN_OPTS:M} rather than empty(OPT_) under > sys/modules. > Some time ago I experimented with trying to build a NOFDT kernel like this. I found that this type of construct worked well: SUBDIR.${MK_FDT}= ${_allwinner} \ ${_if_cgem} \ ${_sdhci_fdt} \ ... That is, use the existing SUBDIR.yes logic to conditionally exclude these already conditional subdirectories. It avoids multiple identical checks, whether you use ${KERN_OPTS:MFDT} or empty(OPT_FDT) forms. Something to consider. Mitchell