Re: git: 9cabef3d146e - main - ldd: use direct exec mode unconditionally

Kristof Provost <kp_at_FreeBSD.org> wrote on
Date: Fri, 21 Oct 2022 12:18:04 UTC :

> On 6 Oct 2022, at 17:50, Konstantin Belousov wrote:
> > The branch main has been updated by kib:
> >
> > URL: 
> > https://cgit.FreeBSD.org/src/commit/?id=9cabef3d146e9a844813b6bc8952d6cf2e9d45e5
> >
> > commit 9cabef3d146e9a844813b6bc8952d6cf2e9d45e5
> > Author:     Konstantin Belousov <kib@FreeBSD.org>
> > AuthorDate: 2022-09-21 13:55:44 +0000
> > Commit:     Konstantin Belousov <kib@FreeBSD.org>
> > CommitDate: 2022-10-06 15:50:26 +0000
> >
> >     ldd: use direct exec mode unconditionally
> >
> >     Trying to exec malformed or unusual binary, for instance, a 
> > non-FreeBSD
> >     ABI, or using a non-standard interpreter, might give unexpected 
> > outcome.
> >
> >     Reported by:    The UK's National Cyber Security Centre (NCSC)
> >     Reviewed by:    emaste, markj, philip
> >     Discussed with: jhb
> >     Sponsored by:   The FreeBSD Foundation
> >     admbug: 991
> >     PR:     127276, 175339, 231926
> >     MFC after:      1 week
> >     Differential revision:  https://reviews.freebsd.org/D36650
> >
> This appears to break things for armv7 (running on aarch64).
> 
> This manifests while building pfsense (for 3100 / armv7), which we do on 
> an aarch64 vm (to avoid having to deal with qemu, and because it’s 
> faster).

My context is a Cortex-A72 system (a HoneyComb), just
via use of poudriere-devel armv7 jails (no qemu use):

# poudriere jail -jmain-CA7 -i
Jail name:         main-CA7
Jail version:      14.0-CURRENT
Jail arch:         arm.armv7
Jail method:       null
Jail mount:        /usr/obj/DESTDIRs/main-CA7-poud
Jail fs:           
Jail updated:      2021-06-27 17:58:33
Jail pkgbase:      disabled

where /usr/obj/DESTDIRs/main-CA7-poud has an installed armv7
world, following poudriere's requirements for such.

> During that build a couple ports fail to build, including 
> databases/sqlite3.
> It fails running `/usr/bin/ldd -a 
> "/wrkdirs/usr/ports/databases/sqlite3/work-default/stage/usr/local/bin/sqlite3" 
> "/wrkdirs/usr/ports/databases/sqlite3/work-default/stage/usr/local/lib/libsqlite3.so”`, 
> which produces:
> 
> 	ld-elf.so.1: 
> /wrkdirs/usr/ports/databases/sqlite3/work-default/stage/usr/local/bin/sqlite3: 
> mmap of entire address space failed: Cannot allocate memory
> 	/wrkdirs/usr/ports/databases/sqlite3/work-default/stage/usr/local/bin/sqlite3: 
> exit status 1

Same here. So far, my ports update also got such for attempting
to build devel/gobject-introspection :

ld-elf.so.1: /wrkdirs/usr/ports/devel/gobject-introspection/work/gobject-introspection-1.74.0/_build/tmp-introspectjq90y07h/GLib-2.0: mmap of entire address space failed: Cannot allocate memory
/wrkdirs/usr/ports/devel/gobject-introspection/work/gobject-introspection-1.74.0/_build/tmp-introspectjq90y07h/GLib-2.0: exit status 1
. . .
subprocess.CalledProcessError: Command '['ldd', '/wrkdirs/usr/ports/devel/gobject-introspection/work/gobject-introspection-1.74.0/_build/tmp-introspectjq90y07h/GLib-2.0']' returned non-zero exit status 1.

> That fails doing the `mapbase = mmap(base_addr, mapsize, PROT_NONE, 
> base_flags, -1, 0);` call in rtld-elf’s map_object():217. That call 
> does `mmap(0x10000, 0x1dc000, PROT_NONE, 0x6010, -1, 0) => 0xffffffff`.
> 
> With this patch reverted we can build successfully.

For reference (long output line split for readability):

# uname -apKU
FreeBSD CA72_16Gp_ZFS 14.0-CURRENT FreeBSD 14.0-CURRENT #63
main-n258610-ba7319e9091b-dirty: Fri Oct 14 14:29:14 PDT 2022
root@CA72_16Gp_ZFS:/usr/obj/BUILDs/main-CA72-nodbg-clang/usr/main-src/arm64.aarch64/sys/GENERIC-NODBG-CA72
arm64 aarch64 1400072 1400072

/usr/obj/DESTDIRs/main-CA7-poud has the same FreeBSD vintage,
but for armv7. (poudriere is still running.)

===
Mark Millard
marklmi at yahoo.com