From nobody Fri Oct 07 20:43:19 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MkgHs3N7cz4dr4X; Fri, 7 Oct 2022 20:43:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MkgHs2wwmz3ZVV; Fri, 7 Oct 2022 20:43:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665175401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dm+C2DanfJ285gN24JsfzCJohkPgpiWm+EfTBmStbY4=; b=xesDCfsXoTeoRY5AJR+Zu37mki1gDhft+V9G+sDKy7FzMTecW77VnsrJ5Qocg4eSkYb8L2 utksSAbJHAOkVkrW9O5AkLbkatTvrnsRwxmxfv/4BeG5f9hSzZ9qsB6hq0QFg0ChOEsq+q hgThvwFa/2hL5PVDDHJRdxbNJ31n9H5QNhKDqsy/n7trXMHKhVqx7tZsAXxyI/LK8Erw9j 3d9SeKUlgnry58AD7QnOgZkTGOOfeu6L0TFb9fnrNSyIQ9EALcLR4GLaXvZ95A8yScUNu8 nFyjTW48A1iZPrl6K7q+QYilOrBHKIDHAnJvDhSllkcXfHzlxgdr5VPgHjdMfQ== Received: from [IPV6:2601:648:8684:ad0:94d8:ad3b:a95b:e90a] (unknown [IPv6:2601:648:8684:ad0:94d8:ad3b:a95b:e90a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MkgHr6S6pzfhc; Fri, 7 Oct 2022 20:43:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <28566608-eb68-7948-77b5-5e49739d8ec5@FreeBSD.org> Date: Fri, 7 Oct 2022 13:43:19 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: git: ce9e720af2f8 - main - : Add a fallback for __LONG_WIDTH__ for older compilers. Content-Language: en-US From: John Baldwin To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202210072032.297KWiuG035424@gitrepo.freebsd.org> In-Reply-To: <202210072032.297KWiuG035424@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665175401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dm+C2DanfJ285gN24JsfzCJohkPgpiWm+EfTBmStbY4=; b=Wb2vHuEuxuGIbM1snTvf71udShVp55XlCmcz3bCq88sYQmPoh9Yw+yVCKBSfM9godrakcC O3+CRpOqb5vnalX00tIbIu6MX3GlSoTg+86FxxX35c4NjybPYYsJvFcNr81yFX4llsPRvZ ggyKYPvTCZ0ZGSF/FDVNWUDrZ3Wie2/8c2u8yvpcPXNjU76a58U1p6+GBsSrGNXeTh6Vpm NpJbKw7Xh7mwoDbOKJ0/HIYbhMP+HkAyZHr240FH1pGvWw/WIep18I/jZY+H+l0MB2PcFv W07Y3MmHddmkcbRUKMVA/96ZD7O+Otkt536Dqramn5iXviVS3n/MyN7ViTG/EA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665175401; a=rsa-sha256; cv=none; b=pY1cVLZGXLTetvchbRr1ZxIrNw3COBC4Ze8QJc93S9/5h+9athFrKY1dYSByYkGGHOmc0k k6nbk2lInpMEfRxCSyFi04MeTmfVwQO+Jb2kZomokE36dP1q6Pt0yHAhZsx0Pw5ubY2uQP 4ypVxuRUvtl6viG4QSQrXLNqhwVSlpC5ZiEFX0hGDhFoQvM8BQv7fLwUKc6AIMMdHH0wNs rivTXQNUt1q2YzhWd0SUWFT5VW3up7d8Dx7+ZqFSK6Wqi0VSIKKtpI1lq6s/oihut5kGVs JOwCK3FHm6SYw1ao+yCD+7KxB7tkuZrvlUt98VeO1+73aMld9kcoUq5+TqzRyA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 10/7/22 1:32 PM, John Baldwin wrote: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ce9e720af2f8fa378e36134bab8a82ebf67c159d > > commit ce9e720af2f8fa378e36134bab8a82ebf67c159d > Author: John Baldwin > AuthorDate: 2022-10-07 19:44:31 +0000 > Commit: John Baldwin > CommitDate: 2022-10-07 19:44:31 +0000 > > : Add a fallback for __LONG_WIDTH__ for older compilers. > > clang only includes a __LONG_WIDTH__ builtin in clang 14 and later. > --- > sys/sys/_pv_entry.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/sys/sys/_pv_entry.h b/sys/sys/_pv_entry.h > index 411643cf49ec..3cd0d9c687f6 100644 > --- a/sys/sys/_pv_entry.h > +++ b/sys/sys/_pv_entry.h > @@ -77,6 +77,11 @@ typedef struct pv_entry { > #error Unsupported page size > #endif > > +/* Support clang < 14 */ > +#ifndef __LONG_WIDTH__ > +#define __LONG_WIDTH__ (__CHAR_BIT__ * __SIZEOF_LONG__) > +#endif > + This was the smallest change to fix CI breakage. However, we may want to do this differently. We could perhaps add this fallback for __LONG_WIDTH__ to , or we could change sys/_pv_entry.h to use the expanded form always (or pick a different spelling?) -- John Baldwin