From nobody Thu Oct 06 20:38:34 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mk3Dt0bQ7z4V1qX for ; Thu, 6 Oct 2022 20:38:38 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mk3Ds11p1z3p1j for ; Thu, 6 Oct 2022 20:38:37 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f48.google.com with SMTP id ay36so1774529wmb.0 for ; Thu, 06 Oct 2022 13:38:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Buy43858S9+TSYmq0tLFd77bwxKMfOQLxauK5YOfN3U=; b=HdZE14IBHi07W0/L67WfdAj4ZupD2rNyQAwNlk7PzpKNMJcBPX3dHiDzUE8Zwtw2Uj fzdqVHOaP8jePb3nCplQ6gnp6SlGeQNEunuRDmhDr07DrgBQfYWREZj8zX2TeQOMZxFy KBqxzP+SHUEsn/cQTqlSMu8g/GqQuWIRTkY1XyV4GQjJBx0QfrecbvCZhSCxIvpVmXx8 KWirUny1XgaEI9oHN+EhS8BskODoccSI5bs7+q3LLlPmXvbfx9cQ/4HMAlNaduOoLn7q XFsmcZIBWNiKt/eV6S6LY5kktFDj11zI9HjO1bS27G3hE7dYr8KLPnDbnppRcy7TN+Fv 5u2A== X-Gm-Message-State: ACrzQf1WVoNGIItyh+MRKQRsgSlQSknOGpxuCuFHIIGAjw9A2vpbyixY LwZBH9pJGnvzunTw3eg2o34r3bI0gSrNrbinTkg= X-Google-Smtp-Source: AMsMyM7+zqjqZGT4FjpcJkIXIhJ0OrqsgFl1Gzf3bOiYxehOjCozHe8KnUv1RYTqcCkSeBWX1zwanQ== X-Received: by 2002:a05:600c:154e:b0:3b4:bf17:32fc with SMTP id f14-20020a05600c154e00b003b4bf1732fcmr8331911wmg.70.1665088715702; Thu, 06 Oct 2022 13:38:35 -0700 (PDT) Received: from smtpclient.apple (global-5-142.n-2.net.cam.ac.uk. [131.111.5.142]) by smtp.gmail.com with ESMTPSA id bi10-20020a05600c3d8a00b003b47ff307e1sm326565wmb.31.2022.10.06.13.38.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Oct 2022 13:38:35 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: git: 8cfbeb56aa16 - main - bsdinstall services: Improve mouse configuration From: Jessica Clarke In-Reply-To: <202205211442.24LEgsv9085401@gitrepo.freebsd.org> Date: Thu, 6 Oct 2022 21:38:34 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <99742C19-34A6-461F-BEA7-6B9206DF42C9@freebsd.org> References: <202205211442.24LEgsv9085401@gitrepo.freebsd.org> To: "Alfonso S. Siciliano" X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Rspamd-Queue-Id: 4Mk3Ds11p1z3p1j X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-2.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; TO_DN_EQ_ADDR_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.48:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.48:from] X-ThisMailContainsUnwantedMimeParts: N On 21 May 2022, at 15:42, Alfonso S. Siciliano = wrote: >=20 > The branch main has been updated by asiciliano: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D8cfbeb56aa160de1ea4f492abeb3aa02= 9e84269f >=20 > commit 8cfbeb56aa160de1ea4f492abeb3aa029e84269f > Author: Alfonso S. Siciliano > AuthorDate: 2022-05-21 14:37:53 +0000 > Commit: Alfonso S. Siciliano > CommitDate: 2022-05-21 14:42:23 +0000 >=20 > bsdinstall services: Improve mouse configuration >=20 > bsdinstall(8) has an option to enable moused support. > However, if it is not selected, moused is still started > through the configuration of nondefault devices. > So, automatically add the moused_nondefault_enable=3D"NO" > setting to rc.conf unless moused support is selected. >=20 > PR: 227999 > Reported by: bcran > Reviewed by: bapt > Differential Revision: https://reviews.freebsd.org/D35193 I question the wisdom of this change. The text specifically says =E2=80=9C= PS/2 mouse pointer=E2=80=9D, because moused_enable controls only the default = mouse, which rc.conf sets to /dev/psm0. Turning this option on or off would therefore affect specifically the PS/2 mouse, precisely as described in the dialog menu entry. USB mice would always remain enabled. However, now, leaving the explicitly-PS/2 mouse option disabled *also* disables non-default, i.e. USB, mice. Moreover, if you go and enable the option so USB mice work, PS/2 mice are always enabled, but you may not have a /dev/psm0. You may even be on an architecture where PS/2 does not exist; atkbdc, and thus psm, only exists for x86. This means that, in those cases, enabling the option gives an error during boot because /dev/psm0 doesn=E2=80=99t exist. I can understand that some people want to turn off console mouse support completely; however, with the current way moused works, that cannot just be a single option that governs both moused_enable and moused_nondefault_enable. Jess > --- > usr.sbin/bsdinstall/scripts/services | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/usr.sbin/bsdinstall/scripts/services = b/usr.sbin/bsdinstall/scripts/services > index f9141a523a31..1ac69fa63b2d 100755 > --- a/usr.sbin/bsdinstall/scripts/services > +++ b/usr.sbin/bsdinstall/scripts/services > @@ -61,11 +61,17 @@ if [ $retval -ne $BSDDIALOG_OK ]; then > fi >=20 > havedump=3D > +havemouse=3D > for daemon in $DAEMONS; do > [ "$daemon" =3D "dumpdev" ] && havedump=3D1 continue > + [ "$daemon" =3D "moused" ] && havemouse=3D1 > echo ${daemon}_enable=3D\"YES\" >> = $BSDINSTALL_TMPETC/rc.conf.services > done >=20 > +if [ ! "$havemouse" ]; then > + echo moused_nondefault_enable=3D\"NO\" >> = $BSDINSTALL_TMPETC/rc.conf.services > +fi > + > echo '# Set dumpdev to "AUTO" to enable crash dumps, "NO"' \ > 'to disable' >> $BSDINSTALL_TMPETC/rc.conf.services > if [ "$havedump" ]; then