From nobody Thu Oct 06 17:13:14 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mjygt2fj9z4f2L8; Thu, 6 Oct 2022 17:13:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mjygt2BrWz3Z2q; Thu, 6 Oct 2022 17:13:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665076394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V0NU9xIZN3jNoYWVUtwj6w5PNx1xbM7x4IwDpeHRT40=; b=WGmqbKhJ6TyjgZoCo1j6V++HN+VuMQFJIhWiySP0LdkrF8BB+HJPzpmW6VU9ZSeRtsIy3/ afgp/yEOiiRAoqSQHekD1lGALg4Jsot96YDnpCQzccUpVTElCfnCw0ylhJmYY24zW9ihta hL/gYKQGPvdNqiOX/aoWpIYSjQqMv08j0mawxrudZbv6SmTtnqpbruBcWTYUttdv6rgbjA Jyd1CLSGeT/J1Vj3Jt2bvIPP25J8cOXM49Y4o/vuIIXF5iZGEcR5xPFHG0DrZf6Gwci0aS AdyEnNOQVNyhtvpB8/ZDx0ohMhZmtkN47DDAun/FivXm+sw7WGGDr7JLxUIo7A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Mjygt1G1wzKBm; Thu, 6 Oct 2022 17:13:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 296HDEIc093838; Thu, 6 Oct 2022 17:13:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 296HDEi1093837; Thu, 6 Oct 2022 17:13:14 GMT (envelope-from git) Date: Thu, 6 Oct 2022 17:13:14 GMT Message-Id: <202210061713.296HDEi1093837@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 661faa1f77c0 - main - cxgbe/cxgbei: Do not validate the hardware iSCSI tag mask. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 661faa1f77c0fa9d28d60d71087820aaaaee8b1b Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665076394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=V0NU9xIZN3jNoYWVUtwj6w5PNx1xbM7x4IwDpeHRT40=; b=qACKGRTOQNCwDjoJwuo6ah/Wj58LJfwct99msr9NbjdkcXq6ZKIkO0cnEoN7ZqaJaoO4/B wmoAGM1P1PgQq3Oe7rE+c6/KftUoj/DDWVUIBzxxTkQcYdkaUzYDllw/P8iUuc8rcLEp2b qxyd8UA8FcIu4UAOHY/9LapqFbY4JxS7UauO+VZq20JbPB2znH4lnB5hIvW3gidMgP7CE/ Dx161zl6itwHzrFU4C5rM5BBb/y5CcIBIjkcVcgsLZBgzMNlXAIYnnAreayNGKXIBbniNM V0AVG+du8L3L/N0EgtWmSZNhxb9D5z9eQvNi26AnK28B+6H7kdoQpCqXYYy9Xg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665076394; a=rsa-sha256; cv=none; b=WVwgGP9kHr1lyQzVw2SvVQxzVRWMEvPfSVJ194jOiwWXx6VFA2d9OPxgqL2mLJz5Y6FepV 6mapff1pHmk6yfKFibBFk8jo+uONUpFG8iev57n+lZNQflouG8IFDntUPJRwUzWTlqZKn4 TNfb5/Fs1MkucWFsG7nAyyyXLgM/B/oDATcuyZAMf6y2dPJxIFcNwSENjY2qbqS5Opdrig jSfa/IZp/zl4329TpXzGulDZUqCJEZymPkFtzUQnQoITS3oO/wQZ/5f+2/8GaYPiCtfTp0 IBii4kHB/pYVlq63r4dTAgevEeMcYh1NegTwyn7ke7Vn90GRvD9k0cCAPvj0WQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=661faa1f77c0fa9d28d60d71087820aaaaee8b1b commit 661faa1f77c0fa9d28d60d71087820aaaaee8b1b Author: Navdeep Parhar AuthorDate: 2022-10-05 18:05:12 +0000 Commit: Navdeep Parhar CommitDate: 2022-10-06 17:12:00 +0000 cxgbe/cxgbei: Do not validate the hardware iSCSI tag mask. This was added in 7cba15b16eb2 in 2016 and firmwares at that time were already setting up the iSCSI tag mask properly. Since then it has also become possible to split the iSCSI region between multiple PCIE PFs but the driver's calculation takes only its own PF's allocation into account and that means this code is incorrect and not just a harmless no-op. MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/cxgbei/cxgbei.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/sys/dev/cxgbe/cxgbei/cxgbei.c b/sys/dev/cxgbe/cxgbei/cxgbei.c index ad66247775e1..b6dc5d5c3577 100644 --- a/sys/dev/cxgbe/cxgbei/cxgbei.c +++ b/sys/dev/cxgbe/cxgbei/cxgbei.c @@ -167,21 +167,6 @@ cxgbei_init(struct adapter *sc, struct cxgbei_data *ci) return (rc); } - r = t4_read_reg(sc, A_ULP_RX_ISCSI_TAGMASK); - r &= V_ISCSITAGMASK(M_ISCSITAGMASK); - if (r != pr->pr_tag_mask) { - /* - * Recent firmwares are supposed to set up the iSCSI tagmask - * but we'll do it ourselves it the computed value doesn't match - * what's in the register. - */ - device_printf(sc->dev, - "tagmask 0x%08x does not match computed mask 0x%08x.\n", r, - pr->pr_tag_mask); - t4_set_reg_field(sc, A_ULP_RX_ISCSI_TAGMASK, - V_ISCSITAGMASK(M_ISCSITAGMASK), pr->pr_tag_mask); - } - read_pdu_limits(sc, &ci->max_tx_data_len, &ci->max_rx_data_len, pr); sysctl_ctx_init(&ci->ctx);