RE: git: b7104f19147f - main - sendmail: document that sendmail_enable can be set to NONE
Date: Tue, 08 Nov 2022 17:11:13 UTC
Baptiste Daroussin <bapt_at_freebsd.org> wrote on Date: Tue, 08 Nov 2022 13:41:29 UTC : > On Tue, Nov 08, 2022 at 08:07:46AM -0500, Matteo Riondato wrote: > > On 2022-11-07 at 06:50 EST, Baptiste Daroussin <bapt@FreeBSD.org> wrote: > > > diff --git a/libexec/rc/rc.conf b/libexec/rc/rc.conf > > > index a71a3fa4063d..91b99780eae6 100644 > > > --- a/libexec/rc/rc.conf > > > +++ b/libexec/rc/rc.conf > > > @@ -596,7 +596,7 @@ allscreens_kbdflags="" # Set this kbdcontrol mode for all virtual screens > > > mta_start_script="/etc/rc.sendmail" > > > # Script to start your chosen MTA, called by /etc/rc. > > > # Settings for /etc/rc.sendmail and /etc/rc.d/sendmail: > > > -sendmail_enable="NO" # Run the sendmail inbound daemon (YES/NO). > > > +sendmail_enable="NONE" # Run the sendmail inbound daemon (YES/NO). > > > > The comment on the above line should probably be updated: inexperienced > > users may not know that there is a difference between "NO" and "NONE". > > > > > sendmail_pidfile="/var/run/sendmail.pid" # sendmail pid file > > > sendmail_procname="/usr/sbin/sendmail" # sendmail process name > > > sendmail_flags="-L sm-mta -bd -q30m" # Flags to sendmail (as a server) > > > > Thanks, > > Matteo > > > You are not the first to report that, I have updated rc.conf a to add "the NONE" value. Also, from the commit: QUOTE -sendmail_enable="NONE" # Run the sendmail inbound daemon (YES/NO). +sendmail_enable="NONE" # Run the sendmail inbound daemon (YES/NO/NONE). END QUOTE My guess is Matteo was after something more like the following text from your commit notes: QUOTE setting sendmail_enable to NONE (which is now the default) turns all the sendmail_*_enable variables to NO END QUOTE In other words, documenting what is different about NONE vs. NO beyond the spelling distinction. === Mark Millard marklmi at yahoo.com