From nobody Mon Nov 07 05:33:05 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N5KdK60d2z4h0Rp; Mon, 7 Nov 2022 05:33:09 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N5KdK4Prpz3FP1; Mon, 7 Nov 2022 05:33:09 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667799189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jtMm2HIhnrVd8LAMkH50615rdkukponmBQg/4cFRKg8=; b=V21slv/Qy9U/xerNc7hX/c+hin6Xneuq951D4SaRjNQVY8QwRN/ZZtvxGUREv8Lu/zR4Mp 3Mz2dN3owfpcxFTjlSKa6XcFJEGaoFQq8J2P9mShBKTPDp8U657l0N+gC6bKCifqdGtJE9 zuNAz3vWTEHDTn4Sg4cBjLtJzyAZ6E1aYKLBOh3qyqLnghDH+5oA/u9opS6+Z28HBDTsjw Di4Xkm/myGwuW8OXRqxagXLURZ+Qpbd7o3llnQ0FqlxmQC8eOazpVp2XsLTEhVdDVOur+L mjJuO3H71jMyyRY9znZF7QlZFbp1HKo/z36mGWZFVS6VIaVXHEFVST6OJ90JAA== Received: from [192.168.1.10] (unknown [IPv6:2601:641:700:5284:a914:467a:45d7:6b4b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 4N5KdK00KLz1Ldb; Mon, 7 Nov 2022 05:33:08 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.66.22102801 Date: Sun, 06 Nov 2022 21:33:05 -0800 Subject: Re: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc script in ZFS based VM images From: Ravi Pokala To: Li-Wen Hsu , , , Message-ID: <9A7B38D3-9BC4-4B45-A71D-0604F7F4887A@panasas.com> Thread-Topic: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc script in ZFS based VM images References: <202211070350.2A73oo64051412@gitrepo.freebsd.org> In-Reply-To: <202211070350.2A73oo64051412@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667799189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jtMm2HIhnrVd8LAMkH50615rdkukponmBQg/4cFRKg8=; b=pMDcHr9rNJPEOUwP3rXgO1JxmgJZU7IQ4GuossOv/eIUYzEm9d1X+2/yie2IM88Vp88fte LKkL2CFUnm4aRMEdSE/tYz9sQqy5JBMqOtuUyeIWH0EURt7M9GVQ+XqaGhe8Y5lzZP5QBk IQwT8d4vqdtaBnciKIcCRpc8b5b3TXkT7gLJMzzDnVb6EdAIemCUfMleLI+prkLLV6OT/+ qkDxozMTUOijviksTliXo3+esFYCSBNESEMItGkRderr5sGppVbWWlZAGLv0OtjOZI0c0u PkvWPUiOwUZPclCjpKrrH1cfRqGWHZgWRialFclNUyLaWP/2m56ImRgv2AXFgg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1667799189; a=rsa-sha256; cv=none; b=AHczUwstyw/lgfeEr2oeY9ndCaWUydBOhsL5wdHLhYaVtMGZrd3CCul5D3Vi3/9EFSg1eK Irl5hvIgLCijt0DjF6rzvqy+AH5/loDktQ4wuSYChegxMYLKOckfVVIN1+rUvGjyyQ6bru mTo7o9Z1k4BxIw6eS92bxt/Q1YNUpieW/tJCe33hiFDDDH8X2fMDQ/1mtB2YNtI+4qfFCg D/cf3LYNkEpjloSArz/fn5syaF6iA49SGTH98vo3ZrpiQomzlufp4fOc9fPPsLNDa4ADwn 7trvRWQpkvEz+CyWOtRpfL/xGYnP/G378IA5R++nAuQdV6J38dunlHhNUm+6/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Hi Li-Wen, If I'm reading this (and 72a1cb05cd23) correctly, this will run `zpool upgr= ade' on the "zroot" pool on every boot. That's fine for the first time a VM = image is used, since presumably the root pool and the bootloader were genera= ted from the same sources. But if the root pool is subsequently upgraded by = the running VM, don't we need to make sure the bootloader is also upgraded? = Otherwise, don't we run into the possibility of this new `zpoolupgrade' scri= pt enabling features which are not supported by the bootloader? There should be some mechanism for upgrading the bootloader, or else someth= ing else that runs on the first boot from the VM image should disable `zpool= upgrade' so it is only run the first time. Thanks, Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: on behalf of Li-Wen Hsu Date: 2022-11-06, Sunday at 19:50 To: , , Subject: git: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc scri= pt in ZFS based VM images The branch main has been updated by lwhsu: URL: https://cgit.FreeBSD.org/src/commit/?id=3D3bf53c4c8f53b1f19313e9c314= 15c7eee830cdc0 commit 3bf53c4c8f53b1f19313e9c31415c7eee830cdc0 Author: Li-Wen Hsu AuthorDate: 2022-11-07 03:47:33 +0000 Commit: Li-Wen Hsu CommitDate: 2022-11-07 03:47:33 +0000 release(7): Enable zpoolupgrade rc script in ZFS based VM images This will enable VM access to all ZFS feature automatically, only o= n a newly installed or provisioned VM or cloud instance. Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D37283 --- release/tools/vmimage.subr | 1 + 1 file changed, 1 insertion(+) diff --git a/release/tools/vmimage.subr b/release/tools/vmimage.subr index 8982e768527a..a65ec4f1a1f9 100644 --- a/release/tools/vmimage.subr +++ b/release/tools/vmimage.subr @@ -83,6 +83,7 @@ vm_install_base() { if [ "${VMFS}" =3D zfs ]; then echo "zfs_enable=3D\"YES\"" >> ${DESTDIR}/etc/rc.conf echo "zpool_reguid=3D\"zroot\"" >> ${DESTDIR}/etc/rc.conf + echo "zpool_upgrade=3D\"zroot\"" >> ${DESTDIR}/etc/rc.conf fi if ! [ -z "${QEMUSTATIC}" ]; then