git: 2646cd085850 - main - sctp: use a consistent view of the send parameters
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 28 May 2022 17:37:25 UTC
The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=2646cd085850f047eb17c7df53823b1d48deca82 commit 2646cd085850f047eb17c7df53823b1d48deca82 Author: Michael Tuexen <tuexen@FreeBSD.org> AuthorDate: 2022-05-28 17:35:58 +0000 Commit: Michael Tuexen <tuexen@FreeBSD.org> CommitDate: 2022-05-28 17:35:58 +0000 sctp: use a consistent view of the send parameters Reported by: syzbot+e26628a755f78bacff16@syzkaller.appspotmail.com MFC after: 3 days --- sys/netinet/sctp_output.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/netinet/sctp_output.c b/sys/netinet/sctp_output.c index c012618ca181..dfeed2dec563 100644 --- a/sys/netinet/sctp_output.c +++ b/sys/netinet/sctp_output.c @@ -12418,6 +12418,7 @@ sctp_lower_sosend(struct socket *so, struct thread *p ) { + struct sctp_nonpad_sndrcvinfo sndrcvninfo; struct epoch_tracker et; ssize_t sndlen = 0, max_len, local_add_more; int error; @@ -12723,7 +12724,9 @@ sctp_lower_sosend(struct socket *so, atomic_add_int(&asoc->refcnt, 1); free_cnt_applied = true; if (srcv == NULL) { - srcv = (struct sctp_sndrcvinfo *)&asoc->def_send; + /* Use a local copy to have a consistent view. */ + sndrcvninfo = asoc->def_send; + srcv = (struct sctp_sndrcvinfo *)&sndrcvninfo; sinfo_flags = srcv->sinfo_flags; if (flags & MSG_EOR) { sinfo_flags |= SCTP_EOR;