From nobody Fri May 27 21:33:46 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B4BD91B40DFD; Fri, 27 May 2022 21:33:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L8yjQ4jZJz3R53; Fri, 27 May 2022 21:33:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653687226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ot/J7Y5GDLd/DNE54S7XwbEMHJAOor/emAeR6WlV0og=; b=rv6/t01U3baq7CrGYeri3BGZp8bRVML+ipG04nZzHfRHmumhln31znl1hv6SGWJ6lJa98a 9aiEW0Q1rJ15B+MMVr6/dXzKFBFu9jAipQwXGvwzhGjt0hmr7qxtzzfGPFXSUXkGbhmdug z1P75kyWBdJWGcx7JQze+AtzVDZF495gKXET8xfspvMC+je4yNeUGYPvuPjJaBsR5JvGKf rhQWxrV6OMA37kMoHEJHQ39MKFPRC0SbeQlCx/q4jyA/zv8MyCKt0/RWU2zKHE+bidHhw5 sRH1DUnTdcDDR8m3tVyIfFmtUQIiWEuUxDh8EoGZbJIdZXk5aHwNvcH4vzvD8A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8215E2A119; Fri, 27 May 2022 21:33:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 24RLXkrr016154; Fri, 27 May 2022 21:33:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 24RLXk4B016153; Fri, 27 May 2022 21:33:46 GMT (envelope-from git) Date: Fri, 27 May 2022 21:33:46 GMT Message-Id: <202205272133.24RLXk4B016153@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: a7bb120f8b87 - main - nfscl: Add a diagnostic printf() for a "should never happen" case List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a7bb120f8b8735bc4c417b3c8fc2308c3d2964aa Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653687226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ot/J7Y5GDLd/DNE54S7XwbEMHJAOor/emAeR6WlV0og=; b=yyTb2/VR1Z792ZEsjUV/O6LDTNpH/fOXzB4yGnnHxX8efvJSDbbI1A/S9MFNzT8gx3Qa18 UwUz7C0avEcP1MIztyuJYxJpXP7JWfp+JskZ0N+IGo3FYgnjfT5iDDL+FCBsopQZNp311v grM6uH5ksTl34R7AExH94vIW7TsYCUXZqCpByJbRglJkiXZ9UOdQvh5Cl6RjIgjltm/TNs 5qluBWaleJoAfOlLZsloevz6Fx5lQCsYSdUt2S6C97kCYnDZ3ilr1J0OIiDN5kZOliJiCY suxBL0ISkeszA4+IZ9gScBP0Y2eMeQPqxhzoxekL1ZaQQ85dskruEszbbrXFXw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653687226; a=rsa-sha256; cv=none; b=miocpJhtwhSrkp6CygC2IBkGvqd8HUH2rS+1LZY5AGlcs8wYy4ertT0cjg1UTbMYRi4qMT r0knPM055YSyvlsZEQ0s6EFTXsV0tRoW8O0jZeQ1BQVM7JcQc1+U6PyxGZh+C0ZvEIBFmW mBJ7ZnwqNn/p5skVtRj2ytVF5MLVaZ0DCwlM59ycihxNEDLXGxd+BJOoytH+JM5VpZ0+ew F+HskT2DFNGzfOj24PfEzu06I0pCSvcJIJ70kbztzFA5j7i+5sQnxeEj9ZPp4/YrArNJ0D 7LFwPk40EEhczEud6HRjJUQVrcn/sdeq3VCfzclFGMctG2gov2DZdUBNzbF02w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=a7bb120f8b8735bc4c417b3c8fc2308c3d2964aa commit a7bb120f8b8735bc4c417b3c8fc2308c3d2964aa Author: Rick Macklem AuthorDate: 2022-05-27 21:32:46 +0000 Commit: Rick Macklem CommitDate: 2022-05-27 21:32:46 +0000 nfscl: Add a diagnostic printf() for a "should never happen" case When a NFSv4.1/4.2 session to the NFS server (not a pNFS DS) is replaced, the old session should always be marked defunct by nfsess_defunct being set non-zero. However, the hang reported by the PR suggests that this might be the case. This patch adds a printf() to indicate this has somehow happened. PR: 260011 MFC after: 2 weeks --- sys/fs/nfsclient/nfs_clrpcops.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/fs/nfsclient/nfs_clrpcops.c b/sys/fs/nfsclient/nfs_clrpcops.c index b1d3ee423194..b785446b1ae6 100644 --- a/sys/fs/nfsclient/nfs_clrpcops.c +++ b/sys/fs/nfsclient/nfs_clrpcops.c @@ -1062,8 +1062,12 @@ nfsrpc_setclient(struct nfsmount *nmp, struct nfsclclient *clp, int reclaim, * in-progress RPCs. */ tsep = NULL; - if (TAILQ_FIRST(&nmp->nm_sess) != NULL) + if (TAILQ_FIRST(&nmp->nm_sess) != NULL) { tsep = NFSMNT_MDSSESSION(nmp); + if (tsep->nfsess_defunct == 0) + printf("nfsrpc_setclient: " + "nfsess_defunct not set\n"); + } TAILQ_INSERT_HEAD(&nmp->nm_sess, dsp, nfsclds_list); /*