From nobody Sat May 14 19:40:42 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7CE4E1AD85B6; Sat, 14 May 2022 19:40:53 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L0wq92yQFz3w0l; Sat, 14 May 2022 19:40:53 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652557253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EUTm9NW/tOilN7/O4Bm9cUFxXgF5KQG4T9EGpZBiXac=; b=hawbBVMjZJ4/muALUxpLpMv3qLrW7OWduCDFNoJE/MsJGxHO/aYcPK+Oi+hnVXGHwBL257 T/zzfVpKTMeJXmQcGtuMBj+olzQBgPF7EpY3CRMOKzZ6PT8ngoGq7DB/Ga/od7SmoOfs+C QcMBKBkgpRzAc9biiS0YEOc85rBnsmNynxSbBjg6xp76yCxM7MTMiKqBXfYfrOWwjU8ZH9 6OG+5U+F0pGGcmuTBlrGDV5vb3GenqnSBpeoFeKbRrvgpL/Rvi/SOWvBB3borD9hax7fii 3yI0ZRMOEi+DkdXlfZb2dheBgFBRunSvVtwvLlA8kHgC570teiJyk3Ahmw/nGg== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 2B3389780; Sat, 14 May 2022 19:40:53 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id DA59E3D5DF; Sat, 14 May 2022 21:40:50 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_F4BA942F-87D7-4100-8DBB-F41BBAB651FE"; protocol="application/pgp-signature"; micalg=pgp-sha1 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: git: 3a9a9c0ca44e - main - Merge llvm-project release/14.x llvmorg-14.0.3-0-g1f9140064dfb From: Dimitry Andric In-Reply-To: Date: Sat, 14 May 2022 21:40:42 +0200 Cc: "Bjoern A. Zeeb" , src-committers , "" , dev-commits-src-main@freebsd.org Message-Id: References: <202205141150.24EBoNnp024476@gitrepo.freebsd.org> <4ADA9C8C-FE58-439A-B8B4-C04F6E207FE5@FreeBSD.org> To: Warner Losh X-Mailer: Apple Mail (2.3696.80.82.1.1) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652557253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EUTm9NW/tOilN7/O4Bm9cUFxXgF5KQG4T9EGpZBiXac=; b=HyNWG5kmIPwDQeC5Vqfcu10E2RAuswBL6XoRacwnA5rueDFwq2YgkmWKtomp1TcFZByY50 0+JrC0BbnzGnDsolAEGbN6qGrTB2fRsDsUqEvMHrHFgLCdceFk8dK/JrIROu9JjYDphns+ 85oLYJnIsCLe2FlyIYY73DEn1aZckr19KHsNHj9Z8RpEw+ogVXP+gNS2eKXxwQlPG4zeUq vyHTLVxJHzScXtyyBikcvTDEWJfUghVcsf1+hu75nF+7wb17fJ4QdEjsF3RukY4qMqRSRo uM3jA3tpEq1NXXnHgntAEkUnxDQtkf/cdjIQvhlZDU76il5krfTBCmarnvnYTA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652557253; a=rsa-sha256; cv=none; b=rb2ZJyvFvtJT21GtTySe4yUcGJvy3Y6+L/4R6iXkF6G/e9/E/UTnpy34LaGEs7knLq3UDN g68N1V1EwgIQM5FchmDVZi9bEL/D7Cs5JIo5BbRHiq6QzJrF6+bheNt4y9YnyYGPVDpx0N e0YEnJ69VBbIR+WCZcp0DPj0CN/fbRH9CsRAuum3NXzfNYE+X/mkkjJHACeK4iJyH7u1XZ iIHF1twwG5HAiMudBmehnWn1HnvE934lm5XWg+Tp5XqyZjID2d9ltl9yLNKAvd7e+lltfq Ou2Cs0/LlTtohlx3sSMorGANDTyiZoTM6LGTMqTUiWMiFnsxbT4u0PJwfxbnlg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_F4BA942F-87D7-4100-8DBB-F41BBAB651FE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 14 May 2022, at 21:07, Warner Losh wrote: >=20 > On Sat, May 14, 2022, 12:00 PM Dimitry Andric wrote: > On 14 May 2022, at 19:11, Bjoern A. Zeeb wrote: > ... > > I haven't checked where they come from yet (given make -s). Possibly = ..? > > > > sys/conf/kmod.mk:LDFLAGS+=3D -d -warn-common >=20 > Ah yes, thanks for spotting that. I think I'll just put in a linker > version check, and avoid the option for lld >=3D 14. >=20 >=20 > Two items : do we need it at all? It's a bit of an obscure option, introduced way back in 2002: = https://cgit.freebsd.org/src/commit/?id=3D0b3178a45cd08a2387bff09a2844deac= c97ae1e7 where the original comment had "Disallow common variables, and if we end up with commons from somewhere unexpected, allocate storage for them in the module itself." BFD ld's docs = (https://sourceware.org/binutils/docs/ld/Options.html#index-common-allocat= ion) say: "assign space to common symbols even if a relocatable output file is specified (with '-r'). The script command FORCE_COMMON_ALLOCATION has the same effect." Since lld implements it as a no-op, and everything appears to work just fine, I'd only keep it in for now for people that want to use gcc in combination with BFD ld for building their modules. > Won't this make build stable/13 noisy in same cases? We can just = document it since it wouldn't be the mainline build, but it will come = up... It shouldn't, as I'm putting in a check for the lld version. If >=3D 14, it will just not add the option at all. -Dimitry --Apple-Mail=_F4BA942F-87D7-4100-8DBB-F41BBAB651FE Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCYoAFugAKCRCwXqMKLiCW o9MyAKCexx/jGZLJMAs9c3QTMMWkEHWF8gCfQAWHW7VZ6fIMGFUgNes/FNZdr2M= =74jv -----END PGP SIGNATURE----- --Apple-Mail=_F4BA942F-87D7-4100-8DBB-F41BBAB651FE--