git: 489ba2223676 - main - kerneldump: remove physical argument from d_dumper
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 13 May 2022 13:43:46 UTC
The branch main has been updated by mhorne:
URL: https://cgit.FreeBSD.org/src/commit/?id=489ba2223676ec251ab1bfe2906d2a62959c8ce3
commit 489ba2223676ec251ab1bfe2906d2a62959c8ce3
Author: Mitchell Horne <mhorne@FreeBSD.org>
AuthorDate: 2022-05-13 13:39:29 +0000
Commit: Mitchell Horne <mhorne@FreeBSD.org>
CommitDate: 2022-05-13 13:42:48 +0000
kerneldump: remove physical argument from d_dumper
The physical address argument is essentially ignored by every dumper
method. In addition, the dump routines don't actually pass a real
address; every call to dump_append() passes a value of zero for
physical.
Reviewed by: markj
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D35173
---
sys/cam/ata/ata_da.c | 4 ++--
sys/cam/mmc/mmc_da.c | 3 +--
sys/cam/nvme/nvme_da.c | 4 ++--
sys/cam/scsi/scsi_da.c | 4 ++--
sys/dev/aac/aac_disk.c | 6 +++---
sys/dev/ida/ida_disk.c | 2 +-
sys/dev/ips/ips_disk.c | 6 ++----
sys/dev/mfi/mfi_disk.c | 2 +-
sys/dev/mfi/mfi_syspd.c | 3 +--
sys/dev/mmc/mmcsd.c | 6 ++----
sys/dev/nvd/nvd.c | 2 +-
sys/dev/virtio/block/virtio_blk.c | 5 ++---
sys/dev/xen/blkfront/blkfront.c | 3 +--
sys/geom/nop/g_nop.c | 3 +--
sys/geom/raid/g_raid.c | 14 ++++++--------
sys/geom/raid/g_raid.h | 4 ++--
sys/geom/raid/g_raid_tr_if.m | 1 -
sys/geom/raid/tr_concat.c | 6 +++---
sys/geom/raid/tr_raid0.c | 6 +++---
sys/geom/raid/tr_raid1.c | 7 +++----
sys/geom/raid/tr_raid1e.c | 8 ++++----
sys/geom/raid/tr_raid5.c | 4 ++--
sys/geom/union/g_union.c | 5 ++---
sys/kern/kern_shutdown.c | 2 +-
sys/kern/kern_vnodedumper.c | 4 +---
sys/netinet/netdump/netdump_client.c | 6 ++----
sys/sys/conf.h | 1 -
27 files changed, 51 insertions(+), 70 deletions(-)
diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c
index aed08a8566ae..ee6ea0b18902 100644
--- a/sys/cam/ata/ata_da.c
+++ b/sys/cam/ata/ata_da.c
@@ -1099,7 +1099,7 @@ adastrategy(struct bio *bp)
}
static int
-adadump(void *arg, void *virtual, vm_offset_t physical, off_t offset, size_t length)
+adadump(void *arg, void *virtual, off_t offset, size_t length)
{
struct cam_periph *periph;
struct ada_softc *softc;
@@ -3562,7 +3562,7 @@ adaflush(void)
/* If we panicked with the lock held, do not recurse. */
if (!cam_periph_owned(periph) &&
(softc->flags & ADA_FLAG_OPEN)) {
- adadump(softc->disk, NULL, 0, 0, 0);
+ adadump(softc->disk, NULL, 0, 0);
}
continue;
}
diff --git a/sys/cam/mmc/mmc_da.c b/sys/cam/mmc/mmc_da.c
index 3f6aee72f1d1..d352f2d91415 100644
--- a/sys/cam/mmc/mmc_da.c
+++ b/sys/cam/mmc/mmc_da.c
@@ -2006,8 +2006,7 @@ sddaerror(union ccb *ccb, u_int32_t cam_flags, u_int32_t sense_flags)
}
static int
-sddadump(void *arg, void *virtual, vm_offset_t physical, off_t offset,
- size_t length)
+sddadump(void *arg, void *virtual, off_t offset, size_t length)
{
struct ccb_mmcio mmcio;
struct disk *dp;
diff --git a/sys/cam/nvme/nvme_da.c b/sys/cam/nvme/nvme_da.c
index 1bd476910269..1175a0e99b3c 100644
--- a/sys/cam/nvme/nvme_da.c
+++ b/sys/cam/nvme/nvme_da.c
@@ -499,7 +499,7 @@ ndastrategy(struct bio *bp)
}
static int
-ndadump(void *arg, void *virtual, vm_offset_t physical, off_t offset, size_t length)
+ndadump(void *arg, void *virtual, off_t offset, size_t length)
{
struct cam_periph *periph;
struct nda_softc *softc;
@@ -1329,7 +1329,7 @@ ndaflush(void)
*/
if (!cam_periph_owned(periph) &&
(softc->flags & NDA_FLAG_OPEN)) {
- ndadump(softc->disk, NULL, 0, 0, 0);
+ ndadump(softc->disk, NULL, 0, 0);
}
continue;
}
diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c
index ed71a25cd657..4c298af3432d 100644
--- a/sys/cam/scsi/scsi_da.c
+++ b/sys/cam/scsi/scsi_da.c
@@ -1915,7 +1915,7 @@ dastrategy(struct bio *bp)
}
static int
-dadump(void *arg, void *virtual, vm_offset_t physical, off_t offset, size_t length)
+dadump(void *arg, void *virtual, off_t offset, size_t length)
{
struct cam_periph *periph;
struct da_softc *softc;
@@ -6274,7 +6274,7 @@ dashutdown(void * arg, int howto)
/* If we paniced with the lock held, do not recurse. */
if (!cam_periph_owned(periph) &&
(softc->flags & DA_FLAG_OPEN)) {
- dadump(softc->disk, NULL, 0, 0, 0);
+ dadump(softc->disk, NULL, 0, 0);
}
continue;
}
diff --git a/sys/dev/aac/aac_disk.c b/sys/dev/aac/aac_disk.c
index 9066c18138c2..2cc5345f1a89 100644
--- a/sys/dev/aac/aac_disk.c
+++ b/sys/dev/aac/aac_disk.c
@@ -232,7 +232,7 @@ aac_dump_map_sg64(void *arg, bus_dma_segment_t *segs, int nsegs, int error)
* Send out one command at a time with up to maxio of data.
*/
static int
-aac_disk_dump(void *arg, void *virtual, vm_offset_t physical, off_t offset, size_t length)
+aac_disk_dump(void *arg, void *virtual, off_t offset, size_t length)
{
struct aac_disk *ad;
struct aac_softc *sc;
@@ -311,8 +311,8 @@ aac_disk_dump(void *arg, void *virtual, vm_offset_t physical, off_t offset, size
if (aac_sync_fib(sc, command, 0, fib, size)) {
device_printf(sc->aac_dev,
- "Error dumping block 0x%jx\n",
- (uintmax_t)physical);
+ "Error dumping block to 0x%jx\n",
+ (uintmax_t)offset);
return (EIO);
}
diff --git a/sys/dev/ida/ida_disk.c b/sys/dev/ida/ida_disk.c
index 0cd242d45bf2..e18c58cc8b72 100644
--- a/sys/dev/ida/ida_disk.c
+++ b/sys/dev/ida/ida_disk.c
@@ -125,7 +125,7 @@ bad:
}
static int
-idad_dump(void *arg, void *virtual, vm_offset_t physical, off_t offset, size_t length)
+idad_dump(void *arg, void *virtual, off_t offset, size_t length)
{
struct idad_softc *drv;
diff --git a/sys/dev/ips/ips_disk.c b/sys/dev/ips/ips_disk.c
index eb9ec08c1d94..48bac3d6e1b3 100644
--- a/sys/dev/ips/ips_disk.c
+++ b/sys/dev/ips/ips_disk.c
@@ -39,8 +39,7 @@ static int ipsd_probe(device_t dev);
static int ipsd_attach(device_t dev);
static int ipsd_detach(device_t dev);
-static int ipsd_dump(void *arg, void *virtual, vm_offset_t physical,
- off_t offset, size_t length);
+static int ipsd_dump(void *arg, void *virtual, off_t offset, size_t length);
static void ipsd_dump_map_sg(void *arg, bus_dma_segment_t *segs, int nsegs,
int error);
static void ipsd_dump_block_complete(ips_command_t *command);
@@ -185,8 +184,7 @@ static int ipsd_detach(device_t dev)
}
static int
-ipsd_dump(void *arg, void *virtual, vm_offset_t physical, off_t offset,
- size_t length)
+ipsd_dump(void *arg, void *virtual, off_t offset, size_t length)
{
ipsdisk_softc_t *dsc;
ips_softc_t *sc;
diff --git a/sys/dev/mfi/mfi_disk.c b/sys/dev/mfi/mfi_disk.c
index 277144f36ef8..667a9f60351c 100644
--- a/sys/dev/mfi/mfi_disk.c
+++ b/sys/dev/mfi/mfi_disk.c
@@ -315,7 +315,7 @@ mfi_disk_complete(struct bio *bio)
}
static int
-mfi_disk_dump(void *arg, void *virt, vm_offset_t phys, off_t offset, size_t len)
+mfi_disk_dump(void *arg, void *virt, off_t offset, size_t len)
{
struct mfi_disk *sc;
struct mfi_softc *parent_sc;
diff --git a/sys/dev/mfi/mfi_syspd.c b/sys/dev/mfi/mfi_syspd.c
index 542df25aea3d..9b447fbfb1d4 100644
--- a/sys/dev/mfi/mfi_syspd.c
+++ b/sys/dev/mfi/mfi_syspd.c
@@ -264,8 +264,7 @@ mfi_syspd_strategy(struct bio *bio)
}
static int
-mfi_syspd_dump(void *arg, void *virt, vm_offset_t phys, off_t offset,
- size_t len)
+mfi_syspd_dump(void *arg, void *virt, off_t offset, size_t len)
{
struct mfi_system_pd *sc;
struct mfi_softc *parent_sc;
diff --git a/sys/dev/mmc/mmcsd.c b/sys/dev/mmc/mmcsd.c
index 34ec380a280e..225088364ef8 100644
--- a/sys/dev/mmc/mmcsd.c
+++ b/sys/dev/mmc/mmcsd.c
@@ -173,8 +173,7 @@ static int mmcsd_shutdown(device_t dev);
/* disk routines */
static int mmcsd_close(struct disk *dp);
-static int mmcsd_dump(void *arg, void *virtual, vm_offset_t physical,
- off_t offset, size_t length);
+static int mmcsd_dump(void *arg, void *virtual, off_t offset, size_t length);
static int mmcsd_getattr(struct bio *);
static int mmcsd_ioctl_disk(struct disk *disk, u_long cmd, void *data,
int fflag, struct thread *td);
@@ -1378,8 +1377,7 @@ unpause:
}
static int
-mmcsd_dump(void *arg, void *virtual, vm_offset_t physical, off_t offset,
- size_t length)
+mmcsd_dump(void *arg, void *virtual, off_t offset, size_t length)
{
struct bio bp;
daddr_t block, end;
diff --git a/sys/dev/nvd/nvd.c b/sys/dev/nvd/nvd.c
index ea44458885d2..e8fd115ec834 100644
--- a/sys/dev/nvd/nvd.c
+++ b/sys/dev/nvd/nvd.c
@@ -291,7 +291,7 @@ nvd_ioctl(struct disk *dp, u_long cmd, void *data, int fflag,
}
static int
-nvd_dump(void *arg, void *virt, vm_offset_t phys, off_t offset, size_t len)
+nvd_dump(void *arg, void *virt, off_t offset, size_t len)
{
struct disk *dp = arg;
struct nvd_disk *ndisk = dp->d_drv1;
diff --git a/sys/dev/virtio/block/virtio_blk.c b/sys/dev/virtio/block/virtio_blk.c
index e1b9e2004add..c26447496732 100644
--- a/sys/dev/virtio/block/virtio_blk.c
+++ b/sys/dev/virtio/block/virtio_blk.c
@@ -134,7 +134,7 @@ static int vtblk_open(struct disk *);
static int vtblk_close(struct disk *);
static int vtblk_ioctl(struct disk *, u_long, void *, int,
struct thread *);
-static int vtblk_dump(void *, void *, vm_offset_t, off_t, size_t);
+static int vtblk_dump(void *, void *, off_t, size_t);
static void vtblk_strategy(struct bio *);
static int vtblk_negotiate_features(struct vtblk_softc *);
@@ -531,8 +531,7 @@ vtblk_ioctl(struct disk *dp, u_long cmd, void *addr, int flag,
}
static int
-vtblk_dump(void *arg, void *virtual, vm_offset_t physical, off_t offset,
- size_t length)
+vtblk_dump(void *arg, void *virtual, off_t offset, size_t length)
{
struct disk *dp;
struct vtblk_softc *sc;
diff --git a/sys/dev/xen/blkfront/blkfront.c b/sys/dev/xen/blkfront/blkfront.c
index 87054a4d1240..9dc1252e5756 100644
--- a/sys/dev/xen/blkfront/blkfront.c
+++ b/sys/dev/xen/blkfront/blkfront.c
@@ -593,8 +593,7 @@ xbd_dump_complete(struct xbd_command *cm)
}
static int
-xbd_dump(void *arg, void *virtual, vm_offset_t physical, off_t offset,
- size_t length)
+xbd_dump(void *arg, void *virtual, off_t offset, size_t length)
{
struct disk *dp = arg;
struct xbd_softc *sc = dp->d_drv1;
diff --git a/sys/geom/nop/g_nop.c b/sys/geom/nop/g_nop.c
index 5e383cd35733..57208a0744db 100644
--- a/sys/geom/nop/g_nop.c
+++ b/sys/geom/nop/g_nop.c
@@ -130,8 +130,7 @@ g_nop_resize(struct g_consumer *cp)
}
static int
-g_nop_dumper(void *priv, void *virtual, vm_offset_t physical, off_t offset,
- size_t length)
+g_nop_dumper(void *priv, void *virtual, off_t offset, size_t length)
{
return (0);
diff --git a/sys/geom/raid/g_raid.c b/sys/geom/raid/g_raid.c
index fc5852d28fd7..561ac5b45e42 100644
--- a/sys/geom/raid/g_raid.c
+++ b/sys/geom/raid/g_raid.c
@@ -1033,8 +1033,7 @@ g_raid_tr_kerneldump_common(struct g_raid_tr_object *tr,
}
static int
-g_raid_dump(void *arg,
- void *virtual, vm_offset_t physical, off_t offset, size_t length)
+g_raid_dump(void *arg, void *virtual, off_t offset, size_t length)
{
struct g_raid_volume *vol;
int error;
@@ -1043,8 +1042,7 @@ g_raid_dump(void *arg,
G_RAID_DEBUG1(3, vol->v_softc, "Dumping at off %llu len %llu.",
(long long unsigned)offset, (long long unsigned)length);
- error = G_RAID_TR_KERNELDUMP(vol->v_tr,
- virtual, physical, offset, length);
+ error = G_RAID_TR_KERNELDUMP(vol->v_tr, virtual, offset, length);
return (error);
}
@@ -1397,7 +1395,7 @@ nodisk:
G_RAID_LOGREQ(3, bp, "Sending dumping request.");
if (bp->bio_cmd == BIO_WRITE) {
bp->bio_error = g_raid_subdisk_kerneldump(sd,
- bp->bio_data, 0, bp->bio_offset, bp->bio_length);
+ bp->bio_data, bp->bio_offset, bp->bio_length);
} else
bp->bio_error = EOPNOTSUPP;
g_raid_disk_done(bp);
@@ -1410,8 +1408,8 @@ nodisk:
}
int
-g_raid_subdisk_kerneldump(struct g_raid_subdisk *sd,
- void *virtual, vm_offset_t physical, off_t offset, size_t length)
+g_raid_subdisk_kerneldump(struct g_raid_subdisk *sd, void *virtual,
+ off_t offset, size_t length)
{
if (sd->sd_disk == NULL)
@@ -1419,7 +1417,7 @@ g_raid_subdisk_kerneldump(struct g_raid_subdisk *sd,
if (sd->sd_disk->d_kd.di.dumper == NULL)
return (EOPNOTSUPP);
return (dump_write(&sd->sd_disk->d_kd.di,
- virtual, physical,
+ virtual, 0,
sd->sd_disk->d_kd.di.mediaoffset + sd->sd_offset + offset,
length));
}
diff --git a/sys/geom/raid/g_raid.h b/sys/geom/raid/g_raid.h
index eeaa8ac32508..720d588d9118 100644
--- a/sys/geom/raid/g_raid.h
+++ b/sys/geom/raid/g_raid.h
@@ -406,8 +406,8 @@ int g_raid_destroy_disk(struct g_raid_disk *disk);
void g_raid_iodone(struct bio *bp, int error);
void g_raid_subdisk_iostart(struct g_raid_subdisk *sd, struct bio *bp);
-int g_raid_subdisk_kerneldump(struct g_raid_subdisk *sd,
- void *virtual, vm_offset_t physical, off_t offset, size_t length);
+int g_raid_subdisk_kerneldump(struct g_raid_subdisk *sd, void *virtual,
+ off_t offset, size_t length);
struct g_consumer *g_raid_open_consumer(struct g_raid_softc *sc,
const char *name);
diff --git a/sys/geom/raid/g_raid_tr_if.m b/sys/geom/raid/g_raid_tr_if.m
index 193b4298691a..8de09ba1eb56 100644
--- a/sys/geom/raid/g_raid_tr_if.m
+++ b/sys/geom/raid/g_raid_tr_if.m
@@ -95,7 +95,6 @@ METHOD void iodone {
METHOD int kerneldump {
struct g_raid_tr_object *tr;
void *virtual;
- vm_offset_t physical;
off_t offset;
size_t length;
} DEFAULT g_raid_tr_kerneldump_common;
diff --git a/sys/geom/raid/tr_concat.c b/sys/geom/raid/tr_concat.c
index dca728bf6dc4..a0a69502206f 100644
--- a/sys/geom/raid/tr_concat.c
+++ b/sys/geom/raid/tr_concat.c
@@ -286,8 +286,8 @@ failure:
}
static int
-g_raid_tr_kerneldump_concat(struct g_raid_tr_object *tr,
- void *virtual, vm_offset_t physical, off_t boffset, size_t blength)
+g_raid_tr_kerneldump_concat(struct g_raid_tr_object *tr, void *virtual,
+ off_t boffset, size_t blength)
{
struct g_raid_volume *vol;
struct g_raid_subdisk *sd;
@@ -314,7 +314,7 @@ g_raid_tr_kerneldump_concat(struct g_raid_tr_object *tr,
sd = &vol->v_subdisks[no];
length = MIN(sd->sd_size - offset, remain);
error = g_raid_subdisk_kerneldump(&vol->v_subdisks[no],
- addr, 0, offset, length);
+ addr, offset, length);
if (error != 0)
return (error);
remain -= length;
diff --git a/sys/geom/raid/tr_raid0.c b/sys/geom/raid/tr_raid0.c
index 22e2d6e1edda..43782a0956a2 100644
--- a/sys/geom/raid/tr_raid0.c
+++ b/sys/geom/raid/tr_raid0.c
@@ -269,7 +269,7 @@ failure:
static int
g_raid_tr_kerneldump_raid0(struct g_raid_tr_object *tr,
- void *virtual, vm_offset_t physical, off_t boffset, size_t blength)
+ void *virtual, off_t boffset, size_t blength)
{
struct g_raid_volume *vol;
char *addr;
@@ -296,8 +296,8 @@ g_raid_tr_kerneldump_raid0(struct g_raid_tr_object *tr,
do {
length = MIN(strip_size - start, remain);
- error = g_raid_subdisk_kerneldump(&vol->v_subdisks[no],
- addr, 0, offset + start, length);
+ error = g_raid_subdisk_kerneldump(&vol->v_subdisks[no], addr,
+ offset + start, length);
if (error != 0)
return (error);
if (++no >= vol->v_disks_count) {
diff --git a/sys/geom/raid/tr_raid1.c b/sys/geom/raid/tr_raid1.c
index 63bea0945c9c..7a6f76a3137d 100644
--- a/sys/geom/raid/tr_raid1.c
+++ b/sys/geom/raid/tr_raid1.c
@@ -899,8 +899,8 @@ rebuild_round_done:
}
static int
-g_raid_tr_kerneldump_raid1(struct g_raid_tr_object *tr,
- void *virtual, vm_offset_t physical, off_t offset, size_t length)
+g_raid_tr_kerneldump_raid1(struct g_raid_tr_object *tr, void *virtual,
+ off_t offset, size_t length)
{
struct g_raid_volume *vol;
struct g_raid_subdisk *sd;
@@ -935,8 +935,7 @@ g_raid_tr_kerneldump_raid1(struct g_raid_tr_object *tr,
default:
continue;
}
- error = g_raid_subdisk_kerneldump(sd,
- virtual, physical, offset, length);
+ error = g_raid_subdisk_kerneldump(sd, virtual, offset, length);
if (error == 0)
ok++;
}
diff --git a/sys/geom/raid/tr_raid1e.c b/sys/geom/raid/tr_raid1e.c
index 45a48acfd3b2..937d5ee8bb08 100644
--- a/sys/geom/raid/tr_raid1e.c
+++ b/sys/geom/raid/tr_raid1e.c
@@ -1144,8 +1144,8 @@ rebuild_round_done:
}
static int
-g_raid_tr_kerneldump_raid1e(struct g_raid_tr_object *tr,
- void *virtual, vm_offset_t physical, off_t boffset, size_t blength)
+g_raid_tr_kerneldump_raid1e(struct g_raid_tr_object *tr, void *virtual,
+ off_t boffset, size_t blength)
{
struct g_raid_volume *vol;
struct g_raid_subdisk *sd;
@@ -1177,8 +1177,8 @@ g_raid_tr_kerneldump_raid1e(struct g_raid_tr_object *tr,
default:
goto nextdisk;
}
- error = g_raid_subdisk_kerneldump(sd,
- addr, 0, offset + start, length);
+ error = g_raid_subdisk_kerneldump(sd, addr,
+ offset + start, length);
if (error != 0)
return (error);
nextdisk:
diff --git a/sys/geom/raid/tr_raid5.c b/sys/geom/raid/tr_raid5.c
index 431f9cad09de..5fa4edd49248 100644
--- a/sys/geom/raid/tr_raid5.c
+++ b/sys/geom/raid/tr_raid5.c
@@ -385,8 +385,8 @@ g_raid_tr_iodone_raid5(struct g_raid_tr_object *tr,
}
static int
-g_raid_tr_kerneldump_raid5(struct g_raid_tr_object *tr,
- void *virtual, vm_offset_t physical, off_t offset, size_t length)
+g_raid_tr_kerneldump_raid5(struct g_raid_tr_object *tr, void *virtual,
+ off_t offset, size_t length)
{
return (ENODEV);
diff --git a/sys/geom/union/g_union.c b/sys/geom/union/g_union.c
index 23f7eaac25a9..ddc0acf52b78 100644
--- a/sys/geom/union/g_union.c
+++ b/sys/geom/union/g_union.c
@@ -88,7 +88,7 @@ static bool g_union_getmap(struct bio *bp, struct g_union_softc *sc,
off_t *len2read);
static void g_union_done(struct bio *bp);
static void g_union_kerneldump(struct bio *bp, struct g_union_softc *sc);
-static int g_union_dumper(void *, void *, vm_offset_t, off_t, size_t);
+static int g_union_dumper(void *, void *, off_t, size_t);
static int g_union_destroy(struct gctl_req *req, struct g_geom *gp, bool force);
/*
@@ -1222,8 +1222,7 @@ g_union_kerneldump(struct bio *bp, struct g_union_softc *sc)
* Handler for g_union_kerneldump().
*/
static int
-g_union_dumper(void *priv, void *virtual, vm_offset_t physical, off_t offset,
- size_t length)
+g_union_dumper(void *priv, void *virtual, off_t offset, size_t length)
{
return (0);
diff --git a/sys/kern/kern_shutdown.c b/sys/kern/kern_shutdown.c
index f7e72d53a566..b5433e4ed55f 100644
--- a/sys/kern/kern_shutdown.c
+++ b/sys/kern/kern_shutdown.c
@@ -1754,7 +1754,7 @@ dump_write(struct dumperinfo *di, void *virtual, vm_offset_t physical,
error = dump_check_bounds(di, offset, length);
if (error != 0)
return (error);
- return (di->dumper(di->priv, virtual, physical, offset, length));
+ return (di->dumper(di->priv, virtual, offset, length));
}
/*
diff --git a/sys/kern/kern_vnodedumper.c b/sys/kern/kern_vnodedumper.c
index cd20f4f2fab4..26154af20372 100644
--- a/sys/kern/kern_vnodedumper.c
+++ b/sys/kern/kern_vnodedumper.c
@@ -150,7 +150,6 @@ vnode_dumper_start(struct dumperinfo *di, void *key, uint32_t keysize)
* Parameters:
* arg Opaque private pointer to vnode
* virtual Virtual address (where to read the data from)
- * physical Physical memory address (unused)
* offset Offset from start of core file
* length Data length
*
@@ -159,8 +158,7 @@ vnode_dumper_start(struct dumperinfo *di, void *key, uint32_t keysize)
* errno on error
*/
int
-vnode_dump(void *arg, void *virtual, vm_offset_t physical __unused,
- off_t offset, size_t length)
+vnode_dump(void *arg, void *virtual, off_t offset, size_t length)
{
struct vnode *vp;
int error = 0;
diff --git a/sys/netinet/netdump/netdump_client.c b/sys/netinet/netdump/netdump_client.c
index b570fed139b9..9f7b6d7965b8 100644
--- a/sys/netinet/netdump/netdump_client.c
+++ b/sys/netinet/netdump/netdump_client.c
@@ -89,7 +89,7 @@ static void netdump_cleanup(void);
static int netdump_configure(struct diocskerneldump_arg *,
struct thread *);
static int netdump_dumper(void *priv __unused, void *virtual,
- vm_offset_t physical __unused, off_t offset, size_t length);
+ off_t offset, size_t length);
static bool netdump_enabled(void);
static int netdump_enabled_sysctl(SYSCTL_HANDLER_ARGS);
static int netdump_ioctl(struct cdev *dev __unused, u_long cmd,
@@ -227,7 +227,6 @@ netdump_flush_buf(void)
* Parameters:
* priv Unused. Optional private pointer.
* virtual Virtual address (where to read the data from)
- * physical Unused. Physical memory address.
* offset Offset from start of core file
* length Data length
*
@@ -236,8 +235,7 @@ netdump_flush_buf(void)
* errno on error
*/
static int
-netdump_dumper(void *priv __unused, void *virtual,
- vm_offset_t physical __unused, off_t offset, size_t length)
+netdump_dumper(void *priv __unused, void *virtual, off_t offset, size_t length)
{
int error;
diff --git a/sys/sys/conf.h b/sys/sys/conf.h
index 02671a065c09..37265c6988ce 100644
--- a/sys/sys/conf.h
+++ b/sys/sys/conf.h
@@ -130,7 +130,6 @@ typedef void d_purge_t(struct cdev *dev);
typedef int dumper_t(
void *_priv, /* Private to the driver. */
void *_virtual, /* Virtual (mapped) address. */
- vm_offset_t _physical, /* Physical address of virtual. */
off_t _offset, /* Byte-offset to write at. */
size_t _length); /* Number of bytes to dump. */
typedef int dumper_start_t(struct dumperinfo *di, void *key, uint32_t keysize);