From nobody Wed Mar 23 16:44:23 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 926831A2E4FB; Wed, 23 Mar 2022 16:44:24 +0000 (UTC) (envelope-from alf.siciliano@gmail.com) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KNvMX3M3xz59Gg; Wed, 23 Mar 2022 16:44:24 +0000 (UTC) (envelope-from alf.siciliano@gmail.com) Received: by mail-ed1-x534.google.com with SMTP id u26so2518570eda.12; Wed, 23 Mar 2022 09:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BDahrrVSTlFRLGuu2wj1QvjvvTA25dDcIIpRnp2V9yk=; b=RkuduIWl2fnrfyqYlZkTUQ/w1rJCip3jmbUQZ1VXgQJuPtIZQXVT5XjgNBdvnt2AAg ZgnWN7O5Wo4WRXtM5MMUSpv67f8ePYkrBm1h0PL/ashpPK13w+spyvMFJ0b3S7fhjvdy KiLQcROCe47TYByeMNDAorH6ppEpmarYVGe1OWKxi/tM066OxmhwEy/N3lCEBAbS8cVv Vf3jMkkkC8CB5NtgbK83yned86M1JwuD/CXn8ztk99xIpGEl3+wQjQoD3hc7ixzmGhIg pSKE4GNa4/e4l/P1vFvGUlx3qnY2ztb3qGs7DIpnhpSDcScqr/BNA+gx/HpDhTRWPutz 4ZXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BDahrrVSTlFRLGuu2wj1QvjvvTA25dDcIIpRnp2V9yk=; b=TxCGd+3TKxSBYzRYWt0ZPC/xysBmr3iD2IzGYKqnWAapZ5KOpkM9mBah58x2JEsCyN AcxJ6t5gntEwDPw9PZUn3xYJm9r7P/hntJzbcqxeCgxmwm6qHnm4IGDPIWLh6S0FS4Oz 4Xiq+t7XgCHH2+W0Qxt9zXHWfhkgZK/O68iKtBnF/xWmX1s/qQNJLxAXJT7qPRJZllTY d4/K4Ax+Yj+nIATrFMZ49E1VahxgnlGUEZksCDk00JhoXR9EFEWp1+NX2Ia7qS69O4MS lFbakClUBs1dWL4Zia0JUZyxPqLl2w+f4K7WAViyidXHoGUnf4ybh/kDoYHNZ00p83+M dZ6A== X-Gm-Message-State: AOAM531IEYU62qqGVvJW6sa6IYhtgpTeKQCHRaEdhxN/2ysdCZ61sDm0 gbfbnWHIrMg0z37KTDPL/5Jf2mkoY9ZWpw== X-Google-Smtp-Source: ABdhPJxywgnkaVIzPH5GlcGKcArIF3xTHfYus5u8BjCsbp1JKXZwqxZYt+fK18Quq/y2JArLjjyIpA== X-Received: by 2002:a05:6402:430d:b0:419:45cd:7ab1 with SMTP id m13-20020a056402430d00b0041945cd7ab1mr1176409edc.367.1648053863425; Wed, 23 Mar 2022 09:44:23 -0700 (PDT) Received: from alfixbsd.homenet.telecomitalia.it (host-95-252-128-186.retail.telecomitalia.it. [95.252.128.186]) by smtp.gmail.com with ESMTPSA id l2-20020aa7cac2000000b003f9b3ac68d6sm214550edt.15.2022.03.23.09.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 09:44:22 -0700 (PDT) Date: Wed, 23 Mar 2022 17:44:23 +0100 From: "Alfonso S. Siciliano" To: Jessica Clarke Cc: "Alfonso S. Siciliano" , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 0e5c72c3cc54 - main - bsdinstall time: Replace dialog with bsddialog Message-Id: <20220323174423.ae4d8730ba9fb057f94c7dd5@gmail.com> In-Reply-To: <535DB523-150D-4663-934E-174AA639FB54@freebsd.org> References: <202203231557.22NFv7Ro095912@gitrepo.freebsd.org> <535DB523-150D-4663-934E-174AA639FB54@freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4KNvMX3M3xz59Gg X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, 23 Mar 2022 16:01:04 +0000 Jessica Clarke wrote: Thank you for the report, > > bsdinstall time: Replace dialog with bsddialog > > > > Replace (LGPL) dialog utility with (BSD-2-Clause) bsddialog utility, > > 'dialog --calendar' is replaced by 'bsddialog --datebox' with same > > features but different User Interface. > > Different in what way?.. dialog --calendar draws a calendar (similar to cal(1) output) while bsddialog --datebox draws 3 forms "multi-selection" to choose yy/mm/dd, options and output are the same (at least for the needs of bsdinstall). To try with a recent CURRENT: % dialog --calendar test 0 0 % bsddialog --datebox test 0 0 Do you or some BASE-component need a perfect --calendar UI implementation? If yes, what is the priority? > > # Set date > > exec 3>&1 > > -DATE=$(dialog --backtitle 'FreeBSD Installer' \ > > - --title 'Time & Date' \ > > +DATE=$(bsddialog --backtitle 'FreeBSD Installer' \ > > + --title ' Date ' \ > > Why do these both have spaces around them? I honestly forgot if it is a typo or a choice (I like it). However, I checked you are right: all other titles have not spaces around so I'll open a new review to fix. Alfonso -- Alfonso S. Siciliano