From nobody Mon Mar 07 20:06:16 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1076E1A01135; Mon, 7 Mar 2022 20:06:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KC8br64NGz3jrD; Mon, 7 Mar 2022 20:06:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646683576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S6eNBfBYBVNpzHY8WDBx9Ak3BxFaak5PSZM202q0vwQ=; b=BkwO6JlfYgDntvsm+9qymdT8j7bGeDKoMV2WMYcQS3aFh6EC4iyKJhqxXXUXXylxuuY91X 8xtXF6EVcObAnDP8j2alb22x2yAIvvebqaf//zGjzALKC+XvROWedunRgQ++MPx8Be/5ds Rl9S2tskO7ZGenxYVA8/xJwQ3prR7svfp0R4tpp1Xiay15w9HcCyU8a/PlgvNaJSx75quw WYQtmDI1x4Kwygx+rgo2a8NYYAnrlBtMckgQsjUNcPEQ5+i3zrMK9wZteJh3eV9oaef3pB zxxLo+VtGeDaEtfI/sDu9mGGtyflgLIkkLevi2gYAgZ5ED0j45gDHW63XWIsBg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8CB5F714D; Mon, 7 Mar 2022 20:06:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 227K6GVU025089; Mon, 7 Mar 2022 20:06:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 227K6G8A025088; Mon, 7 Mar 2022 20:06:16 GMT (envelope-from git) Date: Mon, 7 Mar 2022 20:06:16 GMT Message-Id: <202203072006.227K6G8A025088@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 9282f04ff0ee - main - cxgbe(4): dump_devlog should never fail silently. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9282f04ff0ee89cc4064e510f7fa505cfc890bf0 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646683576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S6eNBfBYBVNpzHY8WDBx9Ak3BxFaak5PSZM202q0vwQ=; b=OSpbc90r1s3X+dRtbb1TV0FX6qAwlKu5Iyf/vO7XUKgqxVBvzGldq9BFlpSHxr42YqKH9W li0eX3WjVVhnOL1o807YFv9AJhrGMDPWTqNIBhlMHcaAPTu0SmEmTeOrdkPEU42aSqFgdX 1mI0gozFRS1BPzFVaZz28FcpXdy4DCpRDcAkaUmJOdug55JaUYeHmUwa1E36htGznacnT/ /DcFh9NfeuVGeZgTJ3Tb9lANjXvI0U95EhioHu15kEVKx0iTp32t8OvGu4TyinS6AfRsOZ agLu7f6b7mwZkLvoRk6F5Tk/GXtthfhnV9Wa+9Osc3sSmro8IlLwrpuY0FrX/w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646683576; a=rsa-sha256; cv=none; b=U3a0LTfNXsnfZ7kwDMcCyXOZvyZPAg1kLsAdsuz848LY+rDwnRagnL7MDL1bCBRQumBMRR /2G8aD6vR7pruo2K+sAG7pXkpY6aLB1O5XMYqGkx/WDj9ca2nf7c368gZAAQOhZejlRg+I nDA2NNqEfYQtD6NyyDoH2cLs7dWP9COYLpab2GKhE+38BSXWJNcH1pZSx9zC+d0dQJ2/ge mnHcs4/lJnSURhNyt0c6SDZDhXAIT/l+f780FMFTKUdmWbuhmYstNDswrvy9KRKK3079E0 x8rtWzlHFFyjsIYJ5hKQSk9EAw2w4aRx+ZA8pGs8J1m9ztritcrPM8Nhg2pZyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=9282f04ff0ee89cc4064e510f7fa505cfc890bf0 commit 9282f04ff0ee89cc4064e510f7fa505cfc890bf0 Author: Navdeep Parhar AuthorDate: 2022-03-07 19:17:05 +0000 Commit: Navdeep Parhar CommitDate: 2022-03-07 20:05:48 +0000 cxgbe(4): dump_devlog should never fail silently. Do the same thing as dump_cimla and log a warning on failure. MFC after: 3 days Sponsored by: Chelsio Communications --- sys/dev/cxgbe/t4_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index dafbdfede158..59da0acc6c86 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -9447,8 +9447,11 @@ dump_devlog(struct adapter *sc) int rc; struct sbuf sb; - if (sbuf_new(&sb, NULL, 4096, SBUF_AUTOEXTEND) != &sb) + if (sbuf_new(&sb, NULL, 4096, SBUF_AUTOEXTEND) != &sb) { + log(LOG_DEBUG, "%s: failed to generate devlog dump.\n", + device_get_nameunit(sc->dev)); return; + } rc = sbuf_devlog(sc, &sb, M_NOWAIT); if (rc == 0) { rc = sbuf_finish(&sb);