From nobody Mon Mar 07 19:14:21 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8203D19F03B1 for ; Mon, 7 Mar 2022 19:14:31 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KC7S65Jwjz4sd1 for ; Mon, 7 Mar 2022 19:14:30 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f44.google.com with SMTP id q14so9359898wrc.4 for ; Mon, 07 Mar 2022 11:14:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=dOs011bBG4/3lOGetnLQFLRaYrbpuPj3OWsrPnDZCcg=; b=Jr9ni7pMiluCuDYcpAy7jtm+BYSvVj1yIeJuwg92UHp8cuvpkAtQ09w5Max7O8MJof uYCqYOOBWDc9Ga9Z1++CmtbMZrbPloPs/XodJjbheSRWrmnHprNeAkoc9ILnGuRJ/9dv DMfkBT6qKjAJwOltU8jeIfjKOiP2t/KjyGrUbEAOc8TpL1NQFtqQ4c7z2cMwuN36tulY LmZJ+793HCeTzV2vEzXXEJmxYm0bEJ89922+FtsTZ9cQBUUD0QUZ/Gb5MTOuAd2/nDp9 pbpGDES0dsb9PPYUHUI5I3Z4MTRe4zdWMCTaR1NlG0q9x6hFoDTxpB2MYqK/hh13pCS/ MgqQ== X-Gm-Message-State: AOAM530gkqdJho7cD7QDZXMjxniPDKaQUeZhT7Iw1Lm0dI3JTjihSye8 cYlGTlXeYtXa7rcErgZ8Gv6fYQ== X-Google-Smtp-Source: ABdhPJwkhAjo+DK1Mjpt5geVPvMN371gIeSL972NJKnx/sRYyHTM5F2lBN6EgGO3dae2NmRcv7jxow== X-Received: by 2002:adf:f903:0:b0:1f0:2348:82c6 with SMTP id b3-20020adff903000000b001f0234882c6mr9206148wrr.509.1646680462937; Mon, 07 Mar 2022 11:14:22 -0800 (PST) Received: from smtpclient.apple (global-5-141.nat-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id g6-20020a5d5406000000b001f049726044sm12073694wrv.79.2022.03.07.11.14.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Mar 2022 11:14:22 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: git: 3fe1f21fb364 - main - ctf: Avoid passing a caddr_t to roundup2() From: Jessica Clarke In-Reply-To: Date: Mon, 7 Mar 2022 19:14:21 +0000 Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <202203071621.227GL47F099339@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Rspamd-Queue-Id: 4KC7S65Jwjz4sd1 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-2.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[jrtc27]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.44:from]; MLMMJ_DEST(0.00)[dev-commits-src-main]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.44:from]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 7 Mar 2022, at 19:09, Mark Johnston wrote: >=20 > On Mon, Mar 07, 2022 at 11:04:51AM -0800, John Baldwin wrote: >> On 3/7/22 8:21 AM, Mark Johnston wrote: >>> The branch main has been updated by markj: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D3fe1f21fb364e38f2bf7e7100dad59b0= 67b27080 >>>=20 >>> commit 3fe1f21fb364e38f2bf7e7100dad59b067b27080 >>> Author: Mark Johnston >>> AuthorDate: 2022-03-07 16:18:40 +0000 >>> Commit: Mark Johnston >>> CommitDate: 2022-03-07 16:20:57 +0000 >>>=20 >>> ctf: Avoid passing a caddr_t to roundup2() >>>=20 >>> For some reason I can't reproduce this locally, but Jenkins = complains. >>>=20 >>> Reported by: Jenkins >>> Fixes: bdf290cd3e1a ("ctf: Add v3 support to CTF tools, = ctf{convert,dump,merge}") >>=20 >> Odd, do you have a copy of the warning/error you got (and which = compiler and arch?) >=20 > /usr/src/cddl/contrib/opensolaris/tools/ctf/cvt/ctf.c:1336:11: error: = invalid operands to binary expression ('caddr_t' (aka 'char *') and = 'int') > dptr =3D roundup2(dptr, 4); > ^~~~~~~~~~~~~~~~~ > /usr/include/sys/param.h:310:38: note: expanded from macro 'roundup2' > #define roundup2(x, y) (((x)+((y)-1))&(~((y)-1))) /* if y is powers = of two */ > ~~~~~~~~~~~~~^~~~~~~~~~~ >=20 > I'm not sure which compiler was in use. All platforms failed. >=20 > I later tried building world in a 13.0-RELEASE amd64 jail, and that > reproduced the failure. So maybe the version of LLVM shipped there > (11.0) is more picky? 8fa6abb6f4f6 ("Expose clang's alignment builtins and use them for roundup2/rounddown2=E2=80=9D) is in main and MFC=E2=80=99ed stable/13 = but not releng/13.0 so any native tool builds on FreeBSD versions prior to that need the cast to work. Linux and macOS builds work because we always use the in-tree compatibility headers for native tools, it=E2=80=99s = just older FreeBSD hosts, and world itself is of course always built against the in-tree headers rather than the host=E2=80=99s, regardless of OS. Jess