From nobody Fri Jun 24 07:47:02 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 75FF686775B; Fri, 24 Jun 2022 08:16:13 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from www541.your-server.de (www541.your-server.de [213.133.107.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4LTqhF2ZZ4z3CKP; Fri, 24 Jun 2022 08:16:13 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from sslproxy02.your-server.de ([78.47.166.47]) by www541.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o4e1v-0003mQ-L5; Fri, 24 Jun 2022 09:47:03 +0200 Received: from [188.167.171.2] (helo=[10.0.9.122]) by sslproxy02.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4e1v-000AbY-Cr; Fri, 24 Jun 2022 09:47:03 +0200 Message-ID: <5355e541-92ad-450d-775b-55864e7d027a@FreeBSD.org> Date: Fri, 24 Jun 2022 09:47:02 +0200 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: git: 1f1e2261e341 - main - zfs: merge openzfs/zfs@deb121309 Content-Language: en-US To: Larry Rosenman , Toomas Soome Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <24C76098-AF51-4A52-8FAB-619ADE555089@me.com> <44f5429842ad6f2812850df4bc189441@lerctr.org> <459e5870f8bc526a2ebd83c0592de99a@lerctr.org> <12B81E9D-515A-41E6-AB34-76EF31106F9F@me.com> From: Martin Matuska In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated-Sender: martin@matuska.de X-Virus-Scanned: Clear (ClamAV 0.103.6/26581/Thu Jun 23 10:07:07 2022) X-Rspamd-Queue-Id: 4LTqhF2ZZ4z3CKP X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N Blake3 support needs to be integrated into the boot code anyway. We may need a "compact" implementation in sys/cddl/boot/zfs/ stand/libsa/zfs/zfsimpl.c sys/cddl/boot/zfs/zfssubr.c Cheers, mm On 23. 6. 2022 20:44, Larry Rosenman wrote: > On 06/23/2022 1:43 pm, Toomas Soome wrote: >>> On 23. Jun 2022, at 21:41, Larry Rosenman wrote: >>> >>> On 06/23/2022 1:39 pm, Toomas Soome wrote: >>>>> On 23. Jun 2022, at 21:10, Larry Rosenman wrote: >>>>> On 06/23/2022 1:02 pm, Toomas Soome wrote: >>>>>>> On 23. Jun 2022, at 20:58, Larry Rosenman wrote: >>>>>>> On 06/23/2022 10:50 am, Martin Matuska wrote: >>>>>>>> The branch main has been updated by mm: >>>>>>>> URL: >>>>>>>> https://cgit.FreeBSD.org/src/commit/?id=1f1e2261e341e6ca6862f82261066ef1705f0a7a >>>>>>>> >>>>>>>> commit 1f1e2261e341e6ca6862f82261066ef1705f0a7a >>>>>>>> Merge: a320e9dd51e6 deb1213098e2 >>>>>>>> Author:     Martin Matuska >>>>>>>> AuthorDate: 2022-06-23 15:47:42 +0000 >>>>>>>> Commit:     Martin Matuska >>>>>>>> CommitDate: 2022-06-23 15:49:33 +0000 >>>>>>>>  zfs: merge openzfs/zfs@deb121309 >>>>>>>>  Notable upstream pull request merges: >>>>>>>>    #12918 Introduce BLAKE3 checksums as an OpenZFS feature >>>>>>>>    #13553 Reduce ZIO io_lock contention on sorted scrub >>>>>>>>    #13537 Improve sorted scan memory accounting >>>>>>>>    #13540 AVL: Remove obsolete branching optimizations >>>>>>>>    #13563 FreeBSD: Improve crypto_dispatch() handling >>>>>>> Can we get this feature added to gptzfsboot/loader.efi/et al so >>>>>>> we can boot from a pool >>>>>>> with this feature turned on? >>>>>>> zroot  feature@blake3 disabled                       local >>>>>> I think so. >>>>>> Rgds, >>>>>> Toomas >>>>>>> -- >>>>>>> Larry Rosenman http://www.lerctr.org/~ler >>>>>>> Phone: +1 214-642-9640                 E-Mail: ler@lerctr.org >>>>>>> US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 >>>>> Can we also make it POLICY that if you are adding features to ZFS >>>>> that that boot code (loader.efi/gptzfsboot/et al) >>>>> MUST be updated in the same commit that adds the feature? >>>> Not sure that is always desirable. However, there is alternate >>>> mechanism in OpenZFS for such cases, that should be used (see >>>> zpool-features(7)). >>>> rgds, >>>> toomas >>> What case in zpool-features(7) are you referring to here? >>> >> >> Compatibility feature sets. >> >> rgds, >> toomas > > How does that help here? And PREVENTING foot-shooting?