From nobody Thu Jun 23 19:08:55 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 306618649A7; Thu, 23 Jun 2022 19:09:04 +0000 (UTC) (envelope-from mhorne063@gmail.com) Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LTVCz1sc6z3vqJ; Thu, 23 Jun 2022 19:09:03 +0000 (UTC) (envelope-from mhorne063@gmail.com) Received: by mail-qv1-f46.google.com with SMTP id n15so1229609qvh.12; Thu, 23 Jun 2022 12:09:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=XBtZM6Yb0m7mID8w7kqPaUh3ov+RZ/lQ+hIXO66qq1g=; b=v5XYdBkOVhNp/+nLQ7yqbp58dEmGs4jkvLZTPYVxui3wZRaGrI+uiKsQEXzAQdE+bn Er1ZQw4OLMJdB4XwvAtetD2iVR5Zf9jhc0r9c2yvloLbC1jn/BL2BsqCrh5xCjik20H9 +OkEy0NbPERsJW8NA71cmHoPmYG1KsZjJoAFyy0kPFUT0MtTgWy72/FGirUCngeeFUfA uvPrjttXmPHeuZ9v8KHjeVaehZovdDTnxXx8xgDi4D6rOVmCGcYrjBUY7T8PiJSggyET 9A6f8l7+hA73AiPjzHUOJq7ZfiPUQYBb5lB3cMQMTNWj+XvSgDZJ6Gw3qSTDXPQndyDY Nlaw== X-Gm-Message-State: AJIora95tU3vkUfTbkMiLdt3nsn36vqepA1JZq4A2e5EyTT2K+zl4QvX CdVKQz2PIoFir4yRjavbmSd69BKe44A= X-Google-Smtp-Source: AGRyM1sesFU0jlY8rUoGu65z2Hh4JAumhQ0i82MKTj6YdNwxSXyXUMEGJLiPch4ystuZOU+nNp1p4Q== X-Received: by 2002:ac8:580c:0:b0:305:1e2a:dcc7 with SMTP id g12-20020ac8580c000000b003051e2adcc7mr9532443qtg.128.1656011337149; Thu, 23 Jun 2022 12:08:57 -0700 (PDT) Received: from [192.168.1.106] (host-173-212-68-18.public.eastlink.ca. [173.212.68.18]) by smtp.gmail.com with ESMTPSA id az17-20020a05620a171100b0069fc13ce235sm221867qkb.102.2022.06.23.12.08.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jun 2022 12:08:56 -0700 (PDT) Message-ID: <930b6109-191c-5fd4-70d6-2330cfd62adf@freebsd.org> Date: Thu, 23 Jun 2022 16:08:55 -0300 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: git: 36a8572ee8f5 - main - bus_if: provide a default null rescan method Content-Language: en-CA From: Mitchell Horne To: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202206231816.25NIG5aL014878@gitrepo.freebsd.org> <04bd822f-5edc-56e0-c45f-1f3d88a421d7@FreeBSD.org> <0969015a-c843-5dfc-f967-87c5f693c70f@freebsd.org> In-Reply-To: <0969015a-c843-5dfc-f967-87c5f693c70f@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4LTVCz1sc6z3vqJ X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mhorne063@gmail.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=mhorne063@gmail.com X-Spamd-Result: default: False [-0.98 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; ARC_NA(0.00)[]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-0.84)[-0.838]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-0.97)[-0.969]; NEURAL_SPAM_SHORT(0.83)[0.827]; RCVD_IN_DNSWL_NONE(0.00)[209.85.219.46:from]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FORGED_SENDER(0.30)[mhorne@freebsd.org,mhorne063@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.219.46:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[mhorne@freebsd.org,mhorne063@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com] X-ThisMailContainsUnwantedMimeParts: N On 6/23/22 15:29, Mitchell Horne wrote: > On 6/23/22 15:22, John Baldwin wrote: >> On 6/23/22 11:16 AM, Mitchell Horne wrote: >>> The branch main has been updated by mhorne: >>> >>> URL: >>> https://cgit.FreeBSD.org/src/commit/?id=36a8572ee8f5db7ecb64bedc5738a363ec7cad36 >>> >>> >>> commit 36a8572ee8f5db7ecb64bedc5738a363ec7cad36 >>> Author:     Mitchell Horne >>> AuthorDate: 2022-06-21 13:29:53 +0000 >>> Commit:     Mitchell Horne >>> CommitDate: 2022-06-23 18:15:10 +0000 >>> >>>      bus_if: provide a default null rescan method >>>      There is an existing helper method in subr_bus.c, but almost no >>> drivers >>>      know to use it. It also returns the same error as an empty method, >>>      making it not very useful. Move this to bus_if.m and return a more >>>      sensible error code. >>>      This gives a slightly more meaningful error message when attempting >>>      'devctl rescan' on buses and devices alike: >>>        "Device not configured" --> "Operation not supported by device" >>>      Reviewed by:    imp >>>      MFC after:      1 week >>>      Sponsored by:   The FreeBSD Foundation >>>      Differential Revision:  https://reviews.freebsd.org/D35501 >> >> The cardbus.c and ofw_pcibus.c changes are bugs.  These drivers >> inherit from >> the PCI bus so inherit the PCI bus method by default.  The null rescan >> was on >> purpose as an override of the inherited method. >> >> I'm fine with changing the default to bus_null_rescan, but the method >> needs to >> stay so that subclasses of bus drivers can override it back to null. >> > > I see, understood. I will revert this portion of the patch in a few > minutes. > > Mitchell Should be fixed by 29afffb942b1, but please have a second look. And thanks! Mitchell