From nobody Thu Jun 23 18:29:02 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8D83B85BB91; Thu, 23 Jun 2022 18:29:03 +0000 (UTC) (envelope-from mhorne@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LTTKq3RhKz3m37; Thu, 23 Jun 2022 18:29:03 +0000 (UTC) (envelope-from mhorne@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656008943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h8tqPFez5XZCO8xF9agHNxSJleJoxkTOA5+CzB4kLA4=; b=NOkxjDFOrnZ1i8FG2yctfLpXSoEwsuSaf7VhsJYJMp82+tyv4LLCW8eg8dF7+3N2piBlcR EoT5DMOjvui5UMCixb5cY+ZcRTKTM2lyXe0FPfLBgakNQZX2qLK6xaocaF3Q7LN+lxwYQY rZkaZGfkIa6UdT4TPqZI/Z1QJcK6oYQf7qZwsL7jFYha4sn5RsiVH93taThvb9SfGJjn1x lfB1ny0EvrcCREI4FFGladNIG33AwPY6RazjgBhZ18cgvgSQPyabx8jl6gp6MiGPJXwZrs cs3PM9JxoRXmaDF+GGPnj2EhwSIBlQ6vvBGA8m+RSGCszNg9nA+OY2+f82Nhjw== Received: from [192.168.1.106] (host-173-212-68-18.public.eastlink.ca [173.212.68.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: mhorne) by smtp.freebsd.org (Postfix) with ESMTPSA id 2081B1505; Thu, 23 Jun 2022 18:29:03 +0000 (UTC) (envelope-from mhorne@freebsd.org) Message-ID: <0969015a-c843-5dfc-f967-87c5f693c70f@freebsd.org> Date: Thu, 23 Jun 2022 15:29:02 -0300 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: git: 36a8572ee8f5 - main - bus_if: provide a default null rescan method Content-Language: en-CA To: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202206231816.25NIG5aL014878@gitrepo.freebsd.org> <04bd822f-5edc-56e0-c45f-1f3d88a421d7@FreeBSD.org> From: Mitchell Horne In-Reply-To: <04bd822f-5edc-56e0-c45f-1f3d88a421d7@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656008943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h8tqPFez5XZCO8xF9agHNxSJleJoxkTOA5+CzB4kLA4=; b=Loj4oSlw10fmud5hn0DacnsgVuLZHZHJK6f6Dbb4tk+PZ/B0YD0muBHnuNptX5wkqGRpMr NWGeVLnd45RXK9/jLbJP2G65rPC45j6JbqJigTmZr4RT1NZJ92be9jgboizBYYrydITSlh 3kVM+EjgLBhgdcRgM1V2PhRdoRYdlfJ7mgyp5GdugS9Am4WxBgIOazVAdykyw5kKEnNma9 D9TbUeF/rlXDV5AkgPgRLN4ijwdC/xd0GBokTAnn3KmXHPN+i8WV19OJa+hncQU49uv6Zx z/nU+ijYDI1YacbOM8p6KZA1XAWvT819a9ZsAs/BpfIabIsKploIpkTcjk3Ysw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1656008943; a=rsa-sha256; cv=none; b=rjI/sXwFui1ZEBqtRletg8uIrFPqtwHrKOPEhOOYuG0tpsn56gFePuMEo7eDUrGhBYTWZz 2K2lwzMicn0iOk3MdpC3864g2PzmXY6iMhwi36g+xj25BOnLiiWXVL5/5ZcE8074fwoorr ZsI3NWI/q17rxuMIHFqe/PKrC0yswBQ5NGAP5lNVsMhAO5Rs3qfiIS+8WpTWp7Prpt6qD7 k+nKRrkpaH0n7pJvRTScNvy/OyD1zMiZFr+9o7Nw+OgsnK7+qrDS5rHFSMV5caorxt+mS2 0UFBCzlBGXX38RxLLwQW0gRf6NBYPXiZHLJmqqxlVDZ+AcXS3p0HbfLaJmshVg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 6/23/22 15:22, John Baldwin wrote: > On 6/23/22 11:16 AM, Mitchell Horne wrote: >> The branch main has been updated by mhorne: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=36a8572ee8f5db7ecb64bedc5738a363ec7cad36 >> >> >> commit 36a8572ee8f5db7ecb64bedc5738a363ec7cad36 >> Author:     Mitchell Horne >> AuthorDate: 2022-06-21 13:29:53 +0000 >> Commit:     Mitchell Horne >> CommitDate: 2022-06-23 18:15:10 +0000 >> >>      bus_if: provide a default null rescan method >>      There is an existing helper method in subr_bus.c, but almost no >> drivers >>      know to use it. It also returns the same error as an empty method, >>      making it not very useful. Move this to bus_if.m and return a more >>      sensible error code. >>      This gives a slightly more meaningful error message when attempting >>      'devctl rescan' on buses and devices alike: >>        "Device not configured" --> "Operation not supported by device" >>      Reviewed by:    imp >>      MFC after:      1 week >>      Sponsored by:   The FreeBSD Foundation >>      Differential Revision:  https://reviews.freebsd.org/D35501 > > The cardbus.c and ofw_pcibus.c changes are bugs.  These drivers inherit > from > the PCI bus so inherit the PCI bus method by default.  The null rescan > was on > purpose as an override of the inherited method. > > I'm fine with changing the default to bus_null_rescan, but the method > needs to > stay so that subclasses of bus drivers can override it back to null. > I see, understood. I will revert this portion of the patch in a few minutes. Mitchell