From nobody Thu Jul 28 13:37:47 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LtsCh6ftXz4XmZ2; Thu, 28 Jul 2022 13:37:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LtsCh68bKz3v7F; Thu, 28 Jul 2022 13:37:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd34.google.com with SMTP id o2so1376806iof.8; Thu, 28 Jul 2022 06:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=biJFJ0YO7w7PY0ziTkk67oX/otJWFpA1UfYbyimCcXU=; b=LhqAqJqpuKQ2nUQvtT8+t9VQOb1CZ9mURxCczzrYEqFXaELQZhQMXMj7ObSmELjQQk HlV8ubK1woQ5txP/tRHsiwDzGD1Ir3yVshBmQXgqEFvdomG6PDALTFwfN/1MtmuU9fKQ lOhXAi2f0VgR14vFgB1h5UfOi8dFuBkHlcRyq9RQV8Fsg6ph3Qf1Oyfu783v3PGuMI31 KKdzA0/98RzTGwaYGPvW5Am7IxE8J341lxJkZT1tnKaB/vVTxOT3G9ZHwuASDnUUoB5R PyRFCQbf70ef55PYo0M0KQ0SiUz9T4xhp3aN8LTtH4LYlxRKN1FxZbCtm894MgA4qNl7 M6nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=biJFJ0YO7w7PY0ziTkk67oX/otJWFpA1UfYbyimCcXU=; b=HPW4oNHErzdQ34kf5u7N0w3A0AfIOBRnVV5nj+KHzyLBCE8A68UUx4qpcuQW7dRXEK gw85gjwqkYxbQQ9/Ls0KCpjkbPcB6u4goOoLhmuOEawI6mqpP92lFVT52Iv5TsBOgxI8 1FpJVVEPUQPQ4V9FylXQC3hbhiZxb2cxQYiTPs1MdREd/vjGrrtmddqu/52XmOiDwhtZ zvD0eS1uw2rn0Eg11mv74i+4AgV2EPnon+obOJC1Luw+z2KQxHHXmErsAvjMQD8aPyNN /wUtV0VHFSP/sbhRTs9b2zWQUxLBtkoZEF2o4mdh49qEGqpXeOHGIgHj8yeT+WD9xmTX yppg== X-Gm-Message-State: AJIora9OezUCPgxXSLYklxjlokNBwBZYaXzn0EY8a8N1L07Jw/Yrk/PK IqNM2ZbovPP3jSUEtb+hWZ8= X-Google-Smtp-Source: AGRyM1vd06a27Tib9Jk4o8td2q4sPTpMXuhpNN69UoNEv0+xRo8yNzt7qhXo+pSW4sQGoq39/WsSdw== X-Received: by 2002:a02:6d24:0:b0:33f:7beb:6b1 with SMTP id m36-20020a026d24000000b0033f7beb06b1mr10518974jac.86.1659015471777; Thu, 28 Jul 2022 06:37:51 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id k81-20020a6bba54000000b0067c31b61f43sm378622iof.4.2022.07.28.06.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 06:37:50 -0700 (PDT) Date: Thu, 28 Jul 2022 09:37:47 -0400 From: Mark Johnston To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 78ee8d1c4cda - main - qat: Import a new Intel (R) QAT driver Message-ID: References: <202207271514.26RFE53M032558@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4LtsCh68bKz3v7F X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Thu, Jul 28, 2022 at 10:28:16AM +0300, Konstantin Belousov wrote: > On Wed, Jul 27, 2022 at 03:14:05PM +0000, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=78ee8d1c4cdad7a56dbf50f1c8ade75531ce620c > > > > commit 78ee8d1c4cdad7a56dbf50f1c8ade75531ce620c > > Author: Julian Grajkowski > > AuthorDate: 2022-07-19 08:15:34 +0000 > > Commit: Mark Johnston > > CommitDate: 2022-07-27 15:12:35 +0000 > > > > qat: Import a new Intel (R) QAT driver > > > > QAT in-tree driver ported from out-of-tree release available > > from 01.org. > > > > The driver exposes complete cryptography and data compression > > API in the kernel and integrates with Open Crypto Framework. > > Details of supported operations, devices and usage can be found > > in man and on 01.org. > > > > Patch co-authored by: Krzysztof Zdziarski > > Patch co-authored by: Michal Jaraczewski > > Patch co-authored by: Michal Gulbicki > > Patch co-authored by: Julian Grajkowski > > Patch co-authored by: Piotr Kasierski > > Patch co-authored by: Adam Czupryna > > Patch co-authored by: Konrad Zelazny > > Patch co-authored by: Katarzyna Rucinska > > Patch co-authored by: Lukasz Kolodzinski > > Patch co-authored by: Zbigniew Jedlinski > > > > Reviewed by: markj, jhb (OCF integration) > > Reviewed by: debdrup, pauamma (docs) > > Sponsored by: Intel Corporation > > Differential Revision: https://reviews.freebsd.org/D34632 > > I believe that qat_c2xxx lacks required > MODULE_DEPEND(qat_c2xxx, firmware, ...) > dependency line. I think you are right. It was missing before though, how did you notice? > I am not sure about qat since it depends on linuxkpi, but perhaps there > something similar is needed as well. Seems so, the new qat uses native firmware(9) interfaces.