From nobody Tue Jul 19 20:42:45 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LnW4F0RqHz4X1Cn; Tue, 19 Jul 2022 20:42:53 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LnW4D72Cvz3CHb; Tue, 19 Jul 2022 20:42:52 +0000 (UTC) (envelope-from gjb@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658263373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tt8J8a1tGH7+XB0PM+8W+qvV8DAqtVVd8oP/omb2Y1g=; b=W4Tz9c57268KU2ABTiafXZ1F1NxNdtej4mSz/w3nWd8pTg3XFAuDDs8g5/TaeZ/24HzfOK cUYlLfqXY/fTNFyE9iGlMXkxH2X9HnOAmdzPRt8NN+G75hRkyn00nL5nbMX/9tmJyn5sHr Nhd76TqbWV5VnMpu8urm87JwSd4GwfYKjbXcilee5T5rXHLcSIpuS3BWwSm+3m33Vxf1ce 8uluAEfsGWCgvXRmiZIZoq+4h0y8mgsabXx7MaiDr5D3JGiYoB0nL5ahhUuVmy3mh+TpUY Iw9TsbVjeZaLgMBlJ1rZgQ7Tx5DRifBYcyLTsZkcbbEj3ZdxKdd9m3c0kaSlVA== Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 47A1F18472; Tue, 19 Jul 2022 20:42:52 +0000 (UTC) (envelope-from gjb@freebsd.org) Date: Tue, 19 Jul 2022 20:42:45 +0000 From: Glen Barber To: Ed Maste Cc: "Rodney W. Grimes" , Mark Millard , Warner Losh , dev-commits-src-main@freebsd.org, "Dr. Rolf Jansen" , freebsd-arm Subject: Re: git: 1dfcff294e44 - main - release: increase IMAGE_SIZE for arm, arm64, riscv [odd alignment for SBC images] Message-ID: <20220719204245.GL30607@FreeBSD.org> References: <16906DFD-286B-4D59-9438-CA9CD9026C55@yahoo.com> <202207171708.26HH81bA062303@gndrsh.dnsmgr.net> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N5vNW3dQ2P5lHuuL" Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658263373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tt8J8a1tGH7+XB0PM+8W+qvV8DAqtVVd8oP/omb2Y1g=; b=NBQT+vhK86Shpq2hYzY3ByhJLA0t2oiRiHJ26/nYRFmxJr1fiTUcNqReRQmR0UfvZg/j0K L11u8TwH1lRHxdp0tTst9K43+CVExzDB1c9O116L7NDd+U1glfWOjjPXYzEHrnx32SNU1C fTmp7LR7cgTk/sploNdhRrnyqnGYwXLEPmFtFtbwb5KRk4jwJjSV3ySq3ncXS2hDJGp4CZ 9jGJgBnJFeDjLonETvYMbE3PssdJcqQiKBqAeznisVuZfshnKpzVCF7/BbjiaxJ4IJhOlI UA3Aaz0XWTSiVbnuW3QN0YpudYQEsU+Nz4RaF3vySoFrMSfcS49HluIimdVL2A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658263373; a=rsa-sha256; cv=none; b=VwAQm5VnUP/VJ5447RodYrm4Hr3tcm21d78ND1fYANTFAX7J/F8R1yFjUGddtIKrtcNG46 bWLgWttRXA1WXwW7oAjDvh2LYTVpjHtButuuaqhUCRSPei/bnJx3Bd6TXeGla88JdLqX1R GFuiziDtPpJE7QjWmY+n7PSKw438lFzRzIS9kvdX9S75RZdfoqcS9dxTgxV/Ma3sia6k8u oIUBAjJL4pWWUqDjmrqRWDpACdYdkxBMLtA1SxP+4X/eJtjrUD7gKxecVpD9RvvAerYSdk huuLNjFNVyaxgOWvi/nfincbd9oQMqQTFMIsDCvtfG75ML3PucjNkbdx86o6jQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --N5vNW3dQ2P5lHuuL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 19, 2022 at 04:35:36PM -0400, Ed Maste wrote: > On Sun, 17 Jul 2022 at 13:08, Rodney W. Grimes > wrote: >=20 > > Perhaps an assert for kern.geom.part.mbr.enforce_chs not > > being zero in /usr/src/release scripts is in order so that > > the builds blow up rather than produce BAD images. >=20 > This is a good interim step (before switching to mkimg). >=20 > Perhaps: >=20 > diff --git a/release/tools/arm.subr b/release/tools/arm.subr > index 77b708bca4a2..94e0ee89deaf 100644 > --- a/release/tools/arm.subr > +++ b/release/tools/arm.subr > @@ -62,6 +62,10 @@ umount_loop() { > } >=20 > arm_create_disk() { > + if [ $(sysctl -n kern.geom.part.mbr.enforce_chs) !=3D 0 ]; then > + return 1 > + fi > + > # Create the target raw file and temporary work directory. > chroot ${CHROOTDIR} gpart create -s ${PART_SCHEME} ${mddev} > if [ "${PART_SCHEME}" =3D "GPT" ]; then >=20 My concern with this is kern.geom.part.mbr.enforce_chs is always '1' on the builders, which effectively means all arm builds will fail every time. I think we need to get to the actual root of the problem here, versus applying band-aids to a shark bite. Glen --N5vNW3dQ2P5lHuuL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAmLXF0UACgkQAxRYpUeP 4pP0Xw//dXvzRH/1zx6wY1RT/2R5sGBlwnfrPdeeqH35cC7OJqWiwe3O3ZarDO1D Z7LNQmufk4vKAJZNhZQFljbCCoHUNttc4p8uycBI7FYDDDscRGiZOcVW7t2c5qEx pqR9cSOHzptBbcjlSNh8iMBy4/8uDPlmcPV4ziLkH5+tQYIjNjoCZ/9fECy4eHRP SubclHPx9e9ZKqqTd86Iry3MUdgNI8B8x032RRUPAmIzgiLo1fEhdDY/tzTrqIvj usOS+XOLRRTNNWw1oL2+thDVscsXE4cpJjZ7+5xElssUQG5upKVOg+zNnStAJmtC IodWmEb8rasyo5I3Ho/ILLo5Rw5o1jIk4cAeGhfWgP+OBviq+6SGSq83PKD4f92X zHzW+aqSDOZSZNTRwg2/nUoNVsl22IVX5G7QkNacOCcBZMZ0iLTLkRcXtOe2cVlZ 8Yp9WuJnCmZPe8J5j+x8wt6wcD93VnlCbhNfYE4+z3ZXoMVacAad5SeV5jWTX/b8 4sODcOqQsPUQwXsqby0P0+DB52G3EzneF6xTm2iFB/mVo84q6zw8qrXyw371RlG9 DxJL+x7EZSM7rZ3jutoDxEQGrdf95D4zv5GdP2qhYFMD8DVVqutbzV7twnrx2goS Bolo0Y9XbJMgg25xw8FXecJ5YxQRWtpnnLoSqIeUmq/TCcd7+zE= =izbc -----END PGP SIGNATURE----- --N5vNW3dQ2P5lHuuL--