From nobody Tue Jul 19 17:50:24 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LnRFP5JH3z4WfM2; Tue, 19 Jul 2022 17:50:33 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (heemeyer.club [195.93.173.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4LnRFN3sNlz42Kw; Tue, 19 Jul 2022 17:50:32 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (localhost [127.0.0.1]) by heemeyer.club (8.17.1/8.16.1) with ESMTP id 26JHoO19078526; Tue, 19 Jul 2022 20:50:24 +0300 (MSK) (envelope-from dchagin@heemeyer.club) Received: (from dchagin@localhost) by heemeyer.club (8.17.1/8.16.1/Submit) id 26JHoOXW078525; Tue, 19 Jul 2022 20:50:24 +0300 (MSK) (envelope-from dchagin) Date: Tue, 19 Jul 2022 20:50:24 +0300 From: Dmitry Chagin To: Konstantin Belousov Cc: Dmitry Chagin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: fc90f3a28145 - main - ktrace: Increase precision of timestamps. Message-ID: References: <202207160950.26G9o2AZ034355@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4LnRFN3sNlz42Kw X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of dchagin@heemeyer.club has no SPF policy when checking 195.93.173.158) smtp.mailfrom=dchagin@heemeyer.club X-Spamd-Result: default: False [-2.10 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FREEMAIL_TO(0.00)[gmail.com]; R_SPF_NA(0.00)[no SPF record]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:61400, ipnet:195.93.173.0/24, country:RU]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_LAST(0.00)[]; FREEFALL_USER(0.00)[dchagin]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; DMARC_NA(0.00)[heemeyer.club]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mon, Jul 18, 2022 at 03:09:29PM +0300, Konstantin Belousov wrote: > On Mon, Jul 18, 2022 at 02:11:40PM +0300, Dmitry Chagin wrote: > > On Mon, Jul 18, 2022 at 01:07:24PM +0300, Konstantin Belousov wrote: > > > On Sun, Jul 17, 2022 at 09:27:09PM +0300, Dmitry Chagin wrote: > > > > On Sat, Jul 16, 2022 at 04:52:28PM +0300, Konstantin Belousov wrote: > > > > > On Sat, Jul 16, 2022 at 09:50:02AM +0000, Dmitry Chagin wrote: > > > > > > The branch main has been updated by dchagin: > > > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=fc90f3a28145872afb7106d391bc922572eb2b71 > > > > > > > > > > > > commit fc90f3a28145872afb7106d391bc922572eb2b71 > > > > > > Author: Dmitry Chagin > > > > > > AuthorDate: 2022-07-16 09:46:12 +0000 > > > > > > Commit: Dmitry Chagin > > > > > > CommitDate: 2022-07-16 09:46:12 +0000 > > > > > > > > > > > > ktrace: Increase precision of timestamps. > > > > > > > > > > > > Replace struct timeval in header with struct timespec. > > > > > > To differentiate header formats, add a new KTR_VERSIONED flag > > > > > > set in the header type field similar to the existing KTRDROP flag. > > > > > > > > > > > > To make it easier to extend ktrace headers in the future, > > > > > > extend the existing header with a version field (version 0 is > > > > > > reserved for older records without KTR_VERSIONED) as well as > > > > > > new fields holding the thread ID and CPU ID. > > > > > It would be nice to have a way to force kernel to write v0 format. > > > > > > > > > > For instance, one of my usual work flow case is to generate ktrace.out > > > > > on HEAD and kdump it on stable/13. > > > > I can merge it into the stable/13 tomorrow as it is on my stable/13 prod > > > > for a long time. And inot the stable/12 +-two week. will that work for > > > > you? > > > > > > I think that this change is not acceptable for stable/12, due to ABI > > > stability guarantees. I am not sure that it is acceptable for stable/13 > > > as well, but there we could have a discussion about long-term viability > > > of the branch. > > > > > > Can you make at least the kdump changes merged (and some modified header > > > files merge as well), so both formats can be parsed by kdump(1)? > > > > yeah, I understand. can we rely on a ktrace p_osrel? > > I am not sure I follow. How a process p_osrel is relevant there? I mean something like this: https://reviews.freebsd.org/D35851 > > What I said is that you could, for instance, only merge _kdump_ changes, > to teach it how to interpret both old and new formats, while leaving > stable/13 kernel to generate old format.