From nobody Sat Jul 16 21:16:32 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LlgyV46xrz4TLlQ; Sat, 16 Jul 2022 21:16:34 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail.karels.net (mail.karels.net [216.160.39.52]) by mx1.freebsd.org (Postfix) with ESMTP id 4LlgyV1fTHz3G52; Sat, 16 Jul 2022 21:16:34 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail.karels.net (localhost [127.0.0.1]) by mail.karels.net (8.16.1/8.16.1) with ESMTP id 26GLGXEU080446; Sat, 16 Jul 2022 16:16:33 -0500 (CDT) (envelope-from mike@karels.net) Received: from [10.0.2.130] ([10.0.1.1]) by mail.karels.net with ESMTPSA id 1XqhD7Eq02I8OgEA4+wvSQ (envelope-from ); Sat, 16 Jul 2022 16:16:33 -0500 From: Mike Karels To: Gleb Smirnoff Cc: Mateusz Guzik , Mike Karels , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: efe58855f3ea - main - IPv4: experimental changes to allow net 0/8, 240/4, part of 127/8 Date: Sat, 16 Jul 2022 16:16:32 -0500 X-Mailer: MailMate (1.14r5895) Message-ID: <7514B679-43E5-484D-8E3D-5BF3D81DFD37@karels.net> In-Reply-To: References: <202207131449.26DEnh0G089612@gitrepo.freebsd.org> <90326A36-85E7-49E7-944A-AED1EEC4C46B@karels.net> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4LlgyV1fTHz3G52 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 16 Jul 2022, at 13:46, Gleb Smirnoff wrote: > On Sat, Jul 16, 2022 at 10:13:46AM -0500, Mike Karels wrote: > M> > This cause LINT-NOIP builds to fail: > M> > ld: error: undefined symbol: vnet_entry_in_loopback_mask > M> >>>> referenced by ib_cma.c > M> >>>> ib_cma.o:(rdma_destroy_id) > M> >>>> referenced by ib_cma.c > M> >>>> ib_cma.o:(rdma_resolve_addr) > M> >>>> referenced by ib_cma.c > M> >>>> ib_cma.o:(rdma_bind_addr) > M> >>>> referenced 11 more times > M> > M> Yuck. The Infiniband code isn=E2=80=99t ifdefed for INET (or INET6)= and just > M> uses things. One of its Linux compat shims uses IN_LOOPBACK, which = now > M> refers to a mask field via VNET. I can either add one #ifdef INET t= o > M> ib_cma.c, or remove OFED from LINT-NOIP. I suppose I should add the= > M> #ifdef; any other opinions? > > I think the right thing to do will be to add ifdefs to cma_loopback_add= r(). > > The beginning of the file should be augmented with including opt_inet.h= > and opt_inet6.h, too. Review https://reviews.freebsd.org/D35835. Mike > -- = > Gleb Smirnoff