From nobody Fri Jul 15 22:26:45 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ll5Z22XYjz4Wp3v; Fri, 15 Jul 2022 22:26:50 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ll5Z138fvz4819; Fri, 15 Jul 2022 22:26:49 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x733.google.com with SMTP id b25so3919091qka.11; Fri, 15 Jul 2022 15:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4lTvwTk0Ez5G2toW7XgUX9apOvM40K0YHLecymj2We8=; b=SOoVjVltv+OpQnLlDmt11dCJxylM/PFl5tBdZWKnJ2mjeRKFMiqCuHHeOTwfkqWbKv q6U0di4bpWcitVxkdceqOosDP/UuDavE0XR33sU/zxNx4bT2jhJJqwvQ5KuhLlatM6X9 Qb9a1oVt2IvA6T8YbZ4A3HK9+FxW96ny/0RA0xDPJYJ+DZKwgR0MYKMLdbnqoiL67yiP 8fbfSA0dIGDgwMnB9Ra4ynSKzp1cRIea+05rg4y52hHo2YSfn/2MDOOj4JfWun8epcKg qQHaPOiDklopRRW3h8Ivh7YmDgB8eWsJZmpwwo51eYfNnnp3rENJRyxFTPfUxzH8BF3b 4EXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=4lTvwTk0Ez5G2toW7XgUX9apOvM40K0YHLecymj2We8=; b=kKdk8t/S48rMSW31PrPD3+oyuIUuHNw2A6D7hcaKiSfS1a0i8Nc7iRo0o/s75htT+t dyDeTa9KcoX/Lihk1o/8+8Nf+yWt96IB+vYN8/1rC0jdcDHpyI+JNcxccL82m6aI6oc2 jqDJqJnyL1Jkpmdvnng6DpAqgwijroktNgVvv5N/YPhuj3MfOVbY3cFiCNmsvgLjU68J rOVyE5zZwYzJnqycpUfTz7pab1PvS+JRMTgdbXGmdpx8GYLqR0Pp03YE9fpekSBTFnmH myMFMYzCHHqeXAA7BYJ5o99Zoj7opCWS3CUe69x4XffWuLRheR+10WmVBdfeSGK1MT6t 222w== X-Gm-Message-State: AJIora8ZfXCam215qQKaPquP4wZrxyCbA/ubvS6qsrlXEEnBXXzK1DEO 9Vc42OHCEqEhqFIqAEjboI4= X-Google-Smtp-Source: AGRyM1tVxt2Y7PxwcubnqNa9YqRLwHEZyHgLKvsOS2CcgyTjG+UZJwSQTcKMDIJnY8fHC4iJKIKndA== X-Received: by 2002:a05:620a:c4e:b0:6b2:8e49:6b3d with SMTP id u14-20020a05620a0c4e00b006b28e496b3dmr11101227qki.67.1657924008678; Fri, 15 Jul 2022 15:26:48 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a056700b006a6bb044740sm4772913qkp.66.2022.07.15.15.26.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 15:26:48 -0700 (PDT) Date: Fri, 15 Jul 2022 18:26:45 -0400 From: Mark Johnston To: Mateusz Guzik Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6cbc4ceb7aa0 - main - sched_ule: Use the correct atomic_load variant for tdq_lowpri Message-ID: References: <202207141948.26EJmIBH047696@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4Ll5Z138fvz4819 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=SOoVjVlt; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::733 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.67 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.972]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::733:from]; DMARC_NA(0.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Thu, Jul 14, 2022 at 09:50:19PM +0200, Mateusz Guzik wrote: > On 7/14/22, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=6cbc4ceb7aa0042e969be7c782436391c579cc3a > > > > commit 6cbc4ceb7aa0042e969be7c782436391c579cc3a > > Author: Mark Johnston > > AuthorDate: 2022-07-14 19:34:02 +0000 > > Commit: Mark Johnston > > CommitDate: 2022-07-14 19:34:02 +0000 > > > > sched_ule: Use the correct atomic_load variant for tdq_lowpri > > > > Reported by: tuexen > > Fixes: 11484ad8a2b0 ("sched_ule: Use explicit atomic accesses for tdq > > fields") > > --- > > sys/kern/sched_ule.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c > > index d23e43a2fbcb..14d6e689081d 100644 > > --- a/sys/kern/sched_ule.c > > +++ b/sys/kern/sched_ule.c > > @@ -1360,7 +1360,7 @@ sched_pickcpu(struct thread *td, int flags) > > * expired and it is idle, run it there. > > */ > > if (THREAD_CAN_SCHED(td, ts->ts_cpu) && > > - atomic_load_int(&tdq->tdq_lowpri) >= PRI_MIN_IDLE && > > + atomic_load_char(&tdq->tdq_lowpri) >= PRI_MIN_IDLE && > > this reminds me that someone(tm) should add type checking to these Here's an attempt at that: https://reviews.freebsd.org/D35828