Re: git: d80d73493767 - main - arp(8): use getifaddrs(3) instead of ioctl(SIOCGIFCONF)
- In reply to: Gleb Smirnoff : "git: d80d73493767 - main - arp(8): use getifaddrs(3) instead of ioctl(SIOCGIFCONF)"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 05 Jul 2022 06:13:51 UTC
05.07.2022 10:56, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d80d73493767111b7569e831a93061014c682274 > > commit d80d73493767111b7569e831a93061014c682274 > Author: KUROSAWA Takahiro <takahiro.kurosawa@gmail.com> > AuthorDate: 2022-07-05 03:56:29 +0000 > Commit: Gleb Smirnoff <glebius@FreeBSD.org> > CommitDate: 2022-07-05 03:56:29 +0000 > > arp(8): use getifaddrs(3) instead of ioctl(SIOCGIFCONF) > > The original code had used a fixed-size buffer for ioctl(SIOCGIFCONF), > that might cause the target ifreq spilled from the buffer. Use the handy > getifaddrs(3) to fix the problem. > > Reviewed by: glebius > Differential revision: https://reviews.freebsd.org/D35536 I have some production systems that suffered from this problem in the past. I used local dirty hacks to work-around the problem. Thank you very much for the fix. Please consider merge to stable branches.