From nobody Tue Jul 05 01:05:18 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 914201D12495; Tue, 5 Jul 2022 01:05:23 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LcPc334mkz4d4d; Tue, 5 Jul 2022 01:05:23 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656983123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oH63t8kVYyRCR5JeDdAQ7+sUA7qMBt+w/AsRRQhu/ic=; b=UKlLIKVh8nat9+bgCNa83+BGTpC/NQy2Pwd00chOlISMUQEZkSOUQeI2m3ZvWizyE6ljIK B7MrCRCqBCz9BtNR75M8GVO8baX6Du/XTNK2uXK0zhURqT96E3pZc9yqxfui/LB0UGG3J/ 6XYj5s6BLVy5f/wAnVlzz9gbeRy9lzg87RUeglJ8J3VO0/DYFOwuEn3rZCGnEEab0mt3wd h2mVkEp8FUWX9RIixSQOZXF/peIWuwvEeW+lQRO7ErBInV4rRYwNR9RFoLpAm++Ve3UYyv ChpGthiTemKMavmYni6aagOgZD+dl8E9Y4hs6ZKwGrabvKAq2glmXkImcnWEiw== Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 306B423D87; Tue, 5 Jul 2022 01:05:23 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id E68738D4A172; Tue, 5 Jul 2022 01:05:21 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 1FDFEE707C5; Tue, 5 Jul 2022 01:05:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id PPflfTh-1qdv; Tue, 5 Jul 2022 01:05:19 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 89119E707B6; Tue, 5 Jul 2022 01:05:19 +0000 (UTC) Date: Tue, 5 Jul 2022 01:05:18 +0000 (UTC) From: "Bjoern A. Zeeb" To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 09cdf4878c62 - main - dwc3: add more quirks and checks In-Reply-To: Message-ID: References: <202207032219.263MJdDI051040@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656983123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oH63t8kVYyRCR5JeDdAQ7+sUA7qMBt+w/AsRRQhu/ic=; b=pQLKjt/WRZJ5P/zljk2kmzAeEaqRqp8LPSmyosSa7TDzV4zjfN+J0+uvQPzCSBYzrXVjnk y4W86G78Odo3aa3+DHWfiACVc6WmhpOeN6JUSWvr0zjIw/S7qzKNHzj2vF0e9ywvKEjuGJ ha7yUsnDd2t1zSc/pBU4vdXednPTOLyWkxgcG0e/GeSocOQT95mUfrQiEsh2OTquxnRkXo +W05hGXtOB6JKtVL/TH5aRLtNBo7jy0tqxvTR4VKhDu7AxqUi+fvdCGeSLkRSUSsXxm92d /oyk3FPRYVy7e2CbljsnGvsP43E8Wfd1rFRvd1PTOtm6iUioyDLNOYeTgDgeRw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1656983123; a=rsa-sha256; cv=none; b=H/6tRG2H97wIGem/5MXAkrIIKc5MYYunC2ql95s45eTlqCOPsySIdTYCBoME9UmxqRCd5B gYClfekBrz8GRQO5HUk4AdkLLjQgKQ/dCLKALMCdhj4jkE3OQngREjGt1pXi9bzNyF9gAs AoW5/snbH+dTb8sD15DRq04yP+cQSYaW792oClixS2QY6NHQpiWsI6CGCqIy3o8dvCFwyW YbECvnU3GK+rUcbriHbE2OzMld/SepScmxdq9mEwIjEOxHLqirKpb1/KYWxmGruiRrOS+N OH3239BZmCL2TXaRECws+AJvYnImkxnLUbz/7Sgx7fKQbJNGl8+rrSM7xwDePg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Mon, 4 Jul 2022, Bjoern A. Zeeb wrote: > On Sun, 3 Jul 2022, Bjoern A. Zeeb wrote: > >> The branch main has been updated by bz: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=09cdf4878c621be4cd229fa88cdccdcdc8c101f7 >> >> commit 09cdf4878c621be4cd229fa88cdccdcdc8c101f7 >> Author: Bjoern A. Zeeb >> AuthorDate: 2022-07-02 20:56:07 +0000 >> Commit: Bjoern A. Zeeb >> CommitDate: 2022-07-03 22:17:35 +0000 >> >> dwc3: add more quirks and checks >> >> Rather than just printing the Global SNPS ID Register store it as well >> so we can do a version check later. >> In addition, for debugging purposes, read the Global Hardware Parameters >> Registers and print them. >> >> Based on the snpsid disable an XHCI feature using a quirk prepared >> in 447c418da03454a2a00bc115a69c62055a6d5272. >> Add the "snps,dis_u3_susphy_quirk" quirk and handle Suspend USB3.0 SS >> PHY >> after power-on-reset/during core initialization (suggested to be >> cleared) >> based on the DWC3_GHWPARAMS0 register. >> >> MFC after: 2 weeks >> Obtained from: an old debugging patch >> Reviewed by: mw (earlier version), mmel >> Differential Revision: https://reviews.freebsd.org/D35699 >> --- >> sys/dev/usb/controller/dwc3.c | 54 >> +++++++++++++++++++++++++++++++++++++++---- >> sys/dev/usb/controller/dwc3.h | 3 +++ >> 2 files changed, 53 insertions(+), 4 deletions(-) > > One of the changes here makes dwc3 fail now; you'll see an error about > "Controller does not support 4K page size" from xhci.c. Should be fixed by ec32fc2af52530e49d8a522ae29bf20b2e57603b . Sorry about the breakage. /bz -- Bjoern A. Zeeb r15:7