From nobody Wed Jan 26 12:31:40 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2ACD41982D09; Wed, 26 Jan 2022 12:31:44 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mail.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JkNPp2ypHz4dVs; Wed, 26 Jan 2022 12:31:42 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1643200300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sOISKj0cp2f7E4x4sKOCP7O41J/Q13yey6eApu2y9aA=; b=Dto1F2xGo/iM1nKd6TDQ8UZl/HNnSmQPU2sZaLwBQ2EZ12j4Gon8MLkB1e6J9hdQ0pWrsb /71E36MFTDe3reYncxAqfSMGN5u6YP3pbMy5O7HryhHwSkszH/sx/L++EGvBXZHi4RkKo+ 2bRoGw8Fee3Aak3VVV7CvI05vh8gKqU= Received: from amy (lfbn-idf2-1-1209-14.w90-92.abo.wanadoo.fr [90.92.34.14]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 9615dde9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 26 Jan 2022 12:31:40 +0000 (UTC) Date: Wed, 26 Jan 2022 13:31:40 +0100 From: Emmanuel Vadot To: Michael Reifenberger Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 19eaa01beaba - main - Append Keyboard Layout specified option for using VNC. Part two: Append bhyve -K option for specified keyboard layout with layout setting files every languages. Since the cmd option '-k' was used in the meantime it was changed to '-K' Message-Id: <20220126133140.3255cae69c0c0d16976dd6aa@bidouilliste.com> In-Reply-To: <202201202250.20KMoHiA013578@gitrepo.freebsd.org> References: <202201202250.20KMoHiA013578@gitrepo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4JkNPp2ypHz4dVs X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=Dto1F2xG; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-1.54 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; FREEFALL_USER(0.00)[manu]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; LONG_SUBJ(1.96)[261]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DKIM_TRACE(0.00)[bidouilliste.com:+]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Hello Michael, On Thu, 20 Jan 2022 22:50:17 GMT Michael Reifenberger wrote: > The branch main has been updated by mr: > > URL: https://cgit.FreeBSD.org/src/commit/?id=19eaa01beaba68ed4c70c44127955f5c9b331cb9 > > commit 19eaa01beaba68ed4c70c44127955f5c9b331cb9 > Author: Michael Reifenberger > AuthorDate: 2022-01-20 22:44:04 +0000 > Commit: Michael Reifenberger > CommitDate: 2022-01-20 22:49:27 +0000 > > Append Keyboard Layout specified option for using VNC. > Part two: Append bhyve -K option for specified keyboard layout > with layout setting files every languages. > Since the cmd option '-k' was used in the meantime > it was changed to '-K' > > PR: 246121 > Submitted by: koinec@yahoo.co.jp > Reviewed by: grehan@ It doesn't appears to have been accepted. > Differential Revision: https://reviews.freebsd.org/D29473 > > MFC after: 4 weeks The files aren't taggued correctly for pkgbase but I'll fix that in a bit. May I ask why this format was chosen ? How was it generated ? I'm not sure what do they contain too, is the first column the keycode and the other the ascii code ? If yes then there is at least a problem in the fr layout where the keycode for 'A'/'a' is 0x15 while in reality it's 0x14. Also the fr file have a comment that says "fr : French French Canadian (accent keys) Swiss-French", what does this means ? All three have different keyboard layout so I don't see how this should work. We also already have two (at least) keymap files installed, one for syscon and one for vt, re-using them (or modifying vt/sc and bhyve to use one keymap file) would really be better. Cheers, -- Emmanuel Vadot