Re: git: 82bfeeff10da - main - tools/portconflicts/port_conflicts_check.lua: detect port conflicts

From: Stefan Esser <se_at_FreeBSD.org>
Date: Fri, 14 Jan 2022 08:45:19 UTC
Am 14.01.22 um 00:13 schrieb Kyle Evans:
>  and runOn Thu, Jan 13, 2022 at 3:38 PM Stefan Eßer <se@freebsd.org> wrote:
>>
>> The branch main has been updated by se:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=82bfeeff10da860b1ed9f03a01f3282b42b991be
>>
>> commit 82bfeeff10da860b1ed9f03a01f3282b42b991be
>> Author:     Stefan Eßer <se@FreeBSD.org>
>> AuthorDate: 2022-01-13 21:36:09 +0000
>> Commit:     Stefan Eßer <se@FreeBSD.org>
>> CommitDate: 2022-01-13 21:36:09 +0000
>>
>>     tools/portconflicts/port_conflicts_check.lua: detect port conflicts
>>
>>     This tool can be used to detect install conflicts (ports/packages that
>>     conflict with each other because of identically named files).
>>
>>     MFC after:      3 days
>>
> 
> Hi,
> 
> Good to see more use of flua coming into the tree. :-) I recommend
> grabbing devel/lua-luacheck and running that over the file -- it's
> mostly pointing out complaints about things that should be declared
> `local`, but also notes some style-type issues and a write-only
> variable.

I know about and use luacheck for other projects, did not consider
it relevant for such a trivial script, but you are right, I should
fix the warnings, especially without global variables (which do not
cause any issues, but obviously are style violations).

Regards, STefan