From nobody Mon Jan 10 21:07:22 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9FEBA19468CB; Mon, 10 Jan 2022 21:07:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JXmcC1C8lz4V7g; Mon, 10 Jan 2022 21:07:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 053BD44FE; Mon, 10 Jan 2022 21:07:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 20AL7MqP005481; Mon, 10 Jan 2022 21:07:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 20AL7MaH005480; Mon, 10 Jan 2022 21:07:22 GMT (envelope-from git) Date: Mon, 10 Jan 2022 21:07:22 GMT Message-Id: <202201102107.20AL7MaH005480@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: cdd7fe04cb80 - main - cxgbe(4): Do not ignore the return value of ifmedia_ioctl. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cdd7fe04cb803d49a2fb6389be70f4378ae3ca3b Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641848843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UgZtW/DERL7DDFfzAf1JnMoYAF9RpE986+ADaH0aVqs=; b=D81br3FWgRBr2air3cwdGIXCHSIhCu1M3pX+BqZKIbaANVWIdnrmFseQra3elVmq7Xi3HM 75QEBjWEZBLtw07LwfFlFs354fAruHrgotAtXBxRrBbq0HJAHAbwbATqodfbrTNtsPgpRO Z+7G5jXlr1OxxfPGujFH3Aa2jB/XjLspLjwauwgr9MUfRZ+3PWMzBH3e9foMGMvupo2WWF 3PidYWAWL5HQ7VZDhsfdiLu1D2/cSSsjIq1jM3/TA8jqr5O4+/0iKx0S+QPGkrCgNnJuGn jgRiO+FhXPpqm1yHbXnsC5EkGWJqIZkBNZWVXoGfh+U1/FgzzcwhHOciO7gGtA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641848843; a=rsa-sha256; cv=none; b=fC7AmazWsV5ahwyXSav3umeam8BOTXOiBkuXajxECDUwrHjg4oJZKgjC2CA2RBkh+f8Xcd B8o++lC6kkJGrZG8DGMc1XrDK3ZOXpvoCyq2EH/aRDfNBbQrsJVWZnSaDEIsU/6HsyDPg5 DVek/DogNi0vqYXpaMHEVzmclkWVyN+R8i6Sq7tPwh9zUxfZQaNsYaQLEvL08rmDRf6MLp 2woaj0Eogt5JyNHy+oqHs8C2pHFaZOt12J43LO1TJqRc4sjD00ebHEOPfbY2ThCqWrqKsD g9foYWnjXa6+z0iNVIuDsNVCI9a6dahOo3J6k91bWGV2L/bIcbYLn7oKgenFoQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=cdd7fe04cb803d49a2fb6389be70f4378ae3ca3b commit cdd7fe04cb803d49a2fb6389be70f4378ae3ca3b Author: Navdeep Parhar AuthorDate: 2022-01-10 21:01:51 +0000 Commit: Navdeep Parhar CommitDate: 2022-01-10 21:05:01 +0000 cxgbe(4): Do not ignore the return value of ifmedia_ioctl. This ensures that the driver reports an error instead of failing silently when an invalid media is requested. Reported by: Suhas Lokesha @ Chelsio MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/t4_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index 183344099bfe..58b064e78402 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -2869,7 +2869,7 @@ fail: case SIOCSIFMEDIA: case SIOCGIFMEDIA: case SIOCGIFXMEDIA: - ifmedia_ioctl(ifp, ifr, &pi->media, cmd); + rc = ifmedia_ioctl(ifp, ifr, &pi->media, cmd); break; case SIOCGI2C: {