From nobody Sun Jan 02 17:21:28 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DCED51928E49; Sun, 2 Jan 2022 17:21:45 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JRlzY50S3z3nJS; Sun, 2 Jan 2022 17:21:45 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f179.google.com with SMTP id v6so51934996oib.13; Sun, 02 Jan 2022 09:21:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A+nWzR357NbW02E9IdMmt8i9cwclGbBTHNXkodF1SXA=; b=ddvXfQlo0JUkuPq9r+rzzsOtdcoQxwP5wQyDHHKoYH9PE54tiip/QLkg+vLsInEgkI tzu1XcAdQajN55tv15ljgatODB1Q+1+QaBEx7ZR8mLqXCwstpRof4VB3fYo6g45/N+3w C38cZtiNIUbypby7LeKyggpVJB+Tg9HYE0KDVoL3niFTXuLs2VaCGelNnNLnA8YTvZs3 iM+OZAq5kbib2UiW0dnRsAyuwrMEGZoMUOx43sNkEeOle5r0qy39S04Olr2XwJcM0uaB b6Uv7FI2owOq2Yq88dtf3xMv/D97NEeFDm9BYVLr6sFh32W6swlveI1pXTDHP0E+BBpH i2wA== X-Gm-Message-State: AOAM533N2OAHsbhEU/aSEMdFBzIWMb3cZLYlZdm9MSl+mI9V80Mst0H7 ub8bchWF/S2lYIIZ9kMVN8yZP99kVTzmfFTy+sK7MWtB X-Google-Smtp-Source: ABdhPJzWDmLk3DWotkdo2HWNn9NTGfvRWsjAWYxEFAc6tsarqJS7SDeYSGEUll5RDnX9FeN6jpX60kxx3X3B3sxWjJ0= X-Received: by 2002:a05:6808:1202:: with SMTP id a2mr33436569oil.57.1641144099323; Sun, 02 Jan 2022 09:21:39 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202112311818.1BVIIr2P048142@gitrepo.freebsd.org> In-Reply-To: From: Alan Somers Date: Sun, 2 Jan 2022 10:21:28 -0700 Message-ID: Subject: Re: git: daf481f3d508 - main - rescue: include ping iff at least one of INET & INET6 is enabled To: Gleb Smirnoff Cc: Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4JRlzY50S3z3nJS X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Sun, Jan 2, 2022 at 10:17 AM Gleb Smirnoff wrote: > > On Fri, Dec 31, 2021 at 06:18:53PM +0000, Ed Maste wrote: > E> The branch main has been updated by emaste: > E> > E> URL: https://cgit.FreeBSD.org/src/commit/?id=daf481f3d508e7497b456e8df7db17c90b623ee0 > E> > E> commit daf481f3d508e7497b456e8df7db17c90b623ee0 > E> Author: Ed Maste > E> AuthorDate: 2021-12-31 01:11:31 +0000 > E> Commit: Ed Maste > E> CommitDate: 2021-12-31 18:16:30 +0000 > E> > E> rescue: include ping iff at least one of INET & INET6 is enabled > E> > E> Ping does not build (and serves no purpose) if neither is enabled > E> (i.e., building WITHOUT_INET and WITHOUT_INET6). > E> > E> This is equvalent to a4ef9e58bc0c but for rescue/. > E> > E> PR: 260082 > E> Fixes: a4ef9e58bc0c ("sbin: build ping if at least one of...") > E> Sponsored by: The FreeBSD Foundation > > Shouldn't be ping built only with INET and ping6 with INET6? > Is there any use of ping on machine that doesn't have IPv4? > > -- > Gleb Smirnoff In 14.0-CURRENT, ping and ping6 are the same binary. However, parts of that binary are conditionally compiled by INET and INET6.