From nobody Thu Feb 10 06:46:09 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4D70419B474A for ; Thu, 10 Feb 2022 06:46:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JvS2P1d04z4vKv for ; Thu, 10 Feb 2022 06:46:21 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644475581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9taDpNgLQ1571Yj3EEckpKx1hVXvp+z6XoldC5SVY7k=; b=Gc/sMhyxoWdDrnK5MbDFTfIll3719dHRChWxSsiAVqb69OlbjDLOISTIw+4TbNam7vmAc5 4zECeJkGee19lnF5g25xzg2pZ7CtWp9TLQHMKtxFltkmoEEuR4x+C6IPEEmHR0e8agsD+v 9mDkDjq+5XbkXqL4dc2TxkyzJAQtz+aPaErINh09qKMIPqdQuO2EibMgaC1yZAtjC95W4r Xzn79hmPJ6wAO2pNlrurc2t7i5OCP3zzk0e840nL2tyTSrs6h6e6YgdX+yfE2Nui2VWdIK UgRN5AtWQEjQ1KYw4RSHte4cINoJ69FSMxuNfpNAinI/DNVCYRseuXHBenxSHQ== Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 135152CC48 for ; Thu, 10 Feb 2022 06:46:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f48.google.com with SMTP id d7so4046816qvk.2 for ; Wed, 09 Feb 2022 22:46:21 -0800 (PST) X-Gm-Message-State: AOAM533XkD6U0lQSAWwD1qMIdCpZEv0N8/KyOK7C8+uUKVqS0WBA69NC KP5Quu7WLmY3K5YpMB5xiMeUM3A3v/ylUZI/MBw= X-Received: by 2002:a05:6214:4006:: with SMTP id kd6mt1663042qvb.70.1644475580632; Wed, 09 Feb 2022 22:46:20 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202202100616.21A6Gma6048415@gitrepo.freebsd.org> In-Reply-To: <202202100616.21A6Gma6048415@gitrepo.freebsd.org> From: Kyle Evans Date: Thu, 10 Feb 2022 00:46:09 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: b9c92d631cfb - main - Annotate geom_md with MODULE_VERSION Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644475581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9taDpNgLQ1571Yj3EEckpKx1hVXvp+z6XoldC5SVY7k=; b=jpiwCcZ7CNskXW2b+hBG8YvEfm0wT0hQCnlWIpZdPsjNayL8ZkRRup14jC3w5XKPrTivX2 rBUGzN/2wlJuyK+C7gSB1LcpFnPP3X7ecJ9NjYJjuT+IwE4MNnscq6ymj2sE7Z2zH+BvRW ocpaVDLJ0PGzsEe/2mcRtuHI2H69EJLrgd/K9Mcbtw7B4dNJPVMz2yGjRoButmIG7D6ozw 73qEh9ClB9H+Ai6b4EJvfKR0y1QcjimBESZlWdXT9PwWt1vEPSWQrK1MQ9QoAsUT80o0wO upxTabrzSdwcxwNSP/ZppWuELER5dVfepxz/G86iTAlFGRjw8MUHvaPpXbmJJA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644475581; a=rsa-sha256; cv=none; b=pYKIZLrs8d7EN3lJV6AYXKOW/bVVkuPWIM4bEsJz27OU+7F5/q7UN/ugGp8iVAsYH+7vXk uOtx88nz4YddqWwWK/vYrayP9pYMbriNm4p9BHGPrEEwkcN4cNaOWu3cgpM5aJRAWswrCN O00s9f7N65oPaGsho54zGZpgXVWHXn0E4v89+C3aFrNHnq1+Jia8etynqGvoQqghNN1FTt ZscYar8P4C2vCmsrtnrfByh6AobnYwHkeAPc0JfncHCqV33r/yWKHEGcKMOSaHCkUUMosC S5GDRzI4tDjfcZuviHGM0gftX+f39Yq8uji7u4wX+bCxV7r5UZ0GdFazc8ePng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Thu, Feb 10, 2022 at 12:16 AM Kyle Evans wrote: > > The branch main has been updated by kevans: > > URL: https://cgit.FreeBSD.org/src/commit/?id=b9c92d631cfb06c12b0d2d9ad29a9f3f0b856237 > > commit b9c92d631cfb06c12b0d2d9ad29a9f3f0b856237 > Author: Kyle Evans > AuthorDate: 2022-02-10 06:15:29 +0000 > Commit: Kyle Evans > CommitDate: 2022-02-10 06:16:19 +0000 > > Annotate geom_md with MODULE_VERSION > > This was missed in 74d6c131cbe2 where other geom modules were annotated > with MODULE_VERSION. Again, the problem is the same: we can't detect > that geom_md is loaded into the kernel without it. > > This was noticed in release builds on the cluster; mdconfig attempts to > load geom_md because it can't detect it in the kernel, but the cluster > config includes md(4) and does not build the kmod. This problem would > have been masked on hosts with the kmod built, as the kmod attempts to > register the g_md module and fails. With this commit, mdconfig would > not even try to load it again. > This last sentence is wrong, of course. kldstat(2) doesn't pick up on the geom_md interface already being present, so we do still try to kldload(2) it. kldload(2) will notice the kld name conflict and kick back EEXIST like we want it to. Thanks, Kyle Evans