From nobody Tue Dec 27 17:56:32 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NhMmF0Y27z2kqPp for ; Tue, 27 Dec 2022 17:56:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NhMmD5dprz40d1 for ; Tue, 27 Dec 2022 17:56:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52c.google.com with SMTP id i15so19993843edf.2 for ; Tue, 27 Dec 2022 09:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FWQqPc9lfJQZWUV47V6lJeKKSFqsYJx6PTB0TzmKFT8=; b=nXm1U5CCm9n1yBxU1HmfNG39WV8s16FNOy68+Kjvtu5TDTVQp0+8TXgXi1gLwYHQT4 rOOsRYFOc1Nk1w/8YGSXqwsPhhQ+CP93ZOAS0xn7ZZ6fOy5Kd5g9Dzb7LgM/qkKnFgY0 Atzep/Twm6qPSQY2Ih3wQZqUAnE+XUtDRxjwE7iXgdX2sN+lTE0y4ozZ9s1qtg/R63Rw 9klOMIPvm2ZBE1b3PRbjCUVr2SXZFwbiDQ2WJnSqUVZtLVKThRnGwYBzc9J1wT74Dm06 DIpBGj5F5Td2VDlGMNec/0KW6SLykmd5t1JTRoIe7y63yzIkVs5YMNdzM7A5XU3iOVwq 30Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FWQqPc9lfJQZWUV47V6lJeKKSFqsYJx6PTB0TzmKFT8=; b=Svoy5PNb/DfpVkqXXm7DzS1BfS6YGI5YDaneLtlrdxXVVOmJs4DR53U3yN9IU8DUob mQywjxT5/9VS70BfHGNMOOUiji9mtmcySG6Ss+2gM185z9POaNK0GNPUNXR5U7AcEqz5 FxYVEO85vkdQOPHBSkQf5exgRqk49gFrHp2dEpuNke9dMhcpf42ARr2CU5B8yRuMMolQ 1BBqcsNCYY0aeenFBdBDkgy3ABoz7/Opyi/9BXcp4omh3ETkr5Jl2eKUph/FSIds0qfg y3bC6qvOYDL6rj6OfiAdIOYyZgcYQQPxxBdLuxVbmSmw08zT1d4/JBzq0moAQEM6YzFh Y/hg== X-Gm-Message-State: AFqh2krTk1OeArtbSmRpndxNNI8UnXwf8DC1n+MrYijh1M6aw/ZFVwfN hV/++7sh1ksbbgsB178YHWYhbzuK4EtQBfjCgQvlcJXIlApcsA== X-Google-Smtp-Source: AMrXdXuWDBQFmjNouzgsPUHN5D1WSPRE4+71ha8vfgBEGQ9kmj892IlsGWLZ13bFAGTn4P7yoLLarM7GNlFLrrv3bYI= X-Received: by 2002:a05:6402:1f02:b0:47f:6531:deed with SMTP id b2-20020a0564021f0200b0047f6531deedmr1589349edb.154.1672163803266; Tue, 27 Dec 2022 09:56:43 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202212251159.2BPBxmAG029954@gitrepo.freebsd.org> <5a772eb7-55c8-5e73-e346-5514ef144dc3@FreeBSD.org> In-Reply-To: <5a772eb7-55c8-5e73-e346-5514ef144dc3@FreeBSD.org> From: Warner Losh Date: Tue, 27 Dec 2022 10:56:32 -0700 Message-ID: Subject: Re: git: 526f57bf85a2 - main - Update CWARNFLAGS in bsd.sys.mk and CWARNEXTRA in kern.mk for clang 15. To: John Baldwin Cc: Dimitry Andric , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000080171605f0d2f912" X-Rspamd-Queue-Id: 4NhMmD5dprz40d1 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --00000000000080171605f0d2f912 Content-Type: text/plain; charset="UTF-8" On Tue, Dec 27, 2022 at 10:40 AM John Baldwin wrote: > On 12/25/22 3:59 AM, Dimitry Andric wrote: > > The branch main has been updated by dim: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=526f57bf85a2b9b113c55ded47b932abc8567bc5 > > > > commit 526f57bf85a2b9b113c55ded47b932abc8567bc5 > > Author: Dimitry Andric > > AuthorDate: 2022-07-25 10:29:58 +0000 > > Commit: Dimitry Andric > > CommitDate: 2022-12-25 11:58:22 +0000 > > > > Update CWARNFLAGS in bsd.sys.mk and CWARNEXTRA in kern.mk for > clang 15. > > > > MFC after: 3 days > > --- > > share/mk/bsd.sys.mk | 17 +++++++++++++++-- > > sys/conf/kern.mk | 4 ++++ > > 2 files changed, 19 insertions(+), 2 deletions(-) > > > > diff --git a/share/mk/bsd.sys.mk b/share/mk/bsd.sys.mk > > index a220c9d173ed..43359fed29c7 100644 > > --- a/share/mk/bsd.sys.mk > > +++ b/share/mk/bsd.sys.mk > > @@ -86,6 +94,11 @@ CWARNFLAGS.clang+= -Wno-unused-const-variable > > .if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} >= 130000 > > CWARNFLAGS.clang+= -Wno-error=unused-but-set-variable > > .endif > > +.if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} >= 150000 > > +CWARNFLAGS.clang+= -Wno-error=array-parameter > > I've fixed all these that GCC 12 finds. Do we really need to disable it > for clang > now after I've pushed those recent fixes? > I agree: I don't think we need this at all anymore, though we have the perennial problem of building stable on current, but this won't fix that... I think I've done a full bootstrap with clang15 on MacOS since you've imported your changes, and I didn't see this error. > > +CWARNFLAGS.clang+= -Wno-error=deprecated-non-prototype > > I'm curious how many places are broken by this and how much it would be to > fix? > This is just adding '(void)' in place of '()', yes? > I believe that only () are left in the tree, except for one, maybe two upstreams that still support old K&R compilers (I'm looking at you libz) that need this flag. I also think that the bulk of the in-tree () have been converted to (void) (I've done a bunch, and others have been quicker to commit than I for at least some of these so I got conflicts on merge,but for this, that's cool). Warner --00000000000080171605f0d2f912 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Dec 27, 2022 at 10:40 AM John= Baldwin <jhb@freebsd.org> wro= te:
On 12/25/22 = 3:59 AM, Dimitry Andric wrote:
> The branch main has been updated by dim:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3D526f57bf85a2b9b113c55ded47b932abc8567bc5<= /a>
>
> commit 526f57bf85a2b9b113c55ded47b932abc8567bc5
> Author:=C2=A0 =C2=A0 =C2=A0Dimitry Andric <dim@FreeBSD.org>
> AuthorDate: 2022-07-25 10:29:58 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Dimitry Andric <dim@FreeBSD.org>
> CommitDate: 2022-12-25 11:58:22 +0000
>
>=C2=A0 =C2=A0 =C2=A0 Update CWARNFLAGS in bsd.sys.mk and CWARNEXTRA in kern.mk for= clang 15.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 3 days
> ---
>=C2=A0 =C2=A0share/mk/bsd.sys.mk | 17 +++++++++++++++--
>=C2=A0 =C2=A0sys/conf/kern.mk=C2=A0 =C2=A0 |=C2=A0 4 ++++
>=C2=A0 =C2=A02 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/share/mk/bsd.sys.mk b/share/mk/bsd.sys.mk
> index a220c9d173ed..43359fed29c7 100644
> --- a/share/mk/bsd.sys.mk
> +++ b/share/mk/bsd.sys.mk
> @@ -86,6 +94,11 @@ CWARNFLAGS.clang+=3D -Wno-unused-const-variable
>=C2=A0 =C2=A0.if ${COMPILER_TYPE} =3D=3D "clang" && $= {COMPILER_VERSION} >=3D 130000
>=C2=A0 =C2=A0CWARNFLAGS.clang+=3D=C2=A0 -Wno-error=3Dunused-but-set-var= iable
>=C2=A0 =C2=A0.endif
> +.if ${COMPILER_TYPE} =3D=3D "clang" && ${COMPILER_V= ERSION} >=3D 150000
> +CWARNFLAGS.clang+=3D=C2=A0 =C2=A0-Wno-error=3Darray-parameter

I've fixed all these that GCC 12 finds.=C2=A0 Do we really need to disa= ble it for clang
now after I've pushed those recent fixes?

I agree: I don't think we need this at all anymore, though we ha= ve the perennial problem
of building stable on current, but this = won't fix that...

I think I've done a full= bootstrap with clang15 on MacOS since you've imported your
c= hanges, and I didn't see this error.
=C2=A0
> +CWARNFLAGS.clang+=3D=C2=A0 =C2=A0-Wno-error=3Ddeprecated-non-prototyp= e

I'm curious how many places are broken by this and how much it would be= to fix?
This is just adding '(void)' in place of '()', yes?

I believe that only () are left in the tree, e= xcept for one, maybe two upstreams that still
support old K&R= compilers (I'm looking at you libz) that need this flag. I also think = that
the bulk of the in-tree () have been converted to (void) (I&= #39;ve done a bunch, and others have
been quicker to commit than = I for at least some of these so I got conflicts on merge,but for
= this, that's cool).

Warner

--00000000000080171605f0d2f912--