From nobody Mon Dec 26 14:57:54 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NggrT5wrvz26WnL for ; Mon, 26 Dec 2022 14:58:01 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail.karels.net (mail.karels.net [216.160.39.52]) by mx1.freebsd.org (Postfix) with ESMTP id 4NggrT34prz4D5h; Mon, 26 Dec 2022 14:58:01 +0000 (UTC) (envelope-from mike@karels.net) Authentication-Results: mx1.freebsd.org; none Received: from mail.karels.net (localhost [127.0.0.1]) by mail.karels.net (8.16.1/8.16.1) with ESMTP id 2BQEvt79048114; Mon, 26 Dec 2022 08:57:55 -0600 (CST) (envelope-from mike@karels.net) Received: from [10.0.2.130] ([10.0.1.1]) by mail.karels.net with ESMTPSA id pSZqEHO2qWPwuwAA4+wvSQ (envelope-from ); Mon, 26 Dec 2022 08:57:55 -0600 From: Mike Karels To: Mark Millard Cc: karels@FreeBSD.org, dev-commits-src-main@freebsd.org Subject: Re: git: d670a8f7c596 - main - growfs_fstab: add new /etc/rc.d script to add swap to fstab Date: Mon, 26 Dec 2022 08:57:54 -0600 X-Mailer: MailMate (1.14r5921) Message-ID: <36A98BE4-83C7-4E23-A4B1-A761D5F22DD4@karels.net> In-Reply-To: <3F68EC4A-1D8A-409B-81D0-BECE377EFBE7@yahoo.com> References: <3F68EC4A-1D8A-409B-81D0-BECE377EFBE7.ref@yahoo.com> <3F68EC4A-1D8A-409B-81D0-BECE377EFBE7@yahoo.com> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4NggrT34prz4D5h X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:209, ipnet:216.160.36.0/22, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 25 Dec 2022, at 16:41, Mark Millard wrote: > Mike Karels wrote on > Date: Sat, 10 Dec 2022 19:41:14 UTC : > >> The branch main has been updated by karels: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd670a8f7c596fd387823644= c5cbf1ddee788eee4 >> >> commit d670a8f7c596fd387823644c5cbf1ddee788eee4 >> Author: Mike Karels >> AuthorDate: 2022-12-10 19:39:59 +0000 >> Commit: Mike Karels >> CommitDate: 2022-12-10 19:39:59 +0000 >> >> growfs_fstab: add new /etc/rc.d script to add swap to fstab >> >> The growfs_fstab script is a helper for the growfs script to add any >> new swap partition to /etc/fstab on first boot. If growfs adds a >> swap partition, it sets growfs_swap_pdev in the kenv. In this case, >> after the root file system is read/write, if there is no swap partitio= n >> in the fstab, growfs_fstab adds growfs_swap as a swap partition to the= >> fstab. Also, it runs dumpon to add the swap partition (as this >> happened earlier in the startup sequence). >> >> Discussed with: cperciva >> Differential Revision: https://reviews.freebsd.org/D37463 >> . . . > > I tried the new main [so: 14] snapshot, dd'd to a USB3 SSD and booted: > > snaphot: FreeBSD-14.0-CURRENT-arm64-aarch64-RPI-20221224-c89209c674f2-2= 59842.img > so: FreeBSD 14.0-CURRENT #0 main-n259842-c89209c674f2: Sat Dec 24 05:52= :28 UTC 2022 > > Result (from the serial console capture): > > Starting file system checks: > /dev/ufs/rootfs: FILE SYSTEM CLEAN; SKIPPING CHECKS > /dev/ufs/rootfs: clean, 599506 free (242 frags, 74908 blocks, 0.0% frag= mentation) > /etc/rc.d/growfs: 203: Syntax error: "(" unexpected (expecting "}") > > > Looks to be the ' in "Don't" in a supposed #comment that that instead m= atches a prior awk use of ' unintentionally. Later in the line is: "(deci= mal)" that supplies the "(" reported. I ran into this over the weekend too. Fixed by 4c8a257810a6. Mike