From nobody Sun Dec 25 23:44:27 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NgHZj54qZz1LjL7 for ; Sun, 25 Dec 2022 23:44:45 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic307-8.consmr.mail.gq1.yahoo.com (sonic307-8.consmr.mail.gq1.yahoo.com [98.137.64.32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4NgHZh6KZBz4NNZ for ; Sun, 25 Dec 2022 23:44:44 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=PwaUN5pK; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.32 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672011883; bh=spxbmD1S9b8K1f/qHjX3qykpeNgNfwkRLBsGw8ePmlk=; h=From:Subject:Date:References:To:In-Reply-To:From:Subject:Reply-To; b=PwaUN5pKIvSJDEIoiBVAf/pR/lHpMrStJaotYhM+4fesRLcTLkXeFqaQBnJVlp+bhbcOUId9baduoqdpkM4czVfHM4IqqhSUGxsoKzYE1FKciB01/1FvssQt4NIqm464Yhuuf5Vu7FfbHJhqZdbUavhE5ppp8DbE5F8/ghu3btrIueZiLUVlB2nQEtcdDkPKhFS0ovxwSmbzkcgsa43+MJ0lSlVmU47vPIcFGlg+Hnvn7Zv0PimcEcudEf6Hig6uI4KZfr3XfG79YMyVxP8KnwmRLUtIVHYtq0BFMx9/pEPyn8ARitcpx87AdvpqrbW2o8EVHVNwK/dJkAT+bQdl7A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1672011883; bh=RMF7UZ59MhzN4QkqaPCLyQpT82c0+qPSmRl/bLQs+Ph=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=RU74cnqTYJ9Lh0DOonfOpbI6umQtd4Wph1RC+3XzRlnplW7Let9qcGUuxBQ3MJHqHKj3uLuwKJLaKjX6QercHywxzZt4/PEgOIYCPNJ3Ln6reB24QNAeOeL34EN/CtjN43ZNjXhu+RBzLXxuEgRpQj0Ea85tXJ0OT6kFKtEFjb56ba4/Z5HsAn+PfCTVlUjiWZftJYvC5LdjixRZyM/PtAuKLXU8ckb/PhpUI/YAuRQeqaqfH3LsV479Rj7DA9laK0Z9NM3YP0LXaEHcbK4sYmU3VZ14i1qROuR/poOcTqTrUSsalsKuG/1/XpgswLqH2qMto+e3yCmDlXraPz/2gw== X-YMail-OSG: A5wvfAYVM1n8GBtLap0JRGTPaNx27Ds46dS4_H1m.vbXjDmETIzWPr2qTxqgIQb oxiKiH_Nd5QSP0MXcZoHAokmDPUnotoxjUNHv_zgXTqyAEZLGA0_SNwnO6LzV0WEWvHodv1KByew 0ubE5fsD1ZL4x5VIL1RB1DdV3z4KUmeNUuE4UO.i4hkt373KTDuQGpApa4RVXxEiD3fVS_63rAxF lY2hiCsDDyyW4y_ETQDB0FctCRhggqzNWlUfp1UbOE4XCXl_vW.pjngezp3h61UoqlE1ZHFhjs3r F2A7CK32TWZuoBIcmd7JukMHaQmcfVIGCAg1ORZxVULgSPFHE868OB.Cz0SJLm7rf3k3w1qsLEKX vmKIaa5VTgPK1ZusLmSLVzGGqcAcyHYQvh4Qk9EU4jRz4EGvOp4EnOjUYoVDu_Y.hl8W0OphZOlY ob64SU3U3ZUcThc3Lj6Sam1xZMuqOwWwqflUzdCXsUCjN0p6Wm0eZqBebT1FyE3hmEAm7vmSKddH YM4QokbL2GWfCE_ian.1VFrP_pvgkVVn7spMhGaEowTuIlUWg28UCYWc0UgNVldkNU4VuhYa8mkT E7NbTi_JMxK.8x03ZuUmdc82dEw3EVjz9iMerS_yU3A77huzOSobaOgcWAYbjSm3czZWONESJCnw aevPAVJA17m0mzswuxpf3tVkqBvcWlLg2n09_RgbKYT68ur3CH9Ot.VA7MwCfbKeKqRfNT2KbBg8 W8IuCkUkt9c8.Vj34ymna__xdbpobgHjSsuEKFBplujuJS5LeK5bzJxrb4Dzm7VpJ6Gxo6LXYPZy jup7ex96WRp2bFTVykytu572wk3tgiP2QxQ92FopFZ3AF6sfV3qcLqpqput_23M_jQYMD2rC4Zkm 07qErBo3GRR.QG4dsm20kyG8rFCRAyCFQrhPN1Gd0xmrZIuvyx_e_kdtJRxrahMRleLBSLxfb2_H nd3RA0o0lPNJa2f1PW.eaN88o7tTrt.aotGprW8rStle6wBHwZoJ1Y0nQ9zz0xtIxRzjGE_c0eGO wC9DGl4oUbloooW5vOQoMoi2mCrmkJIbUSfQjBe8jGJwV_UremhhaN2zZmAWC3QxugG8JpXj9hC7 jMlMCf87_6HL1HlTlLZiRFmJkOKjL9bf6nTKBCaPjBM6YV8txXPLU2s6YCtg.tknpE3IaCG8nw93 T8QrKSi0BTTVtVHmTuiTwDYpTphRIRTRafhH5BLvbvYcFplf4I6JJqc0WQW19dDhF6P9hkGs20ZZ kof4qrDpmgk_ZcFE1LBPM3fVQ21KnF.rzwEHkHqpILfJqBHO9Eugp6y1dASclEw7ma0B0rIEeCT4 a5Bk3vUEtfh6ak5_bLsZ2ym0KouGpiDG3vRqE6EgVe4rP86jtu2otLetiWRlfjma5uuawIGTdukr jFLaJgEosYUTCyJFeMxu8ha.pxdWnq604JUNv6bdEIwh59UkT9f4oDDW8E46pzkTXqAVGtQdIIN8 NsvRir1O.gg2rsVcIzJrQc0nIKG5fu9NWRfxlRfkzl6y5z8ft8ptJcLEZtmVxpMRK9C9xkOgXPZc _Q_vRGTY4Uvh1REi7p4eMkp.FGUfov5YFcSGaHVioKqtbgoPZq6CuC7voQCJMcAOU8_4svf1PZPx 5fr.rhc9g9T7qmbdl57N2rMP83uuR6mFGPZMB5ebh5IFR3sHnklp09BaWY1D9hAVMdls.oz2ZPVd .iEAUVLCiKa3DoUUTvVCy6Ty4KajDPVushms3OUJbh3Cb1OBpI_pPyNlfxOcmCqEM.6HlYQy7_R9 _M8IUQ0lsErUzywqADICAyQci1hcWH3ZebaxGOjJuC9aALMPbTVmQuWp6fN3e4Cd.1pn.R3v2mgP v012FLDw2n9NCweE7FuWKJqgJi_lUqFa6lHpnQkGBhEjAwXNJMTStbRRAP4HBstRDZEYGLL4kZq5 G0c57zyq5RBG1cG9KDD0XHrKvHYSqdDxBOaOyoPYpk.aMdBy_kNCmB7iP03Ut1yIqlEjn.5lpiId AZTqpkSm4EmsanXtQeDEY4aB8DxGZcILprqLugYxm.AtSX6dJJr6uSkK9wgHuHghbs5GYkL.OhA5 2sKOdG1z6uWDX.kUh2dJCVlozZpqtVkYhTTXDY0D07Dxo6WYTWGWgiPQwM0um4YIdgk81ktaLVS6 tEp4EVrp2i5uwqDesOtNStVFn0wkUDv45CVx.7xJCwOsqcsnZ2A_we2pLIHH4U9Eg6uAN_4AJu8b OpuWvZ36T68gYo_0ohpOzzRUWmQ.B3.CvKob.YbELhnZRHd3sJXRhHzbmzCnIAIo2SBjcX6ehsRc - X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Sun, 25 Dec 2022 23:44:43 +0000 Received: by hermes--production-bf1-5458f64d4-2b7vw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 390d506a34c71c5c80c8167413cb092e; Sun, 25 Dec 2022 23:44:39 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: git: d670a8f7c596 - main - growfs_fstab: add new /etc/rc.d script to add swap to fstab Date: Sun, 25 Dec 2022 15:44:27 -0800 References: <3F68EC4A-1D8A-409B-81D0-BECE377EFBE7@yahoo.com> To: "karels@freebsd.org" , dev-commits-src-main@freebsd.org In-Reply-To: <3F68EC4A-1D8A-409B-81D0-BECE377EFBE7@yahoo.com> Message-Id: X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spamd-Result: default: False [-3.49 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.989]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.32:from]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[yahoo.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MIME_TRACE(0.00)[0:+]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.64.32:from] X-Rspamd-Queue-Id: 4NgHZh6KZBz4NNZ X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N On Dec 25, 2022, at 14:41, Mark Millard wrote: > Mike Karels wrote on > Date: Sat, 10 Dec 2022 19:41:14 UTC : >=20 >> The branch main has been updated by karels: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dd670a8f7c596fd387823644c5cbf1dde= e788eee4 >>=20 >> commit d670a8f7c596fd387823644c5cbf1ddee788eee4 >> Author: Mike Karels >> AuthorDate: 2022-12-10 19:39:59 +0000 >> Commit: Mike Karels >> CommitDate: 2022-12-10 19:39:59 +0000 >>=20 >> growfs_fstab: add new /etc/rc.d script to add swap to fstab >>=20 >> The growfs_fstab script is a helper for the growfs script to add any >> new swap partition to /etc/fstab on first boot. If growfs adds a >> swap partition, it sets growfs_swap_pdev in the kenv. In this case, >> after the root file system is read/write, if there is no swap = partition >> in the fstab, growfs_fstab adds growfs_swap as a swap partition to = the >> fstab. Also, it runs dumpon to add the swap partition (as this >> happened earlier in the startup sequence). >>=20 >> Discussed with: cperciva >> Differential Revision: https://reviews.freebsd.org/D37463 >> . . . >=20 > I tried the new main [so: 14] snapshot, dd'd to a USB3 SSD and booted: >=20 > snaphot: = FreeBSD-14.0-CURRENT-arm64-aarch64-RPI-20221224-c89209c674f2-259842.img > so: FreeBSD 14.0-CURRENT #0 main-n259842-c89209c674f2: Sat Dec 24 = 05:52:28 UTC 2022 >=20 > Result (from the serial console capture): >=20 > Starting file system checks: > /dev/ufs/rootfs: FILE SYSTEM CLEAN; SKIPPING CHECKS > /dev/ufs/rootfs: clean, 599506 free (242 frags, 74908 blocks, 0.0% = fragmentation) > /etc/rc.d/growfs: 203: Syntax error: "(" unexpected (expecting "}") >=20 >=20 > Looks to be the ' in "Don't" in a supposed #comment that that instead = matches a prior awk use of ' unintentionally. Later in the line is: = "(decimal)" that supplies the "(" reported. >=20 To test more, I redid the dd and then replaced the problematical "Don't" with "Do not". (FYI: I shorten shell prompts in messages.) # gpart show =3D> 63 468862065 da0 MBR (224G) 63 1985 - free - (993K) 2048 102400 1 fat32lba [active] (50M) 104448 468757680 2 freebsd (224G) =3D> 0 468757680 da0s2 BSD (224G) 0 128 - free - (64K) 128 451979136 1 freebsd-ufs (216G) 451979264 16777216 2 freebsd-swap (8.0G) 468756480 1200 - free - (600K) But: # swapinfo Device 1K-blocks Used Avail Capacity So: no use of the swap was set up by default. # more /etc/fstab # Custom /etc/fstab for FreeBSD embedded images /dev/ufs/rootfs / ufs rw 1 = 1 /dev/msdosfs/EFI /boot/efi msdosfs rw,noatime = 0 0 tmpfs /tmp tmpfs rw,mode=3D1777 0 = 0 Nor did it appear that dumping was set up to use the swap. For reference: # ls -Tld /etc/rc.d/growfs* -r-xr-xr-x 1 root wheel 8133 Dec 25 22:47:48 2022 /etc/rc.d/growfs (So, no growfs_fstab script there.) However, there was an error message not tied to growfs that might indicate that some later processing was not done(?): . . . Starting devd. genet0: link state changed to UP sh: /usr/libexec/hyperv/hyperv_vfattach: not found Starting dhclient. . . . I'll note: # ls -Tld /dev/label/* crw-r----- 1 root operator 0x66 Dec 25 22:47:55 2022 = /dev/label/growfs_swap # swapon /dev/label/growfs_swap # swapinfo Device 1K-blocks Used Avail Capacity /dev/label/growfs_swap 8388604 0 8388604 0% So the label is in place for use. =3D=3D=3D Mark Millard marklmi at yahoo.com