RE: git: d670a8f7c596 - main - growfs_fstab: add new /etc/rc.d script to add swap to fstab

Mike Karels <karels_at_FreeBSD.org> wrote on
Date: Sat, 10 Dec 2022 19:41:14 UTC :

> The branch main has been updated by karels:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=d670a8f7c596fd387823644c5cbf1ddee788eee4
> 
> commit d670a8f7c596fd387823644c5cbf1ddee788eee4
> Author: Mike Karels <karels@FreeBSD.org>
> AuthorDate: 2022-12-10 19:39:59 +0000
> Commit: Mike Karels <karels@FreeBSD.org>
> CommitDate: 2022-12-10 19:39:59 +0000
> 
> growfs_fstab: add new /etc/rc.d script to add swap to fstab
> 
> The growfs_fstab script is a helper for the growfs script to add any
> new swap partition to /etc/fstab on first boot. If growfs adds a
> swap partition, it sets growfs_swap_pdev in the kenv. In this case,
> after the root file system is read/write, if there is no swap partition
> in the fstab, growfs_fstab adds growfs_swap as a swap partition to the
> fstab. Also, it runs dumpon to add the swap partition (as this
> happened earlier in the startup sequence).
> 
> Discussed with: cperciva
> Differential Revision: https://reviews.freebsd.org/D37463
> . . .

I tried the new main [so: 14] snapshot, dd'd to a USB3 SSD and booted:

snaphot: FreeBSD-14.0-CURRENT-arm64-aarch64-RPI-20221224-c89209c674f2-259842.img
so: FreeBSD 14.0-CURRENT #0 main-n259842-c89209c674f2: Sat Dec 24 05:52:28 UTC 2022

Result (from the serial console capture):

Starting file system checks:
/dev/ufs/rootfs: FILE SYSTEM CLEAN; SKIPPING CHECKS
/dev/ufs/rootfs: clean, 599506 free (242 frags, 74908 blocks, 0.0% fragmentation)
/etc/rc.d/growfs: 203: Syntax error: "(" unexpected (expecting "}")


Looks to be the ' in "Don't" in a supposed #comment that that instead matches a prior awk use of ' unintentionally. Later in the line is: "(decimal)" that supplies the "(" reported.


===
Mark Millard
marklmi at yahoo.com